diff mbox series

soc: renesas: use menu for Renesas SoC

Message ID 87sgd3gcv4.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series soc: renesas: use menu for Renesas SoC | expand

Commit Message

Kuninori Morimoto Aug. 4, 2020, 6:12 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Renesas related SoC settings are located on TOP level menu
when menuconfig, thus it is very verbose.
This patch groups Renesas related settings into
"Renesas SoC driver support" menu.

And it aligns config menu names.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/soc/renesas/Kconfig | 64 ++++++++++++++++++-------------------
 1 file changed, 32 insertions(+), 32 deletions(-)

Comments

Geert Uytterhoeven Aug. 5, 2020, 12:34 p.m. UTC | #1 
Hi Morimoto-san,

On Tue, Aug 4, 2020 at 8:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Renesas related SoC settings are located on TOP level menu
> when menuconfig, thus it is very verbose.
> This patch groups Renesas related settings into
> "Renesas SoC driver support" menu.
>
> And it aligns config menu names.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!
Unfortunately it doesn't apply against renesas-devel, as new SoCs have
been added.

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -config SOC_RENESAS
> +menuconfig SOC_RENESAS

Yes, that helps.

>         bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
>         default y if ARCH_RENESAS
>         select SOC_BUS
> @@ -174,35 +174,35 @@ endif # ARM
>  if ARM64
>
>  config ARCH_R8A774A1
> -       bool "Renesas RZ/G2M SoC Platform"
> +       bool "SoC Platform support for RZ/G2M"
>         select ARCH_RCAR_GEN3
>         select SYSC_R8A774A1
>         help
>           This enables support for the Renesas RZ/G2M SoC.
>
>  config ARCH_R8A774B1
> -       bool "Renesas RZ/G2N SoC Platform"
> +       bool "SoC Platform support for RZ/G2N"

[...]

Why these changes?

> @@ -262,79 +262,79 @@ endif # ARM64
>
>  # SoC
>  config SYSC_R8A7743
> -       bool "RZ/G1M System Controller support" if COMPILE_TEST
> +       bool "System Controller support for RZ/G1M" if COMPILE_TEST
>         select SYSC_RCAR
>
>  config SYSC_R8A7745
> -       bool "RZ/G1E System Controller support" if COMPILE_TEST
> +       bool "System Controller support for RZ/G1E" if COMPILE_TEST

[...]

Why these changes?

BTW, if you want to increase consistency, please also update the
descriptions for arm32 and family-specific options.

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Aug. 6, 2020, 12:12 a.m. UTC | #2 
Hi Geert

Thank you for your review

> Thanks for your patch!
> Unfortunately it doesn't apply against renesas-devel, as new SoCs have
> been added.

OK, I will re-post after your reply.


> >  config ARCH_R8A774A1
> > -       bool "Renesas RZ/G2M SoC Platform"
> > +       bool "SoC Platform support for RZ/G2M"
> >         select ARCH_RCAR_GEN3
> >         select SYSC_R8A774A1
> >         help
> >           This enables support for the Renesas RZ/G2M SoC.
> >
> >  config ARCH_R8A774B1
> > -       bool "Renesas RZ/G2N SoC Platform"
> > +       bool "SoC Platform support for RZ/G2N"
> 
> [...]
> 
> Why these changes?

Because if this patch was applied, these are under "Renesas" menu.

> >  # SoC
> >  config SYSC_R8A7743
> > -       bool "RZ/G1M System Controller support" if COMPILE_TEST
> > +       bool "System Controller support for RZ/G1M" if COMPILE_TEST
> >         select SYSC_RCAR
> >
> >  config SYSC_R8A7745
> > -       bool "RZ/G1E System Controller support" if COMPILE_TEST
> > +       bool "System Controller support for RZ/G1E" if COMPILE_TEST
> 
> [...]
> 
> Why these changes?

Because of good looking.

	- R-Car H2 System Controller support
	- R-Car M2-W/N System Controller support
	- R-Car V2H System Controller support
	- R-Car E2 System Controller support

	+ System Controller support for R-Car H2
	+ System Controller support for R-Car M2-W/N
	+ System Controller support for R-Car V2H
	+ System Controller support for R-Car E2

> BTW, if you want to increase consistency, please also update the
> descriptions for arm32 and family-specific options.

Sorry I don't understand this.
what does "arm32 and family-specific options" mean ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Geert Uytterhoeven Aug. 6, 2020, 8:56 a.m. UTC | #3 
Hi Morimoto-san,

On Thu, Aug 6, 2020 at 2:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > >  config ARCH_R8A774A1
> > > -       bool "Renesas RZ/G2M SoC Platform"
> > > +       bool "SoC Platform support for RZ/G2M"
> > >         select ARCH_RCAR_GEN3
> > >         select SYSC_R8A774A1
> > >         help
> > >           This enables support for the Renesas RZ/G2M SoC.
> > >
> > >  config ARCH_R8A774B1
> > > -       bool "Renesas RZ/G2N SoC Platform"
> > > +       bool "SoC Platform support for RZ/G2N"
> >
> > [...]
> >
> > Why these changes?
>
> Because if this patch was applied, these are under "Renesas" menu.

OK, and you want the SoC name last, for easier reading?

> > >  # SoC
> > >  config SYSC_R8A7743
> > > -       bool "RZ/G1M System Controller support" if COMPILE_TEST
> > > +       bool "System Controller support for RZ/G1M" if COMPILE_TEST
> > >         select SYSC_RCAR
> > >
> > >  config SYSC_R8A7745
> > > -       bool "RZ/G1E System Controller support" if COMPILE_TEST
> > > +       bool "System Controller support for RZ/G1E" if COMPILE_TEST
> >
> > [...]
> >
> > Why these changes?
>
> Because of good looking.
>
>         - R-Car H2 System Controller support
>         - R-Car M2-W/N System Controller support
>         - R-Car V2H System Controller support
>         - R-Car E2 System Controller support
>
>         + System Controller support for R-Car H2
>         + System Controller support for R-Car M2-W/N
>         + System Controller support for R-Car V2H
>         + System Controller support for R-Car E2

I see, easier reading, too.

> > BTW, if you want to increase consistency, please also update the
> > descriptions for arm32 and family-specific options.
>
> Sorry I don't understand this.
> what does "arm32 and family-specific options" mean ?

I mean the other options in drivers/soc/renesas/Kconfig:
  1. The arm32 SoCs are at the top, protected by "if ARM &&
      ARCH_RENESAS", and also under the "Renesas" menu,
  2. The family-specific options (R-Car/R-Mobile Reset/System Controller)
     are at the bottom, and part of the same menu.

If you change any, it would be good to have consistent descriptions for
all of these.
Thanks!

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Aug. 17, 2020, 2:38 a.m. UTC | #4 
Hi Geert

> > > BTW, if you want to increase consistency, please also update the
> > > descriptions for arm32 and family-specific options.
> >
> > Sorry I don't understand this.
> > what does "arm32 and family-specific options" mean ?
> 
> I mean the other options in drivers/soc/renesas/Kconfig:
>   1. The arm32 SoCs are at the top, protected by "if ARM &&
>       ARCH_RENESAS", and also under the "Renesas" menu,
>   2. The family-specific options (R-Car/R-Mobile Reset/System Controller)
>      are at the bottom, and part of the same menu.
> 
> If you change any, it would be good to have consistent descriptions for
> all of these.

In my understanding, it is "menu description" ?
But almost all other vender are using "xxx SoC driver support" for menu.
I think "Renesas SoC driver support" is simple and enough for it,
but am I misunderstanding ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto
diff mbox series

Patch

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 1982c7fb45fa..70934b352289 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -1,5 +1,5 @@ 
 # SPDX-License-Identifier: GPL-2.0
-config SOC_RENESAS
+menuconfig SOC_RENESAS
 	bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
 	default y if ARCH_RENESAS
 	select SOC_BUS
@@ -174,35 +174,35 @@  endif # ARM
 if ARM64
 
 config ARCH_R8A774A1
-	bool "Renesas RZ/G2M SoC Platform"
+	bool "SoC Platform support for RZ/G2M"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774A1
 	help
 	  This enables support for the Renesas RZ/G2M SoC.
 
 config ARCH_R8A774B1
-	bool "Renesas RZ/G2N SoC Platform"
+	bool "SoC Platform support for RZ/G2N"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774B1
 	help
 	  This enables support for the Renesas RZ/G2N SoC.
 
 config ARCH_R8A774C0
-	bool "Renesas RZ/G2E SoC Platform"
+	bool "SoC Platform support for RZ/G2E"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774C0
 	help
 	  This enables support for the Renesas RZ/G2E SoC.
 
 config ARCH_R8A77950
-	bool "Renesas R-Car H3 ES1.x SoC Platform"
+	bool "SoC Platform support for R-Car H3 ES1.x"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A7795
 	help
 	  This enables support for the Renesas R-Car H3 SoC (revision 1.x).
 
 config ARCH_R8A77951
-	bool "Renesas R-Car H3 ES2.0+ SoC Platform"
+	bool "SoC Platform support for R-Car H3 ES2.0+"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A7795
 	help
@@ -210,49 +210,49 @@  config ARCH_R8A77951
 	  later).
 
 config ARCH_R8A77960
-	bool "Renesas R-Car M3-W SoC Platform"
+	bool "SoC Platform support for R-Car M3-W"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77960
 	help
 	  This enables support for the Renesas R-Car M3-W SoC.
 
 config ARCH_R8A77961
-	bool "Renesas R-Car M3-W+ SoC Platform"
+	bool "SoC Platform support for R-Car M3-W+"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77961
 	help
 	  This enables support for the Renesas R-Car M3-W+ SoC.
 
 config ARCH_R8A77965
-	bool "Renesas R-Car M3-N SoC Platform"
+	bool "SoC Platform support for R-Car M3-N"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77965
 	help
 	  This enables support for the Renesas R-Car M3-N SoC.
 
 config ARCH_R8A77970
-	bool "Renesas R-Car V3M SoC Platform"
+	bool "SoC Platform support for R-Car V3M"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77970
 	help
 	  This enables support for the Renesas R-Car V3M SoC.
 
 config ARCH_R8A77980
-	bool "Renesas R-Car V3H SoC Platform"
+	bool "SoC Platform support for R-Car V3H"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77980
 	help
 	  This enables support for the Renesas R-Car V3H SoC.
 
 config ARCH_R8A77990
-	bool "Renesas R-Car E3 SoC Platform"
+	bool "SoC Platform support for R-Car E3"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77990
 	help
 	  This enables support for the Renesas R-Car E3 SoC.
 
 config ARCH_R8A77995
-	bool "Renesas R-Car D3 SoC Platform"
+	bool "SoC Platform support for R-Car D3"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77995
 	help
@@ -262,79 +262,79 @@  endif # ARM64
 
 # SoC
 config SYSC_R8A7743
-	bool "RZ/G1M System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7745
-	bool "RZ/G1E System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1E" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77470
-	bool "RZ/G1C System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1C" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774A1
-	bool "RZ/G2M System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774B1
-	bool "RZ/G2N System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774C0
-	bool "RZ/G2E System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2E" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7779
-	bool "R-Car H1 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H1" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7790
-	bool "R-Car H2 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H2" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7791
-	bool "R-Car M2-W/N System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M2-W/N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7792
-	bool "R-Car V2H System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V2H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7794
-	bool "R-Car E2 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car E2" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7795
-	bool "R-Car H3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77960
-	bool "R-Car M3-W System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-W" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77961
-	bool "R-Car M3-W+ System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-W+" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77965
-	bool "R-Car M3-N System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77970
-	bool "R-Car V3M System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V3M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77980
-	bool "R-Car V3H System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V3H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77990
-	bool "R-Car E3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car E3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77995
-	bool "R-Car D3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car D3" if COMPILE_TEST
 	select SYSC_RCAR
 
 # Family