| Message ID | 87tu0nz3xr.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC | expand |
Hi Morimoto-san, On Thu, Jan 19, 2023 at 2:52 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > "sydm" is bit name. Let's rename it as common "sys-dmac". > This patch fixes the numbering, too. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks for your patch! > --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c > @@ -176,8 +176,8 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = { > DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8), > DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8), > DEF_MOD("sdhi0", 706, R8A779A0_CLK_SD0), > - DEF_MOD("sydm1", 709, R8A779A0_CLK_S1D2), > - DEF_MOD("sydm2", 710, R8A779A0_CLK_S1D2), > + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2), > + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2), Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1" and "SYS-DMAC2". Shall we use that numbering? We also have labels "dmac1" and "dmac2" in DTS. > DEF_MOD("tmu0", 713, R8A779A0_CLK_CL16MCK), > DEF_MOD("tmu1", 714, R8A779A0_CLK_S1D4), > DEF_MOD("tmu2", 715, R8A779A0_CLK_S1D4), Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert > > + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2), > > + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2), > > Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1" > and "SYS-DMAC2". > Shall we use that numbering? > We also have labels "dmac1" and "dmac2" in DTS. OK, I see. I'm happy if you can modify it. Of course I'm happy to post v2 patch. Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Morimoto-san, On Wed, Jan 25, 2023 at 11:39 PM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > > + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2), > > > + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2), > > > > Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1" > > and "SYS-DMAC2". > > Shall we use that numbering? > > We also have labels "dmac1" and "dmac2" in DTS. > > OK, I see. > > I'm happy if you can modify it. > Of course I'm happy to post v2 patch. Thanks, no need for that, I will fix while applying. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-clk for v6.3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c index e02542ca24a0..b4baef3c9857 100644 --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c @@ -176,8 +176,8 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = { DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8), DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8), DEF_MOD("sdhi0", 706, R8A779A0_CLK_SD0), - DEF_MOD("sydm1", 709, R8A779A0_CLK_S1D2), - DEF_MOD("sydm2", 710, R8A779A0_CLK_S1D2), + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2), + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2), DEF_MOD("tmu0", 713, R8A779A0_CLK_CL16MCK), DEF_MOD("tmu1", 714, R8A779A0_CLK_S1D4), DEF_MOD("tmu2", 715, R8A779A0_CLK_S1D4),