| Message ID | 87v8qj92cu.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: Add V3H2 Condor-I board support | expand |
Hi Morimoto-san, On Tue, Aug 23, 2022 at 3:26 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds r8a77980A V3H2 (= r8a77980 ES2) basic SoC > support. It is using r8a77980 (= V3H) setting as-is for now. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a77980a.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the R-Car V3H2 (R8A77980A) SoC > + * > + * Copyright (C) 2022 Renesas Electronics Corp. > + */ > +#include "r8a77980.dtsi" Please override the root compatible value to "renesas,r8a77980a", "renesas,r8a77980", to match the bindings. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert Thank you for your feedback > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r8a77980a.dtsi > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the R-Car V3H2 (R8A77980A) SoC > > + * > > + * Copyright (C) 2022 Renesas Electronics Corp. > > + */ > > +#include "r8a77980.dtsi" > > Please override the root compatible value to > "renesas,r8a77980a", "renesas,r8a77980", to match the bindings. Sorry I don't understand about this comment. Is it for where/what or which patch ? Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Morimoto-san, On Mon, Aug 29, 2022 at 4:19 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/renesas/r8a77980a.dtsi > > > @@ -0,0 +1,7 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Device Tree Source for the R-Car V3H2 (R8A77980A) SoC > > > + * > > > + * Copyright (C) 2022 Renesas Electronics Corp. > > > + */ > > > +#include "r8a77980.dtsi" > > > > Please override the root compatible value to > > "renesas,r8a77980a", "renesas,r8a77980", to match the bindings. > > Sorry I don't understand about this comment. > Is it for where/what or which patch ? I mean to add the following to this patch: / { compatible = "renesas,r8a77980a", "renesas,r8a77980"; }; (like we do in all other SoC-specific .dtsi files that include another SoC-specific .dtsi file, e.g. arch/arm64/boot/dts/renesas/r8a779m0.dtsi). Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert > > > Please override the root compatible value to > > > "renesas,r8a77980a", "renesas,r8a77980", to match the bindings. > > > > Sorry I don't understand about this comment. > > Is it for where/what or which patch ? > > I mean to add the following to this patch: > > / { > compatible = "renesas,r8a77980a", "renesas,r8a77980"; > }; > > (like we do in all other SoC-specific .dtsi files that include another > SoC-specific .dtsi file, e.g. arch/arm64/boot/dts/renesas/r8a779m0.dtsi). Oh, I see ! Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/arch/arm64/boot/dts/renesas/r8a77980a.dtsi b/arch/arm64/boot/dts/renesas/r8a77980a.dtsi new file mode 100644 index 000000000000..ba49f50b964c --- /dev/null +++ b/arch/arm64/boot/dts/renesas/r8a77980a.dtsi @@ -0,0 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device Tree Source for the R-Car V3H2 (R8A77980A) SoC + * + * Copyright (C) 2022 Renesas Electronics Corp. + */ +#include "r8a77980.dtsi"