From patchwork Tue Aug 8 10:29:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 9887337 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CDBB860384 for ; Tue, 8 Aug 2017 10:29:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCCAE28692 for ; Tue, 8 Aug 2017 10:29:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF2B4287AB; Tue, 8 Aug 2017 10:29:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C56728692 for ; Tue, 8 Aug 2017 10:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdHHK3b (ORCPT ); Tue, 8 Aug 2017 06:29:31 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:38544 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbdHHK3a (ORCPT ); Tue, 8 Aug 2017 06:29:30 -0400 Received: by mail-wm0-f65.google.com with SMTP id y206so3430018wmd.5 for ; Tue, 08 Aug 2017 03:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ap0iTyB1JweCvRw5nc5fEIcahopYpgoZY3SVRhcp7oU=; b=F6vY7xnKjgLY4n846vc40ieY4DME7h4JFIqatDtWipnMZwBiGOxulRNi4W6Np/o0MT TLvCabdyHRmlP1GB6EhiGnQx7F/4AmgTYw6+K3O8APGDnlCD/w43phoGnFqQts5qqSc3 ITZlM64X2Syf9gKfUmgCd6Ogm6x3PNQ1H0dP4CX+UY0ja2Pi5fOuvSTmZPug4D629KVi 71bzDL3VyuUELX8svVXE/Zfo6xlynTNySoeCRjN54RzBMVekWqVozKNTjqz4oTKwcqFy OmZd9RHShbxZx1+BqRX/G295erhhamh7x4BHyoMQ9zg+rFo83pDbey3YtIyFK/ic21RG P1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ap0iTyB1JweCvRw5nc5fEIcahopYpgoZY3SVRhcp7oU=; b=Y8kyYlm6wdCppIPpP+knzqoQuWcVIZvt8AYl0CnBlT5i9MhptrXn9ZTYoAkXk4U2b3 CADLJz+/XawtpYiFceTDuScYWYNGCwH1HgUP1Dtz2oX0Jjmvgex1JfqjdwKslCzSgdY9 pV6PXm9Ptev1okb5uTSh/mY0oHyMaeUfRVVtCUelVVHrhjgmLb+4ylPLXiPQ4MDYiFfI 6/0uk82IBFj93bU5azzIVZqbYOJUEg/0vSLcOGN6LemtwYC+UYVf+ZP35uO4HAqrc7I+ ZofWimLKLzLf3BmAvYAIFGF5z78+AGbgY3+h2vPPmbZGlrMdDiEyqwU6ZLIijal/15MM Uqrw== X-Gm-Message-State: AHYfb5ir+2/8+Au8OIohLlZbVmaYFVQIG5Nivm/HmXCpGugu/0FF9qcF YxDoiQtyW3f59NIjTZgoGkhNuNDALA== X-Received: by 10.28.166.81 with SMTP id p78mr2299387wme.147.1502188169048; Tue, 08 Aug 2017 03:29:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.134.149 with HTTP; Tue, 8 Aug 2017 03:29:28 -0700 (PDT) In-Reply-To: <1502181568-12299-1-git-send-email-horms+renesas@verge.net.au> References: <1502181568-12299-1-git-send-email-horms+renesas@verge.net.au> From: Magnus Damm Date: Tue, 8 Aug 2017 19:29:28 +0900 Message-ID: Subject: Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings To: Simon Horman Cc: Linux-Renesas , "linux-arm-kernel@lists.infradead.org" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Simon, On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman wrote: > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place > of now deprecated non-generation specific R-Car GPIO fallback compat string > in the DT of Renesas ARM and arm64 based SoCs. > > This should have no run-time effect as the driver matches against the > per-SoC compat string before considering the fallback compat string. Thanks for your efforts.I have no issue with your series (apart from the GPIO and SATA mistake), but at the same time I believe the GPIO hardware itself is backwards compatible between various generations. In the nitpick department I would like to point out that the level of hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is similar to say good old uarts like 8250 and 16450 hardware. Basically a couple of registers were added to the hardware in a backwards-compatible way if I recall correctly. So if we are going to use "compatible" to point out if hardware is compatible or not then I would do this instead: At the same time I'm not sure if I care _that_ much. =) Thanks, / magnus --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -214,7 +214,7 @@ gpio0: gpio@e6050000 { compatible = "renesas,gpio-r8a7796", + "renesas,rcar-gen3-gpio"; "renesas,gpio-rcar"; reg = <0 0xe6050000 0 0x50>; interrupts = ; #gpio-cells = <2>;