From patchwork Fri Oct 28 08:14:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 9401483 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 83B0C60231 for ; Fri, 28 Oct 2016 08:14:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71A322A626 for ; Fri, 28 Oct 2016 08:14:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6636D2A628; Fri, 28 Oct 2016 08:14:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A378F2A626 for ; Fri, 28 Oct 2016 08:14:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934554AbcJ1IOa (ORCPT ); Fri, 28 Oct 2016 04:14:30 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:27939 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755697AbcJ1IO1 (ORCPT ); Fri, 28 Oct 2016 04:14:27 -0400 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie2.idc.renesas.com with ESMTP; 28 Oct 2016 17:14:22 +0900 Received: from relmlac1.idc.renesas.com (relmlac1.idc.renesas.com [10.200.69.21]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 097F561DF9; Fri, 28 Oct 2016 17:14:22 +0900 (JST) Received: by relmlac1.idc.renesas.com (Postfix, from userid 0) id 0635380030; Fri, 28 Oct 2016 17:14:22 +0900 (JST) Received: from relmlac1.idc.renesas.com (localhost [127.0.0.1]) by relmlac1.idc.renesas.com (Postfix) with ESMTP id 000668002F; Fri, 28 Oct 2016 17:14:21 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac1.idc.renesas.com with ESMTP id TAA12885; Fri, 28 Oct 2016 17:14:21 +0900 X-IronPort-AV: E=Sophos;i="5.31,557,1473087600"; d="scan'208";a="224190632" Received: from mail-hk2apc01lp0209.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.209]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA; 28 Oct 2016 17:14:20 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E4dKQKV/sZfFD1YDG2VoFdrWZBxSB6Okz3F6JKDO0eE=; b=M00XSQXhZHug9mMye+lNgaj7Tyt3gGP8658vYv6tPkfmQFkFd0c5StoLAWbg6Q00lmmEUpL9116bjHxSBtC9CbZhxX54FC4fMVwSKnfdrzXSZvacWRGWP0u2AJvGmT7+i+IRPcUN/rU07SGw0sy6lFhtR5Wbc8OaVRWgl5v/rTk= Received: from SIXPR06MB0559.apcprd06.prod.outlook.com (10.160.238.152) by SIXPR06MB0714.apcprd06.prod.outlook.com (10.162.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Fri, 28 Oct 2016 08:14:19 +0000 Received: from SIXPR06MB0559.apcprd06.prod.outlook.com ([10.160.238.152]) by SIXPR06MB0559.apcprd06.prod.outlook.com ([10.160.238.152]) with mapi id 15.01.0679.015; Fri, 28 Oct 2016 08:14:19 +0000 From: Yoshihiro Shimoda To: Geert Uytterhoeven , Xuan Truong Nguyen CC: Wolfram Sang , duclm , Ryusuke Sakato , Kuninori Morimoto , Magnus Damm , Geert Uytterhoeven , hideo inayoshi , =?utf-8?B?RHVuZ++8muS6uuOCvQ==?= , Cao Minh Hiep , Laurent Pinchart , Simon Horman , Linux-Renesas , =?utf-8?B?TmlrbGFzIFPDtmRlcmx1bmQ=?= Subject: RE: The failure summary report of GEN2 for linux stable v4.8 Thread-Topic: The failure summary report of GEN2 for linux stable v4.8 Thread-Index: AQHSKSeJqZwqCDi8kUK1P8H12xK9v6CuMYOAgADbCoCACCnVgIAAJP8AgAACPACABjUuQA== Date: Fri, 28 Oct 2016 08:14:19 +0000 Message-ID: References: <57A46D20.7040106@jinso.co.jp> <57C9764F.2070802@jinso.co.jp> <9d9a647b-d75f-e89a-2d4d-55e409ccabae@jinso.co.jp> <580620CD.50703@sang-engineering.com> <125b4831-cbdf-f8e1-da97-8ea9cf458c22@jinso.co.jp> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.144] x-ms-office365-filtering-correlation-id: 910e9c56-3046-448e-3056-08d3ff0a6a92 x-microsoft-exchange-diagnostics: 1; SIXPR06MB0714; 7:wRbiqQFCpqkViqi+3CYHBmZtEdZ61VgEmpDChz5aynFNswLs5leBOaroHmr12Va+erVKEN6idYZj0sVkUQthQ4D8ZYHIpToBURh5tNssNh9uzMqtf3cOiIsQsQ987xxt2FJRHRjxo7JyCU+cKZJfCA+UfDZU03+e6MlsuENYMntbj1KwVlUe5ZzVJpUCwViV6rlilB6IgsSQ79tUNN4IthBL3B5ILKIwzsflK7xaSFq4RZx4FmiipOeALUjjPLcazdkNRfBZfI4MDqepDNwQZPQ/VSaF37dUJ6fsAYR5+PSdmNQoRpmG/18XNipD3ntAeELNsDSf6Jb3m46dRwMhYJz1pYn7R6EhksEPS1ZQF+Q=; 20:VQLQjlSwUP8WRKVg9VvIBPOywI+5Hn6Ki+VkDWOvsxPBq/QAX5V3I5lsWy4WGnRZES+5kd2mrCoOEnPe0ut1iq/TVYkQsI784VzgnTAhcfl3b36xV3El8oshJMOQXpAABEcU8AoXNIv4rnkYE0EqXeqTrkZlO3LQTdcaToWIwsA= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SIXPR06MB0714; x-ld-processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:SIXPR06MB0714; BCL:0; PCL:0; RULEID:; SRVR:SIXPR06MB0714; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(377454003)(199003)(24454002)(189002)(8676002)(50986999)(97736004)(5890100001)(86362001)(189998001)(5001770100001)(2950100002)(3280700002)(5660300001)(101416001)(3660700001)(122556002)(33656002)(54356999)(76176999)(7416002)(81156014)(66066001)(81166006)(7696004)(19580405001)(92566002)(2900100001)(305945005)(7736002)(9686002)(102836003)(4326007)(8936002)(93886004)(7846002)(586003)(68736007)(76576001)(2906002)(19580395003)(3846002)(74316002)(87936001)(6116002)(11100500001)(10400500002)(106116001)(105586002)(106356001)(77096005)(5002640100001); DIR:OUT; SFP:1102; SCL:1; SRVR:SIXPR06MB0714; H:SIXPR06MB0559.apcprd06.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2016 08:14:19.0462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR06MB0714 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Geert-san, Xuan-san, > From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Geert > Uytterhoeven > Sent: Monday, October 24, 2016 6:21 PM > > On Mon, Oct 24, 2016 at 11:13 AM, Xuan Truong Nguyen > wrote: > >> This is with shmobile_defconfig? > > > > yes. we also attach the configs file we used > > (lager-scif-pio-v4.9-rc2.config) > > > >> Does it work better if you enable CONFIG_SERIAL_SH_SCI_DMA? > > > > yes, it's better a little bit. the kernel does not hangs up, but the warning > > message is output. > > please refer lager-scif-dma.log. > > > > we tested on v4.9-rc2. the issue is the same. > > > > if you need any information, please let us know. > > > WARNING: CPU: 0 PID: 2249 at drivers/dma/sh/rcar-dmac.c:1257 rcar_dmac_tx_status+0x128/0x4 > > No descriptor for cookie! > > > [] (rcar_dmac_tx_status) from [] (rx_timer_fn+0x48/0x148) > > > [] (rx_timer_fn) from [] (call_timer_fn+0x2c/0xa0) > > That looks like a race condition between timeout handling and actual completion > of the DMA? I found an issue in sh-sci.c and made a patch to resolve it. But, I'm not sure this is correct way. If this is correct way, we also have to fix dev_dbg() in some functions. Best regards, Yoshihiro Shimoda Since I send this email using Outlook, the patch format may be not good. --- From: Yoshihiro Shimoda Date: Fri, 28 Oct 2016 16:52:36 +0900 Subject: [PATCH] serial: sh-sci: remove dev_warn() to avoid double spin lock held If we use serial console and CONFIG_SERIAL_SH_SCI_DMA=y, since sci_dma_rx_push() is called with port->lock held and dev_warn() will call serial_console_write() finally, this is possible to call spin_lock{_irqsave}() twice. To avoid this, this patch remove dev_warn() in sci_dma_rx_push(). Reported-by: Xuan Truong Nguyen Signed-off-by: Yoshihiro Shimoda --- drivers/tty/serial/sh-sci.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 1.9.1 diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 4b26252..380b5d7 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1142,11 +1142,8 @@ static int sci_dma_rx_push(struct sci_port *s, void *buf, size_t count) int copied; copied = tty_insert_flip_string(tport, buf, count); - if (copied < count) { - dev_warn(port->dev, "Rx overrun: dropping %zu bytes\n", - count - copied); + if (copied < count) port->icount.buf_overrun++; - } port->icount.rx += copied;