diff mbox

[v2,1/4] vsp-lib: Filter non-filesystem regular characters

Message ID a6cd919063a1d5983be9dd24268881e23dc294aa.1486733302.git-series.kieran.bingham@ideasonboard.com (mailing list archive)
State Not Applicable
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Kieran Bingham Feb. 10, 2017, 1:30 p.m. UTC 
From: Kieran Bingham <kieran.bingham@ideasonboard.com>

Parameters can contain characters not suited to use in filenames.

Add '=','(', and ')' to the filtering, and replace with '_'

This reduces extra escaping, and quoting when working with the output
filenames of failed tests and VSP_KEEP_FRAMES=1

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 scripts/vsp-lib.sh | 3 +++
 1 file changed, 3 insertions(+)

Comments

Laurent Pinchart Feb. 12, 2017, 9:05 p.m. UTC | #1 
Hi Kieran,

Thank you for the patch.

On Friday 10 Feb 2017 13:30:05 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> Parameters can contain characters not suited to use in filenames.
> 
> Add '=','(', and ')' to the filtering, and replace with '_'
> 
> This reduces extra escaping, and quoting when working with the output
> filenames of failed tests and VSP_KEEP_FRAMES=1

I agree that some characters can increase the difficulty of handling file 
names in scripts or on the command line by requiring escaping. I would prefer 
fixing the scripts, but I'll accept this patch on the ground that the 
information loss caused by replacing the =, ( and ) characters with _ will not 
adversely affect our tests. If that turns out not to be true anymore in the 
future I reserve the right to revert the patch and ask you to fix your scripts 
:-)

> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  scripts/vsp-lib.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> index 8f2755b57519..9e5e57b8c4ba 100755
> --- a/scripts/vsp-lib.sh
> +++ b/scripts/vsp-lib.sh
> @@ -258,6 +258,9 @@ compare_frames() {
>  	local params=${args// /-}
>  	params=${params:+-$params}
>  	params=${params//\//_}
> +	params=${params//=/_}
> +	params=${params//(/_}
> +	params=${params//)/_}
>  	params=$in_fmt-$out_fmt-$size$params
> 
>  	if [ x$__vsp_pixel_perfect != xtrue ] ; then
diff mbox

Patch

diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
index 8f2755b57519..9e5e57b8c4ba 100755
--- a/scripts/vsp-lib.sh
+++ b/scripts/vsp-lib.sh
@@ -258,6 +258,9 @@  compare_frames() {
 	local params=${args// /-}
 	params=${params:+-$params}
 	params=${params//\//_}
+	params=${params//=/_}
+	params=${params//(/_}
+	params=${params//)/_}
 	params=$in_fmt-$out_fmt-$size$params
 
 	if [ x$__vsp_pixel_perfect != xtrue ] ; then