| Message ID | b133e895-8d5e-fbae-d15a-5cf759f09406@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 40d5c8e94751f4a4fa4e0e27e3805e201a4e79c0 |
| Delegated to: | Simon Horman |
| Headers | show |
On 02/16/2018 11:09 PM, Sergei Shtylyov wrote: > According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s > Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have > the A3IR area as a parent, thus the SYSC driver has those parents wrong... > > Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > drivers/soc/renesas/r8a77970-sysc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > Index: renesas/drivers/soc/renesas/r8a77970-sysc.c > =================================================================== > --- renesas.orig/drivers/soc/renesas/r8a77970-sysc.c > +++ renesas/drivers/soc/renesas/r8a77970-sysc.c Done against the recent 'devel' tag but should apply to Linus' repo... [...] MBR, Sergei
On Fri, Feb 16, 2018 at 9:09 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s > Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have > the A3IR area as a parent, thus the SYSC driver has those parents wrong... > > Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Sorry for missing this in my original review. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Feb 19, 2018 at 09:38:15AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 16, 2018 at 9:09 PM, Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: > > According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s > > Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have > > the A3IR area as a parent, thus the SYSC driver has those parents wrong... > > > > Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support") > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Sorry for missing this in my original review. Thanks, applied.
Index: renesas/drivers/soc/renesas/r8a77970-sysc.c =================================================================== --- renesas.orig/drivers/soc/renesas/r8a77970-sysc.c +++ renesas/drivers/soc/renesas/r8a77970-sysc.c @@ -25,12 +25,12 @@ static const struct rcar_sysc_area r8a77 PD_CPU_NOCR }, { "cr7", 0x240, 0, R8A77970_PD_CR7, R8A77970_PD_ALWAYS_ON }, { "a3ir", 0x180, 0, R8A77970_PD_A3IR, R8A77970_PD_ALWAYS_ON }, - { "a2ir0", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_ALWAYS_ON }, - { "a2ir1", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A2IR0 }, - { "a2ir2", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A2IR0 }, - { "a2ir3", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A2IR0 }, - { "a2sc0", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_ALWAYS_ON }, - { "a2sc1", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A2SC0 }, + { "a2ir0", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_A3IR }, + { "a2ir1", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A3IR }, + { "a2ir2", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A3IR }, + { "a2ir3", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A3IR }, + { "a2sc0", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_A3IR }, + { "a2sc1", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A3IR }, }; const struct rcar_sysc_info r8a77970_sysc_info __initconst = {
According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have the A3IR area as a parent, thus the SYSC driver has those parents wrong... Fixes: bab9b2a74fe9 ("soc: renesas: rcar-sysc: add R8A77970 support") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/soc/renesas/r8a77970-sysc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)