| Message ID | b26ef29e-0c26-6359-1205-735e6770eb10@infradead.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Randy, thanks for noticing, On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote: > On 01/16/2018 01:44 PM, Jacopo Mondi wrote: > > Hello, > > new version of CEU after Hans' review. > > > > Added his Acked-by to most patches and closed review comments. > > Running v4l2-compliance, I noticed a new failure introduced by the way I now > > calculate the plane sizes in set/try_fmt. > > I would expect that you have already seen this, but I get a build error > in renesas-ceu.c. Here is a small patch for it. Actually I did not. The compile error has been introduced by this commit commit 4e48afecd5ee3a394d228349fc1c33982e9fb557 Author: Mauro Carvalho Chehab <mchehab@s-opensource.com> Date: Wed Sep 27 10:12:00 2017 -0400 media: v4l2-async: simplify v4l2_async_subdev structure Which is not in v4.15-rc8 on which I have based my work on. As a general question, if I'm aiming to have my driver included in next release, should I always base my work on linux-next or it depends on sub-system/maintainers preferences? Thanks j > > --- > From: Randy Dunlap <rdunlap@infradead.org> > > Fix build error (on x86 with COMPILE_TEST): > > ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt': > ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union > ceu_sd->asd.match.fwnode.fwnode = > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > --- > drivers/media/platform/renesas-ceu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c > +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c > @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic > > ceu_sd->mbus_flags = fw_ep.bus.parallel.flags; > ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; > - ceu_sd->asd.match.fwnode.fwnode = > + ceu_sd->asd.match.fwnode = > fwnode_graph_get_remote_port_parent( > of_fwnode_handle(ep)); > >
On 01/21/2018 09:54 AM, jacopo mondi wrote: > Hi Randy, > thanks for noticing, > > On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote: >> On 01/16/2018 01:44 PM, Jacopo Mondi wrote: >>> Hello, >>> new version of CEU after Hans' review. >>> >>> Added his Acked-by to most patches and closed review comments. >>> Running v4l2-compliance, I noticed a new failure introduced by the way I now >>> calculate the plane sizes in set/try_fmt. >> >> I would expect that you have already seen this, but I get a build error >> in renesas-ceu.c. Here is a small patch for it. > > Actually I did not. > The compile error has been introduced by this commit > > commit 4e48afecd5ee3a394d228349fc1c33982e9fb557 > Author: Mauro Carvalho Chehab <mchehab@s-opensource.com> > Date: Wed Sep 27 10:12:00 2017 -0400 > media: v4l2-async: simplify v4l2_async_subdev structure > > Which is not in v4.15-rc8 on which I have based my work on. > > As a general question, if I'm aiming to have my driver included in > next release, should I always base my work on linux-next or it depends > on sub-system/maintainers preferences? That's up to the subsystem maintainer, but usually you should make sure that it will apply to linux-next or to the subsystem's "-next" tree, whatever that is called. >> >> --- >> From: Randy Dunlap <rdunlap@infradead.org> >> >> Fix build error (on x86 with COMPILE_TEST): >> >> ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt': >> ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union >> ceu_sd->asd.match.fwnode.fwnode = >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> --- >> drivers/media/platform/renesas-ceu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c >> +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c >> @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic >> >> ceu_sd->mbus_flags = fw_ep.bus.parallel.flags; >> ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; >> - ceu_sd->asd.match.fwnode.fwnode = >> + ceu_sd->asd.match.fwnode = >> fwnode_graph_get_remote_port_parent( >> of_fwnode_handle(ep)); >> >>
--- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic ceu_sd->mbus_flags = fw_ep.bus.parallel.flags; ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; - ceu_sd->asd.match.fwnode.fwnode = + ceu_sd->asd.match.fwnode = fwnode_graph_get_remote_port_parent( of_fwnode_handle(ep));