From patchwork Fri Jan 19 22:12:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10176035 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5AB5B60392 for ; Fri, 19 Jan 2018 22:12:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C7162846F for ; Fri, 19 Jan 2018 22:12:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F48E287BA; Fri, 19 Jan 2018 22:12:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E49062846F for ; Fri, 19 Jan 2018 22:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756666AbeASWMf (ORCPT ); Fri, 19 Jan 2018 17:12:35 -0500 Received: from merlin.infradead.org ([205.233.59.134]:58668 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756567AbeASWMc (ORCPT ); Fri, 19 Jan 2018 17:12:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DnH1CndSRiGtOoo8XMKOA9/BKj5cwM2F4XqJcKY5AvY=; b=EJgznoCatTjhaC9HbSBSDQmOCv SXLaksbiy6QlGFUOl5h7D/l6mUgIkjCGOk0VU66M739iBw8MysNtRXGr1DGJs4CUMZ5b0mkpWuJq0 +HVW52hZQK44TecaHOwixxxw41T7SE4LJluTf9QYtK8PNu2Zzqy7mR7auwSBkp3w+0oSvhlLQYf7Q ANrLcdad4V6JKaLloU2/LFY2iC1FX/C4mUYRBPgDagFS8ji4E2KIjVPuflmMx5dzh3oZh3g/+DMI8 JLb6CQWCQf8P/C+7SJozFQoWj6phq5DiK+Am6lo13WAgZvtatLhObpuKq3AfZ+tFePnwLhBVe5EXR KU3Wscww==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.site) by merlin.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1eceta-0001GJ-Gt; Fri, 19 Jan 2018 22:12:24 +0000 Subject: Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver To: Jacopo Mondi , laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com, geert@glider.be, hverkuil@xs4all.nl, mchehab@kernel.org, festevam@gmail.com, sakari.ailus@iki.fi, robh+dt@kernel.org, mark.rutland@arm.com, pombredanne@nexb.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1516139101-7835-1-git-send-email-jacopo+renesas@jmondi.org> From: Randy Dunlap Message-ID: Date: Fri, 19 Jan 2018 14:12:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1516139101-7835-1-git-send-email-jacopo+renesas@jmondi.org> Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/16/2018 01:44 PM, Jacopo Mondi wrote: > Hello, > new version of CEU after Hans' review. > > Added his Acked-by to most patches and closed review comments. > Running v4l2-compliance, I noticed a new failure introduced by the way I now > calculate the plane sizes in set/try_fmt. I would expect that you have already seen this, but I get a build error in renesas-ceu.c. Here is a small patch for it. --- From: Randy Dunlap Fix build error (on x86 with COMPILE_TEST): ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt': ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union ceu_sd->asd.match.fwnode.fwnode = Signed-off-by: Randy Dunlap --- drivers/media/platform/renesas-ceu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic ceu_sd->mbus_flags = fw_ep.bus.parallel.flags; ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; - ceu_sd->asd.match.fwnode.fwnode = + ceu_sd->asd.match.fwnode = fwnode_graph_get_remote_port_parent( of_fwnode_handle(ep));