| Message ID | bca1d6f6a0582988accbb48d709aa9de7ad49ed7.1689600771.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a7f880bc4c4b7b0755ed69b066a0707a39dd4cf0 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [resend] drm/panel: simple: Simplify matching using of_device_get_match_data() | expand |
On Mon, Jul 17, 2023 at 03:34:13PM +0200, Geert Uytterhoeven wrote: > Both the patform_driver and mipi_dsi_driver structures contain pointers > to the match table used, so the custom code to obtain match and match > data can be replaced by calls to of_device_get_match_data(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Simpler - nice. Reviewed-by: Sam Ravnborg <sam@ravnborg.org> I expect someone else to pick it up. Sam
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 241243447b3e5c81..70326f335f44c295 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -4457,13 +4457,13 @@ MODULE_DEVICE_TABLE(of, platform_of_match); static int panel_simple_platform_probe(struct platform_device *pdev) { - const struct of_device_id *id; + const struct panel_desc *desc; - id = of_match_node(platform_of_match, pdev->dev.of_node); - if (!id) + desc = of_device_get_match_data(&pdev->dev); + if (!desc) return -ENODEV; - return panel_simple_probe(&pdev->dev, id->data); + return panel_simple_probe(&pdev->dev, desc); } static void panel_simple_platform_remove(struct platform_device *pdev) @@ -4734,15 +4734,12 @@ MODULE_DEVICE_TABLE(of, dsi_of_match); static int panel_simple_dsi_probe(struct mipi_dsi_device *dsi) { const struct panel_desc_dsi *desc; - const struct of_device_id *id; int err; - id = of_match_node(dsi_of_match, dsi->dev.of_node); - if (!id) + desc = of_device_get_match_data(&dsi->dev); + if (!desc) return -ENODEV; - desc = id->data; - err = panel_simple_probe(&dsi->dev, &desc->desc); if (err < 0) return err;
Both the patform_driver and mipi_dsi_driver structures contain pointers to the match table used, so the custom code to obtain match and match data can be replaced by calls to of_device_get_match_data(). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/panel/panel-simple.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)