| Message ID | bccdf54a-70ba-ea8e-275f-9382dab5f1d4@cogentembedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add R-Car gen3 SoC support to the CMT driver | expand |
Hello Sergei, > From: linux-sh-owner@vger.kernel.org <linux-sh-owner@vger.kernel.org> > On Behalf Of Sergei Shtylyov > Sent: 05 September 2018 21:31 > > There's no good reason for the sh_cmt_of_table[] initializer to violate the 80- > column limit, especially after the commit 8d50e9476bb4 > ("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated") > partially fixed it -- fix the R-Car gen2 related entries as well. Seems sensible to me. Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> Kind regards, Chris > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > drivers/clocksource/sh_cmt.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > Index: renesas/drivers/clocksource/sh_cmt.c > ========================================================== > ========= > --- renesas.orig/drivers/clocksource/sh_cmt.c > +++ renesas/drivers/clocksource/sh_cmt.c > @@ -937,8 +937,14 @@ static const struct of_device_id sh_cmt_ > .compatible = "renesas,cmt-48-gen2", > .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] > }, > - { .compatible = "renesas,rcar-gen2-cmt0", .data = > &sh_cmt_info[SH_CMT0_RCAR_GEN2] }, > - { .compatible = "renesas,rcar-gen2-cmt1", .data = > &sh_cmt_info[SH_CMT1_RCAR_GEN2] }, > + { > + .compatible = "renesas,rcar-gen2-cmt0", > + .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] > + }, > + { > + .compatible = "renesas,rcar-gen2-cmt1", > + .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] > + }, > { } > }; > MODULE_DEVICE_TABLE(of, sh_cmt_of_table);
On Wed, Sep 5, 2018 at 10:31 PM Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > There's no good reason for the sh_cmt_of_table[] initializer to > violate the 80-column limit, especially after the commit 8d50e9476bb4 > ("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated") > partially fixed it -- fix the R-Car gen2 related entries as well. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Index: renesas/drivers/clocksource/sh_cmt.c =================================================================== --- renesas.orig/drivers/clocksource/sh_cmt.c +++ renesas/drivers/clocksource/sh_cmt.c @@ -937,8 +937,14 @@ static const struct of_device_id sh_cmt_ .compatible = "renesas,cmt-48-gen2", .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] }, - { .compatible = "renesas,rcar-gen2-cmt0", .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] }, - { .compatible = "renesas,rcar-gen2-cmt1", .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] }, + { + .compatible = "renesas,rcar-gen2-cmt0", + .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] + }, + { + .compatible = "renesas,rcar-gen2-cmt1", + .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] + }, { } }; MODULE_DEVICE_TABLE(of, sh_cmt_of_table);
There's no good reason for the sh_cmt_of_table[] initializer to violate the 80-column limit, especially after the commit 8d50e9476bb4 ("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated") partially fixed it -- fix the R-Car gen2 related entries as well. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/clocksource/sh_cmt.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)