| Message ID | f07c00b3-228c-e0d2-f7fe-38b8e9f25a4d@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f38c41727211f2cdd9bb6f2999d46daafeacc5aa |
| Delegated to: | Simon Horman |
| Headers | show |
On Fri, Apr 27, 2018 at 10:12:51PM +0300, Sergei Shtylyov wrote: > Define the generic R8A77980 part of the CAN-FD device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Thanks applied with the minor update noted below. > > --- > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > =================================================================== > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -38,6 +38,13 @@ > }; > }; > > + /* External CAN clock - to be overridden by boards that provide it */ > + can_clk: can { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > extal_clk: extal { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -170,6 +177,30 @@ > status = "disabled"; > }; > > + canfd: can@e66c0000 { > + compatible = "renesas,r8a77980-canfd", > + "renesas,rcar-gen3-canfd"; > + reg = <0 0xe66c0000 0 0x8000>; > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 914>, > + <&cpg CPG_CORE R8A77980_CLK_CANFD>, checkpatch tells me that line above uses spaces for indentation where a tab could be used. I fixed that up when applying the patch. > + <&can_clk>; > + clock-names = "fck", "canfd", "can_clk"; > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; > + assigned-clock-rates = <40000000>; > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > + status = "disabled"; > + > + channel0 { > + status = "disabled"; > + }; > + > + channel1 { > + status = "disabled"; > + }; > + }; > + > avb: ethernet@e6800000 { > compatible = "renesas,etheravb-r8a77980", > "renesas,etheravb-rcar-gen3"; >
Hello! On 5/2/2018 12:36 PM, Simon Horman wrote: >> Define the generic R8A77980 part of the CAN-FD device node. >> >> Based on the original (and large) patch by Vladimir Barinov. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Thanks applied with the minor update noted below. Thank you! >> --- >> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi >> =================================================================== >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi [...] >> @@ -170,6 +177,30 @@ >> status = "disabled"; >> }; >> >> + canfd: can@e66c0000 { >> + compatible = "renesas,r8a77980-canfd", >> + "renesas,rcar-gen3-canfd"; >> + reg = <0 0xe66c0000 0 0x8000>; >> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 914>, >> + <&cpg CPG_CORE R8A77980_CLK_CANFD>, > > checkpatch tells me that line above uses spaces for indentation where > a tab could be used. I fixed that up when applying the patch. Hum, I thought I fixed that... :-/ MBR, Sergei
Hi Sergei, On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Define the generic R8A77980 part of the CAN-FD device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Thanks for your patch! > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi = > @@ -170,6 +177,30 @@ > status = "disabled"; > }; > > + canfd: can@e66c0000 { > + compatible = "renesas,r8a77980-canfd", > + "renesas,rcar-gen3-canfd"; > + reg = <0 0xe66c0000 0 0x8000>; > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 914>, > + <&cpg CPG_CORE R8A77980_CLK_CANFD>, > + <&can_clk>; > + clock-names = "fck", "canfd", "can_clk"; > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; > + assigned-clock-rates = <40000000>; > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; You forgot the resets property. Gr{oetje,eeting}s, Geert
On Fri, May 04, 2018 at 09:52:38AM +0200, Geert Uytterhoeven wrote: > Hi Sergei, > > On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: > > Define the generic R8A77980 part of the CAN-FD device node. > > > > Based on the original (and large) patch by Vladimir Barinov. > > > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Thanks for your patch! > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > = > > @@ -170,6 +177,30 @@ > > status = "disabled"; > > }; > > > > + canfd: can@e66c0000 { > > + compatible = "renesas,r8a77980-canfd", > > + "renesas,rcar-gen3-canfd"; > > + reg = <0 0xe66c0000 0 0x8000>; > > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 914>, > > + <&cpg CPG_CORE R8A77980_CLK_CANFD>, > > + <&can_clk>; > > + clock-names = "fck", "canfd", "can_clk"; > > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; > > + assigned-clock-rates = <40000000>; > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > > You forgot the resets property. Thanks, I have sent a follow-up patch.
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi =================================================================== --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi @@ -38,6 +38,13 @@ }; }; + /* External CAN clock - to be overridden by boards that provide it */ + can_clk: can { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + extal_clk: extal { compatible = "fixed-clock"; #clock-cells = <0>; @@ -170,6 +177,30 @@ status = "disabled"; }; + canfd: can@e66c0000 { + compatible = "renesas,r8a77980-canfd", + "renesas,rcar-gen3-canfd"; + reg = <0 0xe66c0000 0 0x8000>; + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 914>, + <&cpg CPG_CORE R8A77980_CLK_CANFD>, + <&can_clk>; + clock-names = "fck", "canfd", "can_clk"; + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; + assigned-clock-rates = <40000000>; + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; + status = "disabled"; + + channel0 { + status = "disabled"; + }; + + channel1 { + status = "disabled"; + }; + }; + avb: ethernet@e6800000 { compatible = "renesas,etheravb-r8a77980", "renesas,etheravb-rcar-gen3";