| Message ID | fa61b464ae1aa7630e9024f091991937941d49f1.1718113630.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net] ravb: RAVB should select PAGE_POOL | expand |
On 11/06/2024 14:48, Geert Uytterhoeven wrote: > If CONFIG_PAGE_POOL is not enabled: > > aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! > aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected! > aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_rx_ring_refill': > ravb_main.c:(.text+0x8d8): undefined reference to `page_pool_alloc_pages' > aarch64-linux-gnu-ld: ravb_main.c:(.text+0x944): undefined reference to `page_pool_alloc_frag' > aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_ring_init': > ravb_main.c:(.text+0x1d4c): undefined reference to `page_pool_create' > > Fixes: 966726324b7b1400 ("net: ravb: Allocate RX buffers via page pool") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/ethernet/renesas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/renesas/Kconfig b/drivers/net/ethernet/renesas/Kconfig > index b03fae7a0f72ec5e..83de7e56da61bbb1 100644 > --- a/drivers/net/ethernet/renesas/Kconfig > +++ b/drivers/net/ethernet/renesas/Kconfig > @@ -33,6 +33,7 @@ config RAVB > select CRC32 > select MII > select MDIO_BITBANG > + select PAGE_POOL > select PHYLIB > select RESET_CONTROLLER > help Ah, I missed that page pool support can be enabled/disabled with a config option. Thanks for fixing this! Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
On 6/11/24 4:48 PM, Geert Uytterhoeven wrote: > If CONFIG_PAGE_POOL is not enabled: > > aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! > aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected! > aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_rx_ring_refill': > ravb_main.c:(.text+0x8d8): undefined reference to `page_pool_alloc_pages' > aarch64-linux-gnu-ld: ravb_main.c:(.text+0x944): undefined reference to `page_pool_alloc_frag' > aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_ring_init': > ravb_main.c:(.text+0x1d4c): undefined reference to `page_pool_create' Oopsie! :-) > Fixes: 966726324b7b1400 ("net: ravb: Allocate RX buffers via page pool") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 11 Jun 2024 15:48:48 +0200 you wrote: > If CONFIG_PAGE_POOL is not enabled: > > aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! > aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected! > aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_rx_ring_refill': > ravb_main.c:(.text+0x8d8): undefined reference to `page_pool_alloc_pages' > aarch64-linux-gnu-ld: ravb_main.c:(.text+0x944): undefined reference to `page_pool_alloc_frag' > aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_ring_init': > ravb_main.c:(.text+0x1d4c): undefined reference to `page_pool_create' > > [...] Here is the summary with links: - [net] ravb: RAVB should select PAGE_POOL https://git.kernel.org/netdev/net-next/c/721478fe6a5c You are awesome, thank you!
diff --git a/drivers/net/ethernet/renesas/Kconfig b/drivers/net/ethernet/renesas/Kconfig index b03fae7a0f72ec5e..83de7e56da61bbb1 100644 --- a/drivers/net/ethernet/renesas/Kconfig +++ b/drivers/net/ethernet/renesas/Kconfig @@ -33,6 +33,7 @@ config RAVB select CRC32 select MII select MDIO_BITBANG + select PAGE_POOL select PHYLIB select RESET_CONTROLLER help
If CONFIG_PAGE_POOL is not enabled: aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected! aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_rx_ring_refill': ravb_main.c:(.text+0x8d8): undefined reference to `page_pool_alloc_pages' aarch64-linux-gnu-ld: ravb_main.c:(.text+0x944): undefined reference to `page_pool_alloc_frag' aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_ring_init': ravb_main.c:(.text+0x1d4c): undefined reference to `page_pool_create' Fixes: 966726324b7b1400 ("net: ravb: Allocate RX buffers via page pool") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/renesas/Kconfig | 1 + 1 file changed, 1 insertion(+)