From patchwork Thu May 19 15:59:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 12855751 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC729C433F5 for ; Thu, 19 May 2022 16:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=CBIi8K/68vfQX/oZAuvq/kPLJ7M246XzTkOaIx1DwTU=; b=VuTbMKmEEA0lS/ x6O8Y09ypx8SnPvIOLWo29Y+kLWIFBXCmk+Li+vkgHl2RMKnVyV7td/DrZ9zh45gRukaRfTEDo15A Ln7WilC8pAbtv36xICBj1jBwuZi5PJQUt5UDw/Oxb9EHOW9+JwVuw7pG7TUj49Gb5RVysqYUrr+lp R1CN/ki4rsRXSmANIoBR3h6Ibr1oV/pKNloKXbCZBuBqC4nW9ZlqjIBv9TKXI+J97wyAEsKgrFm91 1+g1+TKhR5ua0LLfb+1i8j0HPQXvWjMSuI9pw8+Q3N5Cou23L0Z/nWD83aVd7lkj7MvBwtpA4VZvp 18RiWzqvefNq9EDnDEOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrih0-008IqL-A9; Thu, 19 May 2022 16:08:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrigx-008IpK-Gi for linux-riscv@lists.infradead.org; Thu, 19 May 2022 16:08:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86AD8B825B1; Thu, 19 May 2022 16:07:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06A04C385AA; Thu, 19 May 2022 16:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652976476; bh=jC9MZ56f6/y27GJlqudr3bwdHks9u/b7P6hjWSqT9ek=; h=From:To:Cc:Subject:Date:From; b=g26P3IuHY37nxhFCaqTOhYp/GEhMEQQhn/N/pE36Wbfp1AJ8D1gPD0Gx6H81PpzNo QsO0b/8lGWtzjC+3QO5y1Hj5EBu/7GgQW+CEXFA6Nx+HRnIZVUtfzaOVcqdfXKq2pz Mnb0FasGOQ34/dHbzc+nIowXPfnXr1weW61xJHcu+4JYlgEpHr3c0B8IasZ1A1wbHE dj48YH9X3qWtoV7U6KkyvRhYvUiZitKO+/dWc/Angsu2xeiqNbnNNyDjFCXoJsgv1T l0h13nMlVe6cqV8MT0Zkul7ubXXatoGz4MWQzRBySkfX6KXjiTGSoOgaNp77A+1gSB sqiwsvDPC+bcw== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Alexandre Ghiti , Anup Patel , Atish Patra Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: [PATCH v3 0/2] use static key to optimize pgtable_l4_enabled Date: Thu, 19 May 2022 23:59:16 +0800 Message-Id: <20220519155918.3882-1-jszhang@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220519_090759_740142_490CEB08 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The pgtable_l4|[l5]_enabled check sits at hot code path, performance is impacted a lot. Since pgtable_l4|[l5]_enabled isn't changed after boot, so static key can be used to solve the issue[1]. An unified way static key was introduced in [2], but it's only targets riscv isa extension. We dunno whether SV48 and SV57 will be considered as isa extension, so the unified solution isn't used for pgtable_l4[l5]_enabled. patch1 fix a NULL pointer deference if static key is used a bit earlier. patch2 uses the static key to optimize pgtable_l4|[l5]_enabled. [1] http://lists.infradead.org/pipermail/linux-riscv/2021-December/011164.html [2] https://lore.kernel.org/linux-riscv/20220517184453.3558-1-jszhang@kernel.org/T/#t Since v2: - move the W=1 warning fix to a separate patch - move the unified way to use static key to a new patch series. Since v1: - Add a W=1 warning fix - Fix W=1 error - Based on v5.18-rcN, since SV57 support is added, so convert pgtable_l5_enabled as well. Jisheng Zhang (2): riscv: move sbi_init() earlier before jump_label_init() riscv: turn pgtable_l4|[l5]_enabled to static key for RV64 arch/riscv/include/asm/pgalloc.h | 16 ++++---- arch/riscv/include/asm/pgtable-32.h | 3 ++ arch/riscv/include/asm/pgtable-64.h | 59 +++++++++++++++++--------- arch/riscv/include/asm/pgtable.h | 5 +-- arch/riscv/kernel/cpu.c | 4 +- arch/riscv/kernel/setup.c | 2 +- arch/riscv/mm/init.c | 64 ++++++++++++++++++----------- arch/riscv/mm/kasan_init.c | 16 ++++---- 8 files changed, 103 insertions(+), 66 deletions(-)