| Message ID | 20220726093729.1231867-1-xianting.tian@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RISC-V fixups to work with crash tool | expand |
On 26/07/2022 10:37, Xianting Tian wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Ah I see you've already sent a v4. > > Changes v1 -> v2: > 1, remove the patch "Add a fast call path of crash_kexec()" from this series > of patches, as it already applied to riscv git. > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98 > 2, add 'Reviewed-by' based on the comments of v1. > Changes v2 -> v3: > use "riscv" instead of "riscv64" in patch 5 subject line. > Changes v3 -> v4: > use "riscv" instead of "riscv64" in the summary of patch 5 subject line. There's no need to respin a series for the sake 3 characters in the cover letter (so sorry if you misunderstood me!)... > > Xianting Tian (5): > RISC-V: use __smp_processor_id() instead of smp_processor_id() > RISC-V: Add arch_crash_save_vmcoreinfo support > riscv: Add modules to virtual kernel memory layout dump > RISC-V: Fixup getting correct current pc > riscv: crash_core: Export kernel vm layout, phys_ram_base ...but it would've been good to align these to either "riscv:" or "RISC-V:" & not mix the two in a series. Don't do this right away, it is okay to wait for more significant changes before sending out a new version as this sort of thing could easily be changed when being applied. Thanks, Conor.
在 2022/7/26 下午5:52, Conor.Dooley@microchip.com 写道: > On 26/07/2022 10:37, Xianting Tian wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > Ah I see you've already sent a v4. > >> Changes v1 -> v2: >> 1, remove the patch "Add a fast call path of crash_kexec()" from this series >> of patches, as it already applied to riscv git. >> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98 >> 2, add 'Reviewed-by' based on the comments of v1. >> Changes v2 -> v3: >> use "riscv" instead of "riscv64" in patch 5 subject line. >> Changes v3 -> v4: >> use "riscv" instead of "riscv64" in the summary of patch 5 subject line. > There's no need to respin a series for the sake 3 characters in the cover > letter (so sorry if you misunderstood me!)... > >> Xianting Tian (5): >> RISC-V: use __smp_processor_id() instead of smp_processor_id() >> RISC-V: Add arch_crash_save_vmcoreinfo support >> riscv: Add modules to virtual kernel memory layout dump >> RISC-V: Fixup getting correct current pc >> riscv: crash_core: Export kernel vm layout, phys_ram_base > ...but it would've been good to align these to either "riscv:" or > "RISC-V:" & not mix the two in a series. Don't do this right away, > it is okay to wait for more significant changes before sending out > a new version as this sort of thing could easily be changed when > being applied. Many thanks, I got it, waiting these patches to be applied:) > > Thanks, > Conor. > >
I ever sent the patch 1 in the link: https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-3-xianting.tian@linux.alibaba.com/ And patch 2,3 in the link: https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-2-xianting.tian@linux.alibaba.com/ https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-3-xianting.tian@linux.alibaba.com/ This patch series just put these patches together, and with two new patch 4, 5. these five patches are the fixups for machine_kexec, kernel mode PC for vmcore and improvements for vmcoreinfo and memory layout dump. The main changes in the five patchs as below, Patch 1: use __smp_processor_id() instead of smp_processor_id() to cleanup the console prints. Patch 2: Add VM layout, va bits, ram base to vmcoreinfo, which can simplify the development of crash tool as ARM64 already did (arch/arm64/kernel/crash_core.c). Patch 3: Add modules to virtual kernel memory layout dump. Patch 4: Fixup to get correct kernel mode PC for vmcore. Patch 5: Updates vmcoreinfo.rst. With these 5 patches(patch 2 is must), crash tool can work well to analyze a vmcore. The patches for crash tool for RISCV64 is in the link: https://lore.kernel.org/linux-riscv/20220718025346.411758-1-xianting.tian@linux.alibaba.com/ Changes v1 -> v2: 1, remove the patch "Add a fast call path of crash_kexec()" from this series of patches, as it already applied to riscv git. https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98 2, add 'Reviewed-by' based on the comments of v1. Changes v2 -> v3: use "riscv" instead of "riscv64" in patch 5 subject line. Changes v3 -> v4: use "riscv" instead of "riscv64" in the summary of patch 5 subject line. Xianting Tian (5): RISC-V: use __smp_processor_id() instead of smp_processor_id() RISC-V: Add arch_crash_save_vmcoreinfo support riscv: Add modules to virtual kernel memory layout dump RISC-V: Fixup getting correct current pc riscv: crash_core: Export kernel vm layout, phys_ram_base .../admin-guide/kdump/vmcoreinfo.rst | 31 +++++++++++++++++++ arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++ arch/riscv/kernel/crash_save_regs.S | 2 +- arch/riscv/kernel/machine_kexec.c | 2 +- arch/riscv/mm/init.c | 4 +++ 6 files changed, 67 insertions(+), 2 deletions(-) create mode 100644 arch/riscv/kernel/crash_core.c