| Message ID | 20221123175652.327859-1-conor@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mpfs: fix handling failed service requests | expand |
From: Conor Dooley <conor.dooley@microchip.com> On Wed, 23 Nov 2022 17:56:50 +0000, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > As things stand, if a service request fails, we never know about it as > the status register is not read. This is quite obviously far from ideal, > as we would be reading garbage from the mailbox if a service was to > fail. > > [...] Applied to riscv-soc-fixes, thanks! [1/2] soc: microchip: mpfs: handle failed system service requests https://git.kernel.org/conor/c/730892135b7d Thanks, Conor.
From: Conor Dooley <conor.dooley@microchip.com> As things stand, if a service request fails, we never know about it as the status register is not read. This is quite obviously far from ideal, as we would be reading garbage from the mailbox if a service was to fail. This pair of patches adds handling of the service status to both sides of the mailbox implementation. @Jassi, there should be no build, or really functional, dependency here between patches. In the failing case, the buffer is allocated by the service driver, so things will "work" just as badly as they did before if only one of the patches is present. As a result, should be safe to do the mailbox patch via your tree & the client via the soc tree. Thanks, Conor. Changes since v2: - Stop redefining the already existing #defines for status register. Changes since v1: - Send the patches I meant to send, with an extraneous ; removed. Conor Dooley (2): soc: microchip: mpfs: handle failed system service requests mailbox: mpfs: read the system controller's status drivers/mailbox/mailbox-mpfs.c | 31 +++++++++++++++++++-- drivers/soc/microchip/mpfs-sys-controller.c | 6 ++++ 2 files changed, 34 insertions(+), 3 deletions(-)