From patchwork Wed Jun 14 10:47:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 13279907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F319AC001B1 for ; Wed, 14 Jun 2023 10:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HVh+AYSu+eg7RcM3zg4rqHKnOpHieSWI3GS9f0yh4tI=; b=UEpZBsoJ4TMDZh HsPP7N1A0GLvP6nwGLK2hMLvj8ntzPBhEryICCdhTkCL0jgYc6nzRCKEXCIBY+o/MyAWTu1Ki5vjG qOI1bVxZGeGzKC8NvCuz2I8A/Q6jsTQ1qzITVFY057IJ91BYbAj3UoBdAVK7Wrab2CjWj/BEDSF/F jsuwHqYlFeem5c4BwbHZE6bwqeE6449g7frQokOAa8z5hmBbMNS7XafX1Necf0/DvyKGBJ9x+BLr/ 5Nu5W+GRoPsvkBR8FD889MvJozPkrpu1IiOSDOjoSRK1R7H5zLcWoiPkprH2S4KeXMOHM8/vXXsZG J1Pk7HNRoJBErvsRhrJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9O2x-00BHBp-2P; Wed, 14 Jun 2023 10:48:15 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9O2p-00BH2a-3D for linux-riscv@lists.infradead.org; Wed, 14 Jun 2023 10:48:11 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3f8d2bfec9bso6339095e9.0 for ; Wed, 14 Jun 2023 03:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686739684; x=1689331684; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YbAe8Olo8d+O/JMM9uQNVCZgVL0gigLhGhA+en0kvok=; b=D6DK3qHiMKj0OKs4CS4G0xzWvshM/gn1znLagvFdy8cR0MK1OnaysTA/8CDX9OY5y8 3Rf79yKeIv9FXhxutRDsVoW6kJKMelhSskMY02U6dhn3nizXVJ0vmMI/jg6oMUWJcDaq yr7QZfEPaePwYBXRBBJNfrYfY8pOZxqUK9X0wqXSG3hk/de0kCc12mpZ/ocBTIgH31LS wDkFaIZVyXJ+04RarGuWEnK2SrdRtuSfwGryrBo9aCWWDZFjus9vdfJMQVqXiieNS21z BoQ7uJx2Jyb6Y+CgDk9/30IEqX17Y2YUSIQ0pOCDwZzcXswuXW3DeqrY0Prv++vZfeBV l8UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686739684; x=1689331684; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YbAe8Olo8d+O/JMM9uQNVCZgVL0gigLhGhA+en0kvok=; b=kfOHrsGzU3BgYXvuI8mbYSU2MT0SLCHcCx3eWGFcCbu5mBD6LVDsPvXpbZk4ldHONY mw6WpMgDtLSE5HdTCshdcn3uQU6B4wq+gDujZqQ5GOqoerOAASWr257tWeutVRk2d1mB ULMlZR8e9CBUftasJm+w3t1jWot3AIs+QvcH2gzxGCsEnAcN22x+hVIkO2qk/a4QijZ6 R6qK9W1UAIMHqMJNnDEbUkzw5hOhRPqE7RsEfWvCMRIbucIOR0wjgOedOPz4z3oDU44c iEy+rtnrYCiwlvV8WOWRR5ZxhZEtPIGiax+vASYRDqrAoCKQ1QfDs1JetvGzUJhrd75z dv5Q== X-Gm-Message-State: AC+VfDzky8Pu3EW+cWyM6Hhw1ebBDDjfyTnZ9fdAwHjPHwM9BIEhelDp /2JI+VwSoIULUK1zZcMZkbU= X-Google-Smtp-Source: ACHHUZ5CviUCkgB+kx1LQ+VLIkly+4LhcUL9f2t2NpNaca3MHILElkD/sf+NBgl2Ibdvr1Q9QicToQ== X-Received: by 2002:a05:600c:2310:b0:3f7:4961:52aa with SMTP id 16-20020a05600c231000b003f7496152aamr11798692wmo.15.1686739683654; Wed, 14 Jun 2023 03:48:03 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2501:c701:64d6:8737:b80d:a298]) by smtp.gmail.com with ESMTPSA id y10-20020a1c4b0a000000b003f5ffba9ae1sm17154904wma.24.2023.06.14.03.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 03:48:03 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Arnd Bergmann , Conor Dooley , Geert Uytterhoeven , Guo Ren , Andrew Jones , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , linux-riscv@lists.infradead.org, Christoph Hellwig Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Lad Prabhakar Subject: [PATCH v9 0/6] Add non-coherent DMA support for AX45MP Date: Wed, 14 Jun 2023 11:47:53 +0100 Message-Id: <20230614104759.228372-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_034808_038162_F93DF726 X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Lad Prabhakar Hi All, non-coherent DMA support for AX45MP ==================================== On the Andes AX45MP core, cache coherency is a specification option so it may not be supported. In this case DMA will fail. To get around with this issue this patch series does the below: 1] Andes alternative ports is implemented as errata which checks if the IOCP is missing and only then applies to CMO errata. One vendor specific SBI EXT (ANDES_SBI_EXT_IOCP_SW_WORKAROUND) is implemented as part of errata. Below are the configs which Andes port provides (and are selected by RZ/Five): - ERRATA_ANDES - ERRATA_ANDES_CMO OpenSBI patch supporting ANDES_SBI_EXT_IOCP_SW_WORKAROUND SBI can be found here, https://patchwork.ozlabs.org/project/opensbi/patch/20230317140357.14819-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ 2] Andes AX45MP core has a Programmable Physical Memory Attributes (PMA) block that allows dynamic adjustment of memory attributes in the runtime. It contains a configurable amount of PMA entries implemented as CSR registers to control the attributes of memory locations in interest. OpenSBI configures the PMA regions as required and creates a reserve memory node and propagates it to the higher boot stack. Currently OpenSBI (upstream) configures the required PMA region and passes this a shared DMA pool to Linux. reserved-memory { #address-cells = <2>; #size-cells = <2>; ranges; pma_resv0@58000000 { compatible = "shared-dma-pool"; reg = <0x0 0x58000000 0x0 0x08000000>; no-map; linux,dma-default; }; }; The above shared DMA pool gets appended to Linux DTB so the DMA memory requests go through this region. 3] We provide callbacks to synchronize specific content between memory and cache. 4] RZ/Five SoC selects the below configs - AX45MP_L2_CACHE - DMA_GLOBAL_POOL - ERRATA_ANDES - ERRATA_ANDES_CMO ----------x---------------------x--------------------x---------------x-------------- Note, - Ive used GCC 12.2.0 for compilation - Tested all the IP blocks on RZ/Five which use DMA - Patch series is dependent on the series from Arnd, https://patchwork.kernel.org/project/linux-riscv/cover/20230327121317.4081816-1-arnd@kernel.org/. (Ive rebased Arnd's series on v6.4-rc-1) - Patches applies on top of palmer/for-next (255b34d799dd) - Ive pushed the complete tree here https://github.com/prabhakarlad/linux/tree/rzfive-cmo-v9 - Previously the function pointer approach was NAKed by Christoph Hellwig but based on the discussion on #riscv Ive implemented this approach. v8 -> v9 * Dropped adding ALTERNATIVE_3 * Implemented function pointer support for nonstandard noncoherent systems * Added a new config option CONFIG_RISCV_NONSTANDARD_CACHE_OPS * Updated Andes errata code to drop patching the calls as we no more use ALTERNATIVE_X() macro. * Updated Andes CMO code to use function pointer for doing cache management. v7 -> v8 * Dropped using function pointers and switched to ALTERNATIVE_X() * Added new patches (#1, #2) v6 -> v7 * Reworked the code based on Arnd's work * Fixed review comments pointed by Arnd * Fixed review comments pointed by Conor v5.1 -> v6 * Dropped use of ALTERNATIVE_x() macro * Now switched to used function pointers for CMO * Moved driver to drivers/cache folder v5 -> v5.1 * https://patchwork.kernel.org/project/linux-riscv/list/?series=708610&state=%2A&archive=both v4 -> v5 * Rebased ALTERNATIVE_3() macro on top of Andrew's patches * Rebased the changes on top of Heiko's alternative call patches * Dropped configuring the PMA from Linux * Dropped configuring the L2 cache from Linux and dropped the binding for same * Now using runtime patching mechanism instead of compile time config RFC v3 -> v4 * Implemented ALTERNATIVE_3() macro * Now using runtime patching mechanism instead of compile time config * Added Andes CMO as and errata * Fixed comments pointed by Geert RFC v2-> RFC v3 * Fixed review comments pointed by Conor * Move DT binding into cache folder * Fixed DT binding check issue * Added andestech,ax45mp-cache.h header file * Now passing the flags for the PMA setup as part of andestech,pma-regions property. * Added andestech,inst/data-prefetch and andestech,tag/data-ram-ctl properties to configure the L2 cache. * Registered the cache driver as platform driver RFC v1-> RFC v2 * Moved out the code from arc/riscv to drivers/soc/renesas * Now handling the PMA setup as part of the L2 cache * Now making use of dma-noncoherent.c instead SoC specific implementation. * Dropped arch_dma_alloc() and arch_dma_free() * Switched to RISCV_DMA_NONCOHERENT * Included DT binding doc RFC v2: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20221003223222.448551-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ RFC v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220906102154.32526-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (6): riscv: asm: vendorid_list: Add Andes Technology to the vendors list riscv: errata: Add Andes alternative ports riscv: mm: dma-noncoherent: nonstandard cache operations support dt-bindings: cache: andestech,ax45mp-cache: Add DT binding documentation for L2 cache controller cache: Add L2 cache management for Andes AX45MP RISC-V core soc: renesas: Kconfig: Select the required configs for RZ/Five SoC .../cache/andestech,ax45mp-cache.yaml | 81 +++++++ MAINTAINERS | 7 + arch/riscv/Kconfig | 7 + arch/riscv/Kconfig.errata | 21 ++ arch/riscv/errata/Makefile | 1 + arch/riscv/errata/andes/Makefile | 1 + arch/riscv/errata/andes/errata.c | 66 +++++ arch/riscv/include/asm/alternative.h | 3 + arch/riscv/include/asm/dma-noncoherent.h | 28 +++ arch/riscv/include/asm/errata_list.h | 5 + arch/riscv/include/asm/vendorid_list.h | 1 + arch/riscv/kernel/alternative.c | 5 + arch/riscv/mm/dma-noncoherent.c | 43 ++++ arch/riscv/mm/pmem.c | 13 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/cache/Kconfig | 11 + drivers/cache/Makefile | 3 + drivers/cache/ax45mp_cache.c | 229 ++++++++++++++++++ drivers/soc/renesas/Kconfig | 4 + 20 files changed, 532 insertions(+) create mode 100644 Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml create mode 100644 arch/riscv/errata/andes/Makefile create mode 100644 arch/riscv/errata/andes/errata.c create mode 100644 arch/riscv/include/asm/dma-noncoherent.h create mode 100644 drivers/cache/Kconfig create mode 100644 drivers/cache/Makefile create mode 100644 drivers/cache/ax45mp_cache.c Tested-by: Conor Dooley # tyre-kicking on a d1