mbox series

[0/9] vdso: Remove timekeeper argument and includes

Message ID 20241010-vdso-generic-arch_update_vsyscall-v1-0-7fe5a3ea4382@linutronix.de (mailing list archive)
Headers show
Series vdso: Remove timekeeper argument and includes | expand

Message

Thomas Weißschuh Oct. 10, 2024, 3:44 p.m. UTC 
The timekeper argument __arm64_update_vsyscall() is never used and
for historical reasons many VDSO headers and implementations include
timekeeper headers.

With the move to the generic VDSO clock storage mode these are unused.
Including arbitrary headers from VDSO code can lead to build problems.

Remove all of them.

These patches are intended to be merged via the tip tree,
so following patches can be based on a unified base.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
Thomas Weißschuh (9):
      vdso: Remove timekeeper argument of __arch_update_vsyscall()
      arm: vdso: Remove timekeeper includes
      arm64: vdso: Remove timekeeper include
      powerpc/vdso: Remove timekeeper includes
      riscv: vdso: Remove timekeeper include
      s390/vdso: Remove timekeeper includes
      x86/vdso: Remove timekeeper include
      LoongArch: vdso: Remove timekeeper includes
      MIPS: vdso: Remove timekeeper includes

 arch/arm/include/asm/vdso/vsyscall.h       | 4 ----
 arch/arm/kernel/vdso.c                     | 1 -
 arch/arm64/include/asm/vdso/vsyscall.h     | 3 +--
 arch/arm64/kernel/vdso.c                   | 1 -
 arch/loongarch/include/asm/vdso/vsyscall.h | 4 ----
 arch/loongarch/kernel/vdso.c               | 1 -
 arch/mips/include/asm/vdso/vsyscall.h      | 1 -
 arch/mips/kernel/vdso.c                    | 1 -
 arch/powerpc/include/asm/vdso/vsyscall.h   | 4 ----
 arch/powerpc/kernel/time.c                 | 1 -
 arch/riscv/include/asm/vdso/vsyscall.h     | 4 ----
 arch/s390/include/asm/vdso/vsyscall.h      | 5 -----
 arch/s390/kernel/time.c                    | 1 -
 arch/x86/include/asm/vdso/vsyscall.h       | 1 -
 include/asm-generic/vdso/vsyscall.h        | 3 +--
 kernel/time/vsyscall.c                     | 2 +-
 16 files changed, 3 insertions(+), 34 deletions(-)
---
base-commit: 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b
change-id: 20241010-vdso-generic-arch_update_vsyscall-0618e98e2e97

Best regards,

Comments

Heiko Carstens Oct. 10, 2024, 4:01 p.m. UTC | #1 
On Thu, Oct 10, 2024 at 05:44:49PM +0200, Thomas Weißschuh wrote:
> Since the generic VDSO clock mode storage is used, this header file is
> unused and can be removed.
> 
> This avoids including a non-VDSO header while building the VDSO,
> which can lead to compilation errors.
> 
> Also drop the comment which is out of date and in the wrong place.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
>  arch/s390/include/asm/vdso/vsyscall.h | 5 -----
>  arch/s390/kernel/time.c               | 1 -
>  2 files changed, 6 deletions(-)

Acked-by: Heiko Carstens <hca@linux.ibm.com>