| Message ID | 1585668191-16287-2-git-send-email-vincent.chen@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: Add KGDB and KDB support | expand |
On Tue, Mar 31, 2020 at 11:23:07PM +0800, Vincent Chen wrote: > The break instruction in RISC-V does not have an immediate value field, so > the kernel cannot identify the purpose of each trap exception through the > opcode. This makes the existing identification schemes in other > architecture unsuitable for the RISC-V kernel. To solve this problem, this > patch adds kgdb_has_hit_break(), which can help RISC-V kernel identify > the KGDB trap exception. I was just reflecting on this again. The approach is fine from a kgdb point of view (where breakpoints are expensive heavy weight operations) but it might be wise to share how much implementing kgdb in this manner slows down kprobe tracing since these are normally pretty light weight. If the benchmarks do look bad I'd certainly entertain patches to optimize kgdb_has_hit_break(). For example by tracking the highest currently allocated breakpoint number would make a big difference (since it would normally be zero or close to). Daniel. > > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > kernel/debug/debug_core.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c > index 2b7c9b67931d..01bc3eea3d4d 100644 > --- a/kernel/debug/debug_core.c > +++ b/kernel/debug/debug_core.c > @@ -417,6 +417,18 @@ int kgdb_isremovedbreak(unsigned long addr) > return 0; > } > > +int kgdb_has_hit_break(unsigned long addr) > +{ > + int i; > + > + for (i = 0; i < KGDB_MAX_BREAKPOINTS; i++) { > + if (kgdb_break[i].state == BP_ACTIVE && > + kgdb_break[i].bpt_addr == addr) > + return 1; > + } > + return 0; > +} > + > int dbg_remove_all_break(void) > { > int error; > -- > 2.7.4 >
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index 2b7c9b67931d..01bc3eea3d4d 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -417,6 +417,18 @@ int kgdb_isremovedbreak(unsigned long addr) return 0; } +int kgdb_has_hit_break(unsigned long addr) +{ + int i; + + for (i = 0; i < KGDB_MAX_BREAKPOINTS; i++) { + if (kgdb_break[i].state == BP_ACTIVE && + kgdb_break[i].bpt_addr == addr) + return 1; + } + return 0; +} + int dbg_remove_all_break(void) { int error;