| Message ID | 1619683116-196404-1-git-send-email-vincent.chen@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: enable SiFive errata CIP-453 and CIP-1200 Kconfig only if CONFIG_64BIT=y | expand |
Hi Palmer, This patch is used to resolve issues that occurred in the "riscv: sifive: Apply errata "cip-453" patch" reported by the Linux test robot. Is it ok to use this separate patch to fix this issue, or should I re-send the entire patch set including this fix? Thanks, Vincent Chen On Thu, Apr 29, 2021 at 3:58 PM Vincent Chen <vincent.chen@sifive.com> wrote: > > The corresponding hardware issues of CONFIG_ERRATA_SIFIVE_CIP_453 and > CONFIG_ERRATA_SIFIVE_CIP_1200 only exist in the SiFive 64bit CPU cores. > Therefore, these two errata are required only if CONFIG_64BIT=y > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > --- > arch/riscv/Kconfig.erratas | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/Kconfig.erratas b/arch/riscv/Kconfig.erratas > index d5d03ae..b44d6ec 100644 > --- a/arch/riscv/Kconfig.erratas > +++ b/arch/riscv/Kconfig.erratas > @@ -21,7 +21,7 @@ config ERRATA_SIFIVE > > config ERRATA_SIFIVE_CIP_453 > bool "Apply SiFive errata CIP-453" > - depends on ERRATA_SIFIVE > + depends on ERRATA_SIFIVE && 64BIT > default y > help > This will apply the SiFive CIP-453 errata to add sign extension > @@ -32,7 +32,7 @@ config ERRATA_SIFIVE_CIP_453 > > config ERRATA_SIFIVE_CIP_1200 > bool "Apply SiFive errata CIP-1200" > - depends on ERRATA_SIFIVE > + depends on ERRATA_SIFIVE && 64BIT > default y > help > This will apply the SiFive CIP-1200 errata to repalce all > -- > 2.7.4 >
On Thu, 29 Apr 2021 00:58:36 PDT (-0700), vincent.chen@sifive.com wrote: > The corresponding hardware issues of CONFIG_ERRATA_SIFIVE_CIP_453 and > CONFIG_ERRATA_SIFIVE_CIP_1200 only exist in the SiFive 64bit CPU cores. > Therefore, these two errata are required only if CONFIG_64BIT=y > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > --- > arch/riscv/Kconfig.erratas | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/Kconfig.erratas b/arch/riscv/Kconfig.erratas > index d5d03ae..b44d6ec 100644 > --- a/arch/riscv/Kconfig.erratas > +++ b/arch/riscv/Kconfig.erratas > @@ -21,7 +21,7 @@ config ERRATA_SIFIVE > > config ERRATA_SIFIVE_CIP_453 > bool "Apply SiFive errata CIP-453" > - depends on ERRATA_SIFIVE > + depends on ERRATA_SIFIVE && 64BIT > default y > help > This will apply the SiFive CIP-453 errata to add sign extension > @@ -32,7 +32,7 @@ config ERRATA_SIFIVE_CIP_453 > > config ERRATA_SIFIVE_CIP_1200 > bool "Apply SiFive errata CIP-1200" > - depends on ERRATA_SIFIVE > + depends on ERRATA_SIFIVE && 64BIT > default y > help > This will apply the SiFive CIP-1200 errata to repalce all Thanks, this is on for-next.
diff --git a/arch/riscv/Kconfig.erratas b/arch/riscv/Kconfig.erratas index d5d03ae..b44d6ec 100644 --- a/arch/riscv/Kconfig.erratas +++ b/arch/riscv/Kconfig.erratas @@ -21,7 +21,7 @@ config ERRATA_SIFIVE config ERRATA_SIFIVE_CIP_453 bool "Apply SiFive errata CIP-453" - depends on ERRATA_SIFIVE + depends on ERRATA_SIFIVE && 64BIT default y help This will apply the SiFive CIP-453 errata to add sign extension @@ -32,7 +32,7 @@ config ERRATA_SIFIVE_CIP_453 config ERRATA_SIFIVE_CIP_1200 bool "Apply SiFive errata CIP-1200" - depends on ERRATA_SIFIVE + depends on ERRATA_SIFIVE && 64BIT default y help This will apply the SiFive CIP-1200 errata to repalce all
The corresponding hardware issues of CONFIG_ERRATA_SIFIVE_CIP_453 and CONFIG_ERRATA_SIFIVE_CIP_1200 only exist in the SiFive 64bit CPU cores. Therefore, these two errata are required only if CONFIG_64BIT=y Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Vincent Chen <vincent.chen@sifive.com> --- arch/riscv/Kconfig.erratas | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)