| Message ID | 20210123133333.736453-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] doc: gcc-plugins: drop more stale information | expand |
On Sat, Jan 23, 2021 at 10:34 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > [1] Drop the version information > > The range of the supported GCC versions are always changing. The > current minimal GCC version is 4.9, and commit 1e860048c53e > ("gcc-plugins: simplify GCC plugin-dev capability test") removed the > old code accordingly. > > We do not need to mention specific version ranges like "all gcc versions > from 4.5 to 6.0" since we forget to update the documentation when we > raise the minimal compiler version. > > [2] Drop the C compiler statements > > Since commit 77342a02ff6e ("gcc-plugins: drop support for GCC <= 4.7") > the GCC plugin infrastructure only supports g++. > > [3] Drop supported architectures > > As of v5.11-rc4, the infrastructure supports more architectures; > arm, arm64, mips, powerpc, riscv, s390, um, and x86. (just grep > "select HAVE_GCC_PLUGINS") Again, we miss to update this document when a > new architecture is supported. Let's just say "only some architectures". > > [4] Update the apt-get example > > We are now discussing to bump the minimal version to GCC 5. The GCC 4.9 > support will be removed sooner or later. Change the package example to > gcc-10-plugin-dev while we are here. > > [5] Update the build target > > Since commit ce2fd53a10c7 ("kbuild: descend into scripts/gcc-plugins/ > via scripts/Makefile"), "make gcc-plugins" is not supported. > "make scripts" builds all the enabled plugins, including some other > tools. > > [6] Update the steps for adding a new plugin > > At first, all CONFIG options for GCC plugins were located in arch/Kconfig. > After commit 45332b1bdfdc ("gcc-plugins: split out Kconfig entries to > scripts/gcc-plugins/Kconfig"), scripts/gcc-plugins/Kconfig became the > central place to collect plugin CONFIG options. In my understanding, > this requirement no longer exists because commit 9f671e58159a ("security: > Create "kernel hardening" config area") moved some of plugin CONFIG > options to another file. Find an appropriate place to add the new CONFIG. > > The sub-directory support was never used by anyone, and removed by > commit c17d6179ad5a ("gcc-plugins: remove unused GCC_PLUGIN_SUBDIR"). > > Remove the useless $(src)/ prefix. Applied to linux-kbuild. > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Changes in v2: > - Remove the info about sub-directory support > > Documentation/kbuild/gcc-plugins.rst | 31 +++++++++++++--------------- > 1 file changed, 14 insertions(+), 17 deletions(-) > > diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst > index 63379d0150e3..979887558e72 100644 > --- a/Documentation/kbuild/gcc-plugins.rst > +++ b/Documentation/kbuild/gcc-plugins.rst > @@ -11,16 +11,13 @@ compiler [1]_. They are useful for runtime instrumentation and static analysis. > We can analyse, change and add further code during compilation via > callbacks [2]_, GIMPLE [3]_, IPA [4]_ and RTL passes [5]_. > > -The GCC plugin infrastructure of the kernel supports all gcc versions from > -4.5 to 6.0, building out-of-tree modules, cross-compilation and building in a > -separate directory. > -Plugin source files have to be compilable by both a C and a C++ compiler as well > -because gcc versions 4.5 and 4.6 are compiled by a C compiler, > -gcc-4.7 can be compiled by a C or a C++ compiler, > -and versions 4.8+ can only be compiled by a C++ compiler. > +The GCC plugin infrastructure of the kernel supports building out-of-tree > +modules, cross-compilation and building in a separate directory. > +Plugin source files have to be compilable by a C++ compiler. > > -Currently the GCC plugin infrastructure supports only the x86, arm, arm64 and > -powerpc architectures. > +Currently the GCC plugin infrastructure supports only some architectures. > +Grep "select HAVE_GCC_PLUGINS" to find out which architectures support > +GCC plugins. > > This infrastructure was ported from grsecurity [6]_ and PaX [7]_. > > @@ -53,8 +50,7 @@ $(src)/scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h, > $(src)/scripts/gcc-plugins/gcc-generate-rtl-pass.h** > > These headers automatically generate the registration structures for > - GIMPLE, SIMPLE_IPA, IPA and RTL passes. They support all gcc versions > - from 4.5 to 6.0. > + GIMPLE, SIMPLE_IPA, IPA and RTL passes. > They should be preferred to creating the structures by hand. > > > @@ -62,9 +58,9 @@ Usage > ===== > > You must install the gcc plugin headers for your gcc version, > -e.g., on Ubuntu for gcc-4.9:: > +e.g., on Ubuntu for gcc-10:: > > - apt-get install gcc-4.9-plugin-dev > + apt-get install gcc-10-plugin-dev > > Or on Fedora:: > > @@ -76,7 +72,7 @@ Enable a GCC plugin based feature in the kernel config:: > > To compile only the plugin(s):: > > - make gcc-plugins > + make scripts > > or just run the kernel make and compile the whole kernel with > the cyclomatic complexity GCC plugin. > @@ -85,7 +81,8 @@ the cyclomatic complexity GCC plugin. > 4. How to add a new GCC plugin > ============================== > > -The GCC plugins are in $(src)/scripts/gcc-plugins/. You can use a file or a directory > -here. It must be added to $(src)/scripts/gcc-plugins/Makefile, > -$(src)/scripts/Makefile.gcc-plugins and $(src)/arch/Kconfig. > +The GCC plugins are in scripts/gcc-plugins/. You need to put plugin source files > +right under scripts/gcc-plugins/. Creating subdirectories is not supported. > +It must be added to scripts/gcc-plugins/Makefile, scripts/Makefile.gcc-plugins > +and a relevant Kconfig file. > See the cyc_complexity_plugin.c (CONFIG_GCC_PLUGIN_CYC_COMPLEXITY) GCC plugin. > -- > 2.27.0 >
diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst index 63379d0150e3..979887558e72 100644 --- a/Documentation/kbuild/gcc-plugins.rst +++ b/Documentation/kbuild/gcc-plugins.rst @@ -11,16 +11,13 @@ compiler [1]_. They are useful for runtime instrumentation and static analysis. We can analyse, change and add further code during compilation via callbacks [2]_, GIMPLE [3]_, IPA [4]_ and RTL passes [5]_. -The GCC plugin infrastructure of the kernel supports all gcc versions from -4.5 to 6.0, building out-of-tree modules, cross-compilation and building in a -separate directory. -Plugin source files have to be compilable by both a C and a C++ compiler as well -because gcc versions 4.5 and 4.6 are compiled by a C compiler, -gcc-4.7 can be compiled by a C or a C++ compiler, -and versions 4.8+ can only be compiled by a C++ compiler. +The GCC plugin infrastructure of the kernel supports building out-of-tree +modules, cross-compilation and building in a separate directory. +Plugin source files have to be compilable by a C++ compiler. -Currently the GCC plugin infrastructure supports only the x86, arm, arm64 and -powerpc architectures. +Currently the GCC plugin infrastructure supports only some architectures. +Grep "select HAVE_GCC_PLUGINS" to find out which architectures support +GCC plugins. This infrastructure was ported from grsecurity [6]_ and PaX [7]_. @@ -53,8 +50,7 @@ $(src)/scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h, $(src)/scripts/gcc-plugins/gcc-generate-rtl-pass.h** These headers automatically generate the registration structures for - GIMPLE, SIMPLE_IPA, IPA and RTL passes. They support all gcc versions - from 4.5 to 6.0. + GIMPLE, SIMPLE_IPA, IPA and RTL passes. They should be preferred to creating the structures by hand. @@ -62,9 +58,9 @@ Usage ===== You must install the gcc plugin headers for your gcc version, -e.g., on Ubuntu for gcc-4.9:: +e.g., on Ubuntu for gcc-10:: - apt-get install gcc-4.9-plugin-dev + apt-get install gcc-10-plugin-dev Or on Fedora:: @@ -76,7 +72,7 @@ Enable a GCC plugin based feature in the kernel config:: To compile only the plugin(s):: - make gcc-plugins + make scripts or just run the kernel make and compile the whole kernel with the cyclomatic complexity GCC plugin. @@ -85,7 +81,8 @@ the cyclomatic complexity GCC plugin. 4. How to add a new GCC plugin ============================== -The GCC plugins are in $(src)/scripts/gcc-plugins/. You can use a file or a directory -here. It must be added to $(src)/scripts/gcc-plugins/Makefile, -$(src)/scripts/Makefile.gcc-plugins and $(src)/arch/Kconfig. +The GCC plugins are in scripts/gcc-plugins/. You need to put plugin source files +right under scripts/gcc-plugins/. Creating subdirectories is not supported. +It must be added to scripts/gcc-plugins/Makefile, scripts/Makefile.gcc-plugins +and a relevant Kconfig file. See the cyc_complexity_plugin.c (CONFIG_GCC_PLUGIN_CYC_COMPLEXITY) GCC plugin.
[1] Drop the version information The range of the supported GCC versions are always changing. The current minimal GCC version is 4.9, and commit 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test") removed the old code accordingly. We do not need to mention specific version ranges like "all gcc versions from 4.5 to 6.0" since we forget to update the documentation when we raise the minimal compiler version. [2] Drop the C compiler statements Since commit 77342a02ff6e ("gcc-plugins: drop support for GCC <= 4.7") the GCC plugin infrastructure only supports g++. [3] Drop supported architectures As of v5.11-rc4, the infrastructure supports more architectures; arm, arm64, mips, powerpc, riscv, s390, um, and x86. (just grep "select HAVE_GCC_PLUGINS") Again, we miss to update this document when a new architecture is supported. Let's just say "only some architectures". [4] Update the apt-get example We are now discussing to bump the minimal version to GCC 5. The GCC 4.9 support will be removed sooner or later. Change the package example to gcc-10-plugin-dev while we are here. [5] Update the build target Since commit ce2fd53a10c7 ("kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile"), "make gcc-plugins" is not supported. "make scripts" builds all the enabled plugins, including some other tools. [6] Update the steps for adding a new plugin At first, all CONFIG options for GCC plugins were located in arch/Kconfig. After commit 45332b1bdfdc ("gcc-plugins: split out Kconfig entries to scripts/gcc-plugins/Kconfig"), scripts/gcc-plugins/Kconfig became the central place to collect plugin CONFIG options. In my understanding, this requirement no longer exists because commit 9f671e58159a ("security: Create "kernel hardening" config area") moved some of plugin CONFIG options to another file. Find an appropriate place to add the new CONFIG. The sub-directory support was never used by anyone, and removed by commit c17d6179ad5a ("gcc-plugins: remove unused GCC_PLUGIN_SUBDIR"). Remove the useless $(src)/ prefix. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Changes in v2: - Remove the info about sub-directory support Documentation/kbuild/gcc-plugins.rst | 31 +++++++++++++--------------- 1 file changed, 14 insertions(+), 17 deletions(-)