| Message ID | 20210530132217.7851-1-vitaly.wool@konsulko.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: fix typo in init.c | expand |
On Sun, 30 May 2021 16:22:17 +0300 Vitaly Wool <vitaly.wool@konsulko.com> wrote: > Commit 010623568222 introduced a typo in "__initdata" spelling > which led to build breakage for XIP. Fix that. oops, nice catch! Sorry for that. > > Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676 This "Fixes" tag seems not correct.Should be Fixes: 010623568222 ("riscv: mm: init: Consolidate vars, functions") After this change, Reviewed-by: Jisheng Zhang <jszhang@kernel.org> > Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com> > --- > arch/riscv/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index ae32f78207f0..e7b136abf90c 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata; > #endif > > #ifdef CONFIG_XIP_KERNEL > -static uintptr_t xiprom __inidata; > +static uintptr_t xiprom __initdata; > static uintptr_t xiprom_sz __initdata; > #define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz))) > #define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom)))
On Mon, 31 May 2021 08:11:40 +0800 Jisheng Zhang <jszhang3@mail.ustc.edu.cn> wrote: > > > On Sun, 30 May 2021 16:22:17 +0300 > Vitaly Wool <vitaly.wool@konsulko.com> wrote: > > > Commit 010623568222 introduced a typo in "__initdata" spelling > > which led to build breakage for XIP. Fix that. > > oops, nice catch! Sorry for that. > > > > > Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676 > > This "Fixes" tag seems not correct.Should be > Fixes: 010623568222 ("riscv: mm: init: Consolidate vars, functions") Hi Vitaly, Could you plz send a v2 for this? Regards > > After this change, > Reviewed-by: Jisheng Zhang <jszhang@kernel.org> > > > Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com> > > --- > > arch/riscv/mm/init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index ae32f78207f0..e7b136abf90c 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata; > > #endif > > > > #ifdef CONFIG_XIP_KERNEL > > -static uintptr_t xiprom __inidata; > > +static uintptr_t xiprom __initdata; > > static uintptr_t xiprom_sz __initdata; > > #define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz))) > > #define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom))) > > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org >
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index ae32f78207f0..e7b136abf90c 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata; #endif #ifdef CONFIG_XIP_KERNEL -static uintptr_t xiprom __inidata; +static uintptr_t xiprom __initdata; static uintptr_t xiprom_sz __initdata; #define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz))) #define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom)))
Commit 010623568222 introduced a typo in "__initdata" spelling which led to build breakage for XIP. Fix that. Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676 Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com> --- arch/riscv/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)