| Message ID | 20211203050317.2102-2-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: mm: init clean up #ifdefs | expand |
On 12/3/21 06:03, Jisheng Zhang wrote: > The is_kdump_kernel() returns false for !CRASH_DUMP case, so we don't > need the #ifdef CONFIG_CRASH_DUMP for is_kdump_kernel() checking. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > arch/riscv/mm/init.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 3c0649dba4ff..745f26a3b02e 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -790,12 +790,10 @@ static void __init reserve_crashkernel(void) > * since it doesn't make much sense and we have limited memory > * resources. > */ > -#ifdef CONFIG_CRASH_DUMP > if (is_kdump_kernel()) { > pr_info("crashkernel: ignoring reservation request\n"); > return; > } > -#endif > > ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > &crash_size, &crash_base); Reviewed-by: Alexandre Ghiti <alex@ghiti.fr> Thanks, Alex
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 3c0649dba4ff..745f26a3b02e 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -790,12 +790,10 @@ static void __init reserve_crashkernel(void) * since it doesn't make much sense and we have limited memory * resources. */ -#ifdef CONFIG_CRASH_DUMP if (is_kdump_kernel()) { pr_info("crashkernel: ignoring reservation request\n"); return; } -#endif ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), &crash_size, &crash_base);
The is_kdump_kernel() returns false for !CRASH_DUMP case, so we don't need the #ifdef CONFIG_CRASH_DUMP for is_kdump_kernel() checking. Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- arch/riscv/mm/init.c | 2 -- 1 file changed, 2 deletions(-)