| Message ID | 20220516143204.2603-1-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] riscv: mm: init: make pt_ops_set_[early|late|fixmap] static | expand |
On Mon, May 16, 2022 at 7:41 AM Jisheng Zhang <jszhang@kernel.org> wrote: > > These three functions are only used in init.c, so make them static. > Fix W=1 warnings like below: > > arch/riscv/mm/init.c:721:13: warning: no previous prototype for function > 'pt_ops_set_early' [-Wmissing-prototypes] > void __init pt_ops_set_early(void) > ^ > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > Reviewed-by: Anup Patel <anup@brainfault.org> > --- > > since v1: > - collect Reviewed-by tag > - move out from the static key series as a separate patch > > arch/riscv/mm/init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 05ed641a1134..5f3f26dd9f21 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -849,7 +849,7 @@ static void __init create_fdt_early_page_table(pgd_t *pgdir, uintptr_t dtb_pa) > * MMU is not enabled, the page tables are allocated directly using > * early_pmd/pud/p4d and the address returned is the physical one. > */ > -void __init pt_ops_set_early(void) > +static void __init pt_ops_set_early(void) > { > pt_ops.alloc_pte = alloc_pte_early; > pt_ops.get_pte_virt = get_pte_virt_early; > @@ -871,7 +871,7 @@ void __init pt_ops_set_early(void) > * Note that this is called with MMU disabled, hence kernel_mapping_pa_to_va, > * but it will be used as described above. > */ > -void __init pt_ops_set_fixmap(void) > +static void __init pt_ops_set_fixmap(void) > { > pt_ops.alloc_pte = kernel_mapping_pa_to_va((uintptr_t)alloc_pte_fixmap); > pt_ops.get_pte_virt = kernel_mapping_pa_to_va((uintptr_t)get_pte_virt_fixmap); > @@ -889,7 +889,7 @@ void __init pt_ops_set_fixmap(void) > * MMU is enabled and page table setup is complete, so from now, we can use > * generic page allocation functions to setup page table. > */ > -void __init pt_ops_set_late(void) > +static void __init pt_ops_set_late(void) > { > pt_ops.alloc_pte = alloc_pte_late; > pt_ops.get_pte_virt = get_pte_virt_late; > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Reviewed-by: Atish Patra <atishp@rivosinc.com>
On Mon, 16 May 2022 07:32:04 PDT (-0700), jszhang@kernel.org wrote: > These three functions are only used in init.c, so make them static. > Fix W=1 warnings like below: > > arch/riscv/mm/init.c:721:13: warning: no previous prototype for function > 'pt_ops_set_early' [-Wmissing-prototypes] > void __init pt_ops_set_early(void) > ^ > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > Reviewed-by: Anup Patel <anup@brainfault.org> > --- > > since v1: > - collect Reviewed-by tag > - move out from the static key series as a separate patch > > arch/riscv/mm/init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 05ed641a1134..5f3f26dd9f21 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -849,7 +849,7 @@ static void __init create_fdt_early_page_table(pgd_t *pgdir, uintptr_t dtb_pa) > * MMU is not enabled, the page tables are allocated directly using > * early_pmd/pud/p4d and the address returned is the physical one. > */ > -void __init pt_ops_set_early(void) > +static void __init pt_ops_set_early(void) > { > pt_ops.alloc_pte = alloc_pte_early; > pt_ops.get_pte_virt = get_pte_virt_early; > @@ -871,7 +871,7 @@ void __init pt_ops_set_early(void) > * Note that this is called with MMU disabled, hence kernel_mapping_pa_to_va, > * but it will be used as described above. > */ > -void __init pt_ops_set_fixmap(void) > +static void __init pt_ops_set_fixmap(void) > { > pt_ops.alloc_pte = kernel_mapping_pa_to_va((uintptr_t)alloc_pte_fixmap); > pt_ops.get_pte_virt = kernel_mapping_pa_to_va((uintptr_t)get_pte_virt_fixmap); > @@ -889,7 +889,7 @@ void __init pt_ops_set_fixmap(void) > * MMU is enabled and page table setup is complete, so from now, we can use > * generic page allocation functions to setup page table. > */ > -void __init pt_ops_set_late(void) > +static void __init pt_ops_set_late(void) > { > pt_ops.alloc_pte = alloc_pte_late; > pt_ops.get_pte_virt = get_pte_virt_late; Thanks, this is on for-next.
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 05ed641a1134..5f3f26dd9f21 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -849,7 +849,7 @@ static void __init create_fdt_early_page_table(pgd_t *pgdir, uintptr_t dtb_pa) * MMU is not enabled, the page tables are allocated directly using * early_pmd/pud/p4d and the address returned is the physical one. */ -void __init pt_ops_set_early(void) +static void __init pt_ops_set_early(void) { pt_ops.alloc_pte = alloc_pte_early; pt_ops.get_pte_virt = get_pte_virt_early; @@ -871,7 +871,7 @@ void __init pt_ops_set_early(void) * Note that this is called with MMU disabled, hence kernel_mapping_pa_to_va, * but it will be used as described above. */ -void __init pt_ops_set_fixmap(void) +static void __init pt_ops_set_fixmap(void) { pt_ops.alloc_pte = kernel_mapping_pa_to_va((uintptr_t)alloc_pte_fixmap); pt_ops.get_pte_virt = kernel_mapping_pa_to_va((uintptr_t)get_pte_virt_fixmap); @@ -889,7 +889,7 @@ void __init pt_ops_set_fixmap(void) * MMU is enabled and page table setup is complete, so from now, we can use * generic page allocation functions to setup page table. */ -void __init pt_ops_set_late(void) +static void __init pt_ops_set_late(void) { pt_ops.alloc_pte = alloc_pte_late; pt_ops.get_pte_virt = get_pte_virt_late;
These three functions are only used in init.c, so make them static. Fix W=1 warnings like below: arch/riscv/mm/init.c:721:13: warning: no previous prototype for function 'pt_ops_set_early' [-Wmissing-prototypes] void __init pt_ops_set_early(void) ^ Signed-off-by: Jisheng Zhang <jszhang@kernel.org> Reviewed-by: Anup Patel <anup@brainfault.org> --- since v1: - collect Reviewed-by tag - move out from the static key series as a separate patch arch/riscv/mm/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)