| Message ID | 20220525081416.3306043-13-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arch_topology: Updates to add socket support and fix cluster ids | expand |
On 5/25/22 4:14 PM, Sudeep Holla wrote: > There is no point in looping through all the CPU's physical package > identifier to check if it is valid or not once a CPU which is outside > the topology(i.e. outlier CPU) is found. > > Let us just break out of the loop early in such case. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/base/arch_topology.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Gavin Shan <gshan@redhat.com> > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index f73a5e669e42..6ae450ca68bb 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -637,8 +637,10 @@ static int __init parse_dt_topology(void) > * only mark cores described in the DT as possible. > */ > for_each_possible_cpu(cpu) > - if (cpu_topology[cpu].package_id < 0) > + if (cpu_topology[cpu].package_id < 0) { > ret = -EINVAL; > + break; > + } > > out_map: > of_node_put(map); >
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index f73a5e669e42..6ae450ca68bb 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -637,8 +637,10 @@ static int __init parse_dt_topology(void) * only mark cores described in the DT as possible. */ for_each_possible_cpu(cpu) - if (cpu_topology[cpu].package_id < 0) + if (cpu_topology[cpu].package_id < 0) { ret = -EINVAL; + break; + } out_map: of_node_put(map);
There is no point in looping through all the CPU's physical package identifier to check if it is valid or not once a CPU which is outside the topology(i.e. outlier CPU) is found. Let us just break out of the loop early in such case. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/base/arch_topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)