| Message ID | 20220714080235.3853374-1-conor.dooley@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] riscv: ensure cpu_ops_sbi is declared | expand |
On 14/07/2022 09:02, Conor Dooley wrote: > Sparse complains that cpu_ops_sbi is used undeclared: > arch/riscv/kernel/cpu_ops_sbi.c:17:29: warning: symbol 'cpu_ops_sbi' was not declared. Should it be static? > > Fix the warning by adding cpu_ops_sbi to cpu_ops_sbi.h & including that > where used. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Bump for this and the following other sparse fixes: https://lore.kernel.org/linux-riscv/20220714071811.187491-1-ben.dooks@sifive.com/ https://lore.kernel.org/linux-riscv/20220713220645.105138-1-ben.dooks@sifive.com/ https://lore.kernel.org/linux-riscv/20220713215306.94675-1-ben.dooks@sifive.com/ Thanks, Conor. > --- > > A trailing > broke the CC list, resending as v2 with just the CC > list fixed. > > arch/riscv/include/asm/cpu_ops_sbi.h | 2 ++ > arch/riscv/kernel/cpu_ops.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/arch/riscv/include/asm/cpu_ops_sbi.h b/arch/riscv/include/asm/cpu_ops_sbi.h > index 56e4b76d09ff..d6e4665b3195 100644 > --- a/arch/riscv/include/asm/cpu_ops_sbi.h > +++ b/arch/riscv/include/asm/cpu_ops_sbi.h > @@ -10,6 +10,8 @@ > #include <linux/sched.h> > #include <linux/threads.h> > > +extern const struct cpu_operations cpu_ops_sbi; > + > /** > * struct sbi_hart_boot_data - Hart specific boot used during booting and > * cpu hotplug. > diff --git a/arch/riscv/kernel/cpu_ops.c b/arch/riscv/kernel/cpu_ops.c > index 170d07e57721..916b71f5dfb9 100644 > --- a/arch/riscv/kernel/cpu_ops.c > +++ b/arch/riscv/kernel/cpu_ops.c > @@ -9,6 +9,7 @@ > #include <linux/string.h> > #include <linux/sched.h> > #include <asm/cpu_ops.h> > +#include <asm/cpu_ops_sbi.h> > #include <asm/sbi.h> > #include <asm/smp.h> >
diff --git a/arch/riscv/include/asm/cpu_ops_sbi.h b/arch/riscv/include/asm/cpu_ops_sbi.h index 56e4b76d09ff..d6e4665b3195 100644 --- a/arch/riscv/include/asm/cpu_ops_sbi.h +++ b/arch/riscv/include/asm/cpu_ops_sbi.h @@ -10,6 +10,8 @@ #include <linux/sched.h> #include <linux/threads.h> +extern const struct cpu_operations cpu_ops_sbi; + /** * struct sbi_hart_boot_data - Hart specific boot used during booting and * cpu hotplug. diff --git a/arch/riscv/kernel/cpu_ops.c b/arch/riscv/kernel/cpu_ops.c index 170d07e57721..916b71f5dfb9 100644 --- a/arch/riscv/kernel/cpu_ops.c +++ b/arch/riscv/kernel/cpu_ops.c @@ -9,6 +9,7 @@ #include <linux/string.h> #include <linux/sched.h> #include <asm/cpu_ops.h> +#include <asm/cpu_ops_sbi.h> #include <asm/sbi.h> #include <asm/smp.h>
Sparse complains that cpu_ops_sbi is used undeclared: arch/riscv/kernel/cpu_ops_sbi.c:17:29: warning: symbol 'cpu_ops_sbi' was not declared. Should it be static? Fix the warning by adding cpu_ops_sbi to cpu_ops_sbi.h & including that where used. Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- A trailing > broke the CC list, resending as v2 with just the CC list fixed. arch/riscv/include/asm/cpu_ops_sbi.h | 2 ++ arch/riscv/kernel/cpu_ops.c | 1 + 2 files changed, 3 insertions(+)