| Message ID | 20220909023625.149651-1-lihuafei1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,v2,1/2] riscv: ftrace: Fix the comments about the number of ftrace instruction | expand |
diff --git a/arch/riscv/kernel/ftrace.c b/arch/riscv/kernel/ftrace.c index 2086f6585773..552088e9acc4 100644 --- a/arch/riscv/kernel/ftrace.c +++ b/arch/riscv/kernel/ftrace.c @@ -71,8 +71,8 @@ static int __ftrace_modify_call(unsigned long hook_pos, unsigned long target, } /* - * Put 5 instructions with 16 bytes at the front of function within - * patchable function entry nops' area. + * Put 16 bytes at the front of the function within the patchable function + * entry nops' area. * * 0: REG_S ra, -SZREG(sp) * 1: auipc ra, 0x?
When DYNAMIC_FTRACE is enabled, we put 8 16-bit instructions in front of the function for ftrace use, not 5. Fixes: afc76b8b8011 ("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT") Suggested-by: Guo Ren <guoren@kernel.org> Signed-off-by: Li Huafei <lihuafei1@huawei.com> --- v1: https://lore.kernel.org/lkml/20220426015751.88582-1-lihuafei1@huawei.com/ v2: https://lore.kernel.org/lkml/20220819025522.154189-1-lihuafei1@huawei.com/ v2 RESEND: - Rebase onto v6.0-rc4. Changlog in v1 -> v2: - Add the fix tag. - Delete the expression "4 instructions". arch/riscv/kernel/ftrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)