[13/20] reset: remove MODULE_LICENSE in non-modules

Commit Message

Nick Alcock Feb. 28, 2023, 1:02 p.m. UTC

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[e-mail]>
Suggested-by: Luis Chamberlain <[e-mail]>
Cc: Luis Chamberlain <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: Hitomi Hasegawa <[e-mail]>
Cc: Conor Dooley <[e-mail]>
Cc: Daire McNamara <[e-mail]>
Cc: Philipp Zabel <[e-mail]>
Cc: [e-mail]
---
 drivers/reset/reset-mpfs.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Conor Dooley Feb. 28, 2023, 7:17 p.m. UTC | #1

On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <[e-mail]>
> Suggested-by: Luis Chamberlain <[e-mail]>
> Cc: Luis Chamberlain <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: Hitomi Hasegawa <[e-mail]>
> Cc: Conor Dooley <[e-mail]>
> Cc: Daire McNamara <[e-mail]>
> Cc: Philipp Zabel <[e-mail]>
> Cc: [e-mail]
> ---
>  drivers/reset/reset-mpfs.c | 1 -

I assume your script just got confused here w/ $subject, since there's
only a change for this specific file.
Reviewed-by: Conor Dooley <[e-mail]>

Thanks,
Conor.

Nick Alcock Feb. 28, 2023, 7:26 p.m. UTC | #2

[dropped non-lists to defend innocent ears from my flaming pedantry]

On 28 Feb 2023, Conor Dooley stated:

> On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>> 
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>> 
>> Signed-off-by: Nick Alcock <[e-mail]>
>> Suggested-by: Luis Chamberlain <[e-mail]>
>> Cc: Luis Chamberlain <[e-mail]>
>> Cc: [e-mail]
>> Cc: [e-mail]
>> Cc: Hitomi Hasegawa <[e-mail]>
>> Cc: Conor Dooley <[e-mail]>
>> Cc: Daire McNamara <[e-mail]>
>> Cc: Philipp Zabel <[e-mail]>
>> Cc: [e-mail]
>> ---
>>  drivers/reset/reset-mpfs.c | 1 -
>
> I assume your script just got confused here w/ $subject, since there's
> only a change for this specific file.

This file has had no commits since you wrote it last year, and the
subject for that commit was

    reset: add polarfire soc reset support

so, er, yes, the script used 'reset:' as a prefix, mimicking the
existing commit. I'm not sure what else it could have done.

(Regarding the rest of the subject line, I suppose I could have arranged
to detect single-file commits and turned the subject into 'in this
non-module'? But there comes a time when even I think that maybe I might
be overdesigning something, and automated grammatical adjustments to the
subject line was that point!)

Conor Dooley Feb. 28, 2023, 7:53 p.m. UTC | #3

On Tue, Feb 28, 2023 at 07:26:55PM +0000, Nick Alcock wrote:
> [dropped non-lists to defend innocent ears from my flaming pedantry]
> 
> On 28 Feb 2023, Conor Dooley stated:
> 
> > On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> >> are used to identify modules. As a consequence, uses of the macro
> >> in non-modules will cause modprobe to misidentify their containing
> >> object file as a module when it is not (false positives), and modprobe
> >> might succeed rather than failing with a suitable error message.
> >> 
> >> So remove it in the files in this commit, none of which can be built as
> >> modules.
> >> 
> >> Signed-off-by: Nick Alcock <[e-mail]>
> >> Suggested-by: Luis Chamberlain <[e-mail]>
> >> Cc: Luis Chamberlain <[e-mail]>
> >> Cc: [e-mail]
> >> Cc: [e-mail]
> >> Cc: Hitomi Hasegawa <[e-mail]>
> >> Cc: Conor Dooley <[e-mail]>
> >> Cc: Daire McNamara <[e-mail]>
> >> Cc: Philipp Zabel <[e-mail]>
> >> Cc: [e-mail]
> >> ---
> >>  drivers/reset/reset-mpfs.c | 1 -
> >
> > I assume your script just got confused here w/ $subject, since there's
> > only a change for this specific file.
> 
> This file has had no commits since you wrote it last year, and the
> subject for that commit was
> 
>     reset: add polarfire soc reset support
> 
> so, er, yes, the script used 'reset:' as a prefix, mimicking the
> existing commit. I'm not sure what else it could have done.

Oh ye, silly me - I didn't think of that. I guess that's a common
pattern for commits adding a driver, as the "mpfs:" doesn't really make
sense until the driver is in-tree.
I'm not too sure what you could have done either, but I'm not
complaining, or requesting that something be changed here.

> (Regarding the rest of the subject line, I suppose I could have arranged
> to detect single-file commits and turned the subject into 'in this
> non-module'? But there comes a time when even I think that maybe I might
> be overdesigning something, and automated grammatical adjustments to the
> subject line was that point!)

Yeah, I think it's not worth doing anything about really...

Patch

diff --git a/drivers/reset/reset-mpfs.c b/drivers/reset/reset-mpfs.c
index e003e50590ec5..e71ab73092abd 100644
--- a/drivers/reset/reset-mpfs.c
+++ b/drivers/reset/reset-mpfs.c
@@ -153,5 +153,4 @@  module_auxiliary_driver(mpfs_reset_driver);
 
 MODULE_DESCRIPTION("Microchip PolarFire SoC Reset Driver");
 MODULE_AUTHOR("Conor Dooley <[e-mail]>");
-MODULE_LICENSE("GPL");
 MODULE_IMPORT_NS(MCHP_CLK_MPFS);