From patchwork Fri Mar 3 18:54:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159418 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 736D7C7EE2F for ; Fri, 3 Mar 2023 18:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zjzMNyFtjwKj+Sjdq9tAb75VUiPkLcMNusou++0kdmo=; b=vy4l9+W3UHSx6q LmA41faaLNVitZ8HkxGZngSyweQ4fl0hw49VzerQfEK8bKC28YeTJPxDuam97gUibQ7g1VT5uFchb Yp98JZceVzbLWgNMtpejyc9fJkw9KBZugVrvrnoHpOgVBzqllc5e81AQKQZJPPzBip5uMUhmz+mvX SsV0VLzYMRHOu+vh6B8zeqpqFyI5k6wDYVfaaqgcDUZsRbKZUvlnk1GZj6ZErnu6paKAfSYH6lKiL adBu0xP638ZdbQxfrCE9SnreNgV+jEa4ImujZkuGwYQo1+rzZ44YCq/ArEtwmlANaZwz3Xy/g2jPY rYNvs6q7Gkdi77hBcluQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAbX-007EOe-FS; Fri, 03 Mar 2023 18:58:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYf-007Cra-Rk for linux-riscv@lists.infradead.org; Fri, 03 Mar 2023 18:55:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYAYc-0006Ut-0F; Fri, 03 Mar 2023 19:55:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYAYa-001cVb-Sa; Fri, 03 Mar 2023 19:55:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYAYX-001ukn-76; Fri, 03 Mar 2023 19:55:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Palmer Dabbelt , Paul Walmsley Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 20/30] pwm: sifive: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 19:54:35 +0100 Message-Id: <20230303185445.2112695-21-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1733; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qMafb/hg7zFL02UFPEZV5gEG/vwYDPL5U0C7Ndq8GYw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAkJHsO7KnsALZ/5vaBUA+pXb5ayVMdj/m7kLY d/YanFOSx2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJCRwAKCRDB/BR4rcrs CU77B/9hdSMSFrKcMQw1LLDMm/Gvonnt6aLpyqaNJ3xz/Mj5q+af9TlcBIrHQlsA/lSKSf1A19j s1TkrM6/60gi1ZGeXqbe4wXel+u9YZGizM/4rF2gkxnHSknoV27JCv6RrYiAdkanv+xqYqYI9wV 1KJghKXYKvaVBBhYatJ7A9ej5hUln0gHow3bzpBNDIFdp4ZrxPzuSFyGptsv4OmdNJrHLA2a7kN pSnmWu60RBFLi4m9oc1W8RDzk1w6pd37vLwR4M5Uh+a/CQY4W3Ux/WJrQK/DS40vj4WkA9oOgil 1xtSg+enYsEFQ7DUWffooVu0bcuLUJfVOHVSsFdV9n585p5+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-riscv@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_105509_976784_2257A90E X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-sifive.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 393a4b97fc19..5b0574f635f6 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -313,7 +313,7 @@ static int pwm_sifive_probe(struct platform_device *pdev) return ret; } -static int pwm_sifive_remove(struct platform_device *dev) +static void pwm_sifive_remove(struct platform_device *dev) { struct pwm_sifive_ddata *ddata = platform_get_drvdata(dev); struct pwm_device *pwm; @@ -329,8 +329,6 @@ static int pwm_sifive_remove(struct platform_device *dev) } clk_unprepare(ddata->clk); - - return 0; } static const struct of_device_id pwm_sifive_of_match[] = { @@ -341,7 +339,7 @@ MODULE_DEVICE_TABLE(of, pwm_sifive_of_match); static struct platform_driver pwm_sifive_driver = { .probe = pwm_sifive_probe, - .remove = pwm_sifive_remove, + .remove_new = pwm_sifive_remove, .driver = { .name = "pwm-sifive", .of_match_table = pwm_sifive_of_match,