| Message ID | 20230307024646.10216-3-william.qiu@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | StarFive's SDIO/eMMC driver support | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/tree_selection | fail | Failed to apply to next/pending-fixes or riscv/for-next |
On Tue, 7 Mar 2023 at 03:49, William Qiu <william.qiu@starfivetech.com> wrote: > Add a incremental updates to fix a bug that prev_err is uninitialized. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > Reported-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> > --- > drivers/mmc/host/dw_mmc-starfive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-starfive.c b/drivers/mmc/host/dw_mmc-starfive.c > index 40f5969b07a6..dab1508bf83c 100644 > --- a/drivers/mmc/host/dw_mmc-starfive.c > +++ b/drivers/mmc/host/dw_mmc-starfive.c > @@ -51,7 +51,7 @@ static int dw_mci_starfive_execute_tuning(struct dw_mci_slot *slot, > struct dw_mci *host = slot->host; > struct starfive_priv *priv = host->priv; > int rise_point = -1, fall_point = -1; > - int err, prev_err; > + int err, prev_err = 0; > int i; > bool found = 0; > u32 regval; > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Tue, 7 Mar 2023 at 03:46, William Qiu <william.qiu@starfivetech.com> wrote: > > Add a incremental updates to fix a bug that prev_err is uninitialized. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > Reported-by: Dan Carpenter <error27@gmail.com> I took the liberty of updating the commit message a bit, to try to further clarify things. Moreover, future wise, let's use the prefix, "mmc: dw_mmc-starfive" for the commit message header, to be consistent with the other dw_mmc drivers. So, applied for fixes and by adding a fixes tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/dw_mmc-starfive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-starfive.c b/drivers/mmc/host/dw_mmc-starfive.c > index 40f5969b07a6..dab1508bf83c 100644 > --- a/drivers/mmc/host/dw_mmc-starfive.c > +++ b/drivers/mmc/host/dw_mmc-starfive.c > @@ -51,7 +51,7 @@ static int dw_mci_starfive_execute_tuning(struct dw_mci_slot *slot, > struct dw_mci *host = slot->host; > struct starfive_priv *priv = host->priv; > int rise_point = -1, fall_point = -1; > - int err, prev_err; > + int err, prev_err = 0; > int i; > bool found = 0; > u32 regval; > -- > 2.34.1 >
diff --git a/drivers/mmc/host/dw_mmc-starfive.c b/drivers/mmc/host/dw_mmc-starfive.c index 40f5969b07a6..dab1508bf83c 100644 --- a/drivers/mmc/host/dw_mmc-starfive.c +++ b/drivers/mmc/host/dw_mmc-starfive.c @@ -51,7 +51,7 @@ static int dw_mci_starfive_execute_tuning(struct dw_mci_slot *slot, struct dw_mci *host = slot->host; struct starfive_priv *priv = host->priv; int rise_point = -1, fall_point = -1; - int err, prev_err; + int err, prev_err = 0; int i; bool found = 0; u32 regval;
Add a incremental updates to fix a bug that prev_err is uninitialized. Signed-off-by: William Qiu <william.qiu@starfivetech.com> Reported-by: Dan Carpenter <error27@gmail.com> --- drivers/mmc/host/dw_mmc-starfive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)