| Message ID | 20230311090733.56918-4-hal.feng@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Basic clock, reset & device tree support for StarFive JH7110 RISC-V SoC | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 1 and now 1 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | fail | Failed to build the tree with this patch. |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | fail | Failed to build the tree with this patch. |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 728 and now 728 |
| conchuod/build_rv32_defconfig | fail | Build failed |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | warning | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Sat, Mar 11, 2023 at 05:07:15PM +0800, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > Rename clk-starfive-jh7100.h to clk-starfive-jh71x0.h for making > the code to be common. > > Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > --- > .../clk/starfive/{clk-starfive-jh7100.h => clk-starfive-jh71x0.h} | 0 So this patch has broken the build :( https://patchwork.kernel.org/project/linux-riscv/patch/20230311090733.56918-4-hal.feng@starfivetech.com/ I would imagine it is because you can't rename the header without also changing the users of the header. Cheers, Conor.
On Sun, 12 Mar 2023 14:00:23 +0000, Conor Dooley wrote: > On Sat, Mar 11, 2023 at 05:07:15PM +0800, Hal Feng wrote: >> From: Emil Renner Berthing <kernel@esmil.dk> >> >> Rename clk-starfive-jh7100.h to clk-starfive-jh71x0.h for making >> the code to be common. >> >> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> >> --- >> .../clk/starfive/{clk-starfive-jh7100.h => clk-starfive-jh71x0.h} | 0 > > So this patch has broken the build :( > https://patchwork.kernel.org/project/linux-riscv/patch/20230311090733.56918-4-hal.feng@starfivetech.com/ > > I would imagine it is because you can't rename the header without also > changing the users of the header. Will fix it later. Thanks for pointing it out. Best regards, Hal
diff --git a/drivers/clk/starfive/clk-starfive-jh7100.h b/drivers/clk/starfive/clk-starfive-jh71x0.h
similarity index 100%
rename from drivers/clk/starfive/clk-starfive-jh7100.h
rename to drivers/clk/starfive/clk-starfive-jh71x0.h