diff mbox series

[v2,3/4] vmlinux.lds.h: use correct .init.data.* section name

Message ID 20230523165502.2592-4-jszhang@kernel.org (mailing list archive)
State Changes Requested
Headers show
Series riscv: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION | expand

Checks

Context Check Description
conchuod/tree_selection fail Failed to apply to next/pending-fixes, riscv/for-next or riscv/master

Commit Message

Jisheng Zhang May 23, 2023, 4:55 p.m. UTC
If building with -fdata-sections on riscv, LD_ORPHAN_WARN will warn
similar as below:

riscv64-linux-gnu-ld: warning: orphan section `.init.data.efi_loglevel'
from `./drivers/firmware/efi/libstub/printk.stub.o' being placed in
section `.init.data.efi_loglevel'

I believe this is caused by a a typo:
init.data.* should be .init.data.*

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 include/asm-generic/vmlinux.lds.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kefeng Wang May 24, 2023, 11:02 a.m. UTC | #1
On 2023/5/24 0:55, Jisheng Zhang wrote:
> If building with -fdata-sections on riscv, LD_ORPHAN_WARN will warn
> similar as below:
> 
> riscv64-linux-gnu-ld: warning: orphan section `.init.data.efi_loglevel'
> from `./drivers/firmware/efi/libstub/printk.stub.o' being placed in
> section `.init.data.efi_loglevel'
> 
> I believe this is caused by a a typo:
> init.data.* should be .init.data.*

Fixes tag?

266ff2a8f51f kbuild: Fix asm-generic/vmlinux.lds.h for 
LD_DEAD_CODE_DATA_ELIMINATION

Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>


> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>   include/asm-generic/vmlinux.lds.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index d1f57e4868ed..371026ca7221 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -688,7 +688,7 @@
>   /* init and exit section handling */
>   #define INIT_DATA							\
>   	KEEP(*(SORT(___kentry+*)))					\
> -	*(.init.data init.data.*)					\
> +	*(.init.data .init.data.*)					\
>   	MEM_DISCARD(init.data*)						\
>   	KERNEL_CTORS()							\
>   	MCOUNT_REC()							\
diff mbox series

Patch

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index d1f57e4868ed..371026ca7221 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -688,7 +688,7 @@ 
 /* init and exit section handling */
 #define INIT_DATA							\
 	KEEP(*(SORT(___kentry+*)))					\
-	*(.init.data init.data.*)					\
+	*(.init.data .init.data.*)					\
 	MEM_DISCARD(init.data*)						\
 	KERNEL_CTORS()							\
 	MCOUNT_REC()							\