diff mbox series

[2/2] selftests/proc: Do not build x86-64 tests on non-x86-64 builds

Message ID 20230629162301.1234157-3-bjorn@kernel.org (mailing list archive)
State Handled Elsewhere
Headers show
Series Two cross-compilation kselftest fixes | expand

Checks

Context Check Description
conchuod/cover_letter success Series has a cover letter
conchuod/tree_selection success Guessed tree name to be for-next at HEAD 488833ccdcac
conchuod/fixes_present success Fixes tag not required for -next series
conchuod/maintainers_pattern success MAINTAINERS pattern errors before the patch: 6 and now 6
conchuod/verify_signedoff success Signed-off-by tag matches author and committer
conchuod/kdoc success Errors and warnings before: 0 this patch: 0
conchuod/build_rv64_clang_allmodconfig success Errors and warnings before: 8 this patch: 8
conchuod/module_param success Was 0 now: 0
conchuod/build_rv64_gcc_allmodconfig success Errors and warnings before: 8 this patch: 8
conchuod/build_rv32_defconfig success Build OK
conchuod/dtb_warn_rv64 success Errors and warnings before: 20 this patch: 20
conchuod/header_inline success No static functions without inline keyword in header files
conchuod/checkpatch success total: 0 errors, 0 warnings, 0 checks, 11 lines checked
conchuod/build_rv64_nommu_k210_defconfig success Build OK
conchuod/verify_fixes success No Fixes tag
conchuod/build_rv64_nommu_virt_defconfig success Build OK

Commit Message

Björn Töpel June 29, 2023, 4:23 p.m. UTC 
From: Björn Töpel <bjorn@rivosinc.com>

The proc-empty-vm test is x86-64 only. Remove that test from
non-x86-64 builds.

Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
---
 tools/testing/selftests/proc/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Alexey Dobriyan June 29, 2023, 7:42 p.m. UTC | #1 
On Thu, Jun 29, 2023 at 06:23:00PM +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@rivosinc.com>
> 
> The proc-empty-vm test is x86-64 only. Remove that test from
> non-x86-64 builds.
> 
> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>

What's the address space size on risc-v?

> --- a/tools/testing/selftests/proc/Makefile
> +++ b/tools/testing/selftests/proc/Makefile
> @@ -8,7 +8,11 @@ TEST_GEN_PROGS += fd-001-lookup
>  TEST_GEN_PROGS += fd-002-posix-eq
>  TEST_GEN_PROGS += fd-003-kthread
>  TEST_GEN_PROGS += proc-loadavg-001
> +
> +ifneq (,$(filter $(ARCH),x86_64))
>  TEST_GEN_PROGS += proc-empty-vm
> +endif
> +
>  TEST_GEN_PROGS += proc-pid-vm
>  TEST_GEN_PROGS += proc-self-map-files-001
>  TEST_GEN_PROGS += proc-self-map-files-002
Björn Töpel June 30, 2023, 10:27 a.m. UTC | #2 
Alexey Dobriyan <adobriyan@gmail.com> writes:

> On Thu, Jun 29, 2023 at 06:23:00PM +0200, Björn Töpel wrote:
>> From: Björn Töpel <bjorn@rivosinc.com>
>> 
>> The proc-empty-vm test is x86-64 only. Remove that test from
>> non-x86-64 builds.
>> 
>> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
>
> What's the address space size on risc-v?

Different sizes are supported, 39b, 48b, and 57b:
Documentation/riscv/vm-layout.rst

Did you have anything particular in mind?
diff mbox series

Patch

diff --git a/tools/testing/selftests/proc/Makefile b/tools/testing/selftests/proc/Makefile
index cd95369254c0..35e765f79b6d 100644
--- a/tools/testing/selftests/proc/Makefile
+++ b/tools/testing/selftests/proc/Makefile
@@ -8,7 +8,11 @@  TEST_GEN_PROGS += fd-001-lookup
 TEST_GEN_PROGS += fd-002-posix-eq
 TEST_GEN_PROGS += fd-003-kthread
 TEST_GEN_PROGS += proc-loadavg-001
+
+ifneq (,$(filter $(ARCH),x86_64))
 TEST_GEN_PROGS += proc-empty-vm
+endif
+
 TEST_GEN_PROGS += proc-pid-vm
 TEST_GEN_PROGS += proc-self-map-files-001
 TEST_GEN_PROGS += proc-self-map-files-002