| Message ID | 20230716001506.3506041-2-guoren@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d0be64154cf24660a947b84340e8d5bb1af855a |
| Headers | show |
| Series | riscv: stack: Fixup independent softirq/irq stack for CONFIG_FRAME_POINTER=n | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be fixes at HEAD ab2dbc7acced |
| conchuod/fixes_present | success | Fixes tag present in non-next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 4 and now 4 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | warning | WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | Fixes tag looks correct |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
Le sunnuntaina 16. heinäkuuta 2023, 3.15.05 EEST guoren@kernel.org a écrit : > From: Guo Ren <guoren@linux.alibaba.com> > > The independent irq stack uses s0 to save & restore sp, but s0 would be > corrupted when CONFIG_FRAME_POINTER=n. So add s0 in the clobber list to > fix the problem. Isn't it *always* corrupted? Shouldn't the clobber be always there? Am I guessing that the compiler whine that you can't mark the frame pointer as clobbered? If so, it would be worth mentioning in the commit log, IMO. > Fixes: 163e76cc6ef4 ("riscv: stack: Support HAVE_IRQ_EXIT_ON_IRQ_STACK") > Cc: stable@vger.kernel.org > Reported-by: Zhangjin Wu <falcon@tinylab.org> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > --- > arch/riscv/kernel/traps.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index f910dfccbf5d..927347a19847 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -372,6 +372,9 @@ asmlinkage void noinstr do_irq(struct pt_regs *regs) > > : [sp] "r" (sp), [regs] "r" (regs) > : "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7", > > "t0", "t1", "t2", "t3", "t4", "t5", "t6", > +#ifndef CONFIG_FRAME_POINTER > + "s0", > +#endif > "memory"); > } else > #endif
diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c index f910dfccbf5d..927347a19847 100644 --- a/arch/riscv/kernel/traps.c +++ b/arch/riscv/kernel/traps.c @@ -372,6 +372,9 @@ asmlinkage void noinstr do_irq(struct pt_regs *regs) : [sp] "r" (sp), [regs] "r" (regs) : "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7", "t0", "t1", "t2", "t3", "t4", "t5", "t6", +#ifndef CONFIG_FRAME_POINTER + "s0", +#endif "memory"); } else #endif