| Message ID | 20230827101128.70931-9-bhe@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | kdump: use generic functions to simplify crashkernel reservation in architectures | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 9f944d2e0ab3 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 4 and now 4 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 46 this patch: 46 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 308 this patch: 308 |
| conchuod/build_rv32_defconfig | fail | Build failed |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 12 this patch: 12 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 34 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | fail | Build failed |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | fail | Build failed |
Hi Baoquan, On 2023-08-27 5:11 AM, Baoquan He wrote: > So far, nobody calls functions parse_crashkernel_high() and > parse_crashkernel_high(), remove both of them. minor typo: should be parse_crashkernel_low(). Regards, Samuel > Signed-off-by: Baoquan He <bhe@redhat.com> > --- > include/linux/crash_core.h | 4 ---- > kernel/crash_core.c | 18 ------------------ > 2 files changed, 22 deletions(-) > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > index 2f732493e922..0c512a80a768 100644 > --- a/include/linux/crash_core.h > +++ b/include/linux/crash_core.h > @@ -80,10 +80,6 @@ void final_note(Elf_Word *buf); > int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > unsigned long long *crash_size, unsigned long long *crash_base, > unsigned long long *low_size, bool *high); > -int parse_crashkernel_high(char *cmdline, unsigned long long system_ram, > - unsigned long long *crash_size, unsigned long long *crash_base); > -int parse_crashkernel_low(char *cmdline, unsigned long long system_ram, > - unsigned long long *crash_size, unsigned long long *crash_base); > > #ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > #ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 6bc00cc390b5..61a8ea3b23a2 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -323,24 +323,6 @@ int __init parse_crashkernel(char *cmdline, > return 0; > } > > -int __init parse_crashkernel_high(char *cmdline, > - unsigned long long system_ram, > - unsigned long long *crash_size, > - unsigned long long *crash_base) > -{ > - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, > - suffix_tbl[SUFFIX_HIGH]); > -} > - > -int __init parse_crashkernel_low(char *cmdline, > - unsigned long long system_ram, > - unsigned long long *crash_size, > - unsigned long long *crash_base) > -{ > - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, > - suffix_tbl[SUFFIX_LOW]); > -} > - > /* > * Add a dummy early_param handler to mark crashkernel= as a known command line > * parameter and suppress incorrect warnings in init/main.c.
On 08/28/23 at 12:26am, Samuel Holland wrote: > Hi Baoquan, > > On 2023-08-27 5:11 AM, Baoquan He wrote: > > So far, nobody calls functions parse_crashkernel_high() and > > parse_crashkernel_high(), remove both of them. > > minor typo: should be parse_crashkernel_low(). Good catch, will update. Thanks. > > > Signed-off-by: Baoquan He <bhe@redhat.com> > > --- > > include/linux/crash_core.h | 4 ---- > > kernel/crash_core.c | 18 ------------------ > > 2 files changed, 22 deletions(-) > > > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > > index 2f732493e922..0c512a80a768 100644 > > --- a/include/linux/crash_core.h > > +++ b/include/linux/crash_core.h > > @@ -80,10 +80,6 @@ void final_note(Elf_Word *buf); > > int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > > unsigned long long *crash_size, unsigned long long *crash_base, > > unsigned long long *low_size, bool *high); > > -int parse_crashkernel_high(char *cmdline, unsigned long long system_ram, > > - unsigned long long *crash_size, unsigned long long *crash_base); > > -int parse_crashkernel_low(char *cmdline, unsigned long long system_ram, > > - unsigned long long *crash_size, unsigned long long *crash_base); > > > > #ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > > #ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > index 6bc00cc390b5..61a8ea3b23a2 100644 > > --- a/kernel/crash_core.c > > +++ b/kernel/crash_core.c > > @@ -323,24 +323,6 @@ int __init parse_crashkernel(char *cmdline, > > return 0; > > } > > > > -int __init parse_crashkernel_high(char *cmdline, > > - unsigned long long system_ram, > > - unsigned long long *crash_size, > > - unsigned long long *crash_base) > > -{ > > - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, > > - suffix_tbl[SUFFIX_HIGH]); > > -} > > - > > -int __init parse_crashkernel_low(char *cmdline, > > - unsigned long long system_ram, > > - unsigned long long *crash_size, > > - unsigned long long *crash_base) > > -{ > > - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, > > - suffix_tbl[SUFFIX_LOW]); > > -} > > - > > /* > > * Add a dummy early_param handler to mark crashkernel= as a known command line > > * parameter and suppress incorrect warnings in init/main.c. >
diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h index 2f732493e922..0c512a80a768 100644 --- a/include/linux/crash_core.h +++ b/include/linux/crash_core.h @@ -80,10 +80,6 @@ void final_note(Elf_Word *buf); int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, unsigned long long *crash_size, unsigned long long *crash_base, unsigned long long *low_size, bool *high); -int parse_crashkernel_high(char *cmdline, unsigned long long system_ram, - unsigned long long *crash_size, unsigned long long *crash_base); -int parse_crashkernel_low(char *cmdline, unsigned long long system_ram, - unsigned long long *crash_size, unsigned long long *crash_base); #ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION #ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 6bc00cc390b5..61a8ea3b23a2 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -323,24 +323,6 @@ int __init parse_crashkernel(char *cmdline, return 0; } -int __init parse_crashkernel_high(char *cmdline, - unsigned long long system_ram, - unsigned long long *crash_size, - unsigned long long *crash_base) -{ - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, - suffix_tbl[SUFFIX_HIGH]); -} - -int __init parse_crashkernel_low(char *cmdline, - unsigned long long system_ram, - unsigned long long *crash_size, - unsigned long long *crash_base) -{ - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, - suffix_tbl[SUFFIX_LOW]); -} - /* * Add a dummy early_param handler to mark crashkernel= as a known command line * parameter and suppress incorrect warnings in init/main.c.
So far, nobody calls functions parse_crashkernel_high() and parse_crashkernel_high(), remove both of them. Signed-off-by: Baoquan He <bhe@redhat.com> --- include/linux/crash_core.h | 4 ---- kernel/crash_core.c | 18 ------------------ 2 files changed, 22 deletions(-)