| Message ID | 20231027113525.2227513-1-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | riscv: defconfig: Regenerate defconfig | expand |
On 27/10/2023 13:35, Chanho Park wrote: > Run 'make defconfig savedefconfig' and copy the defconfig file to > arch/riscv/configs/defconfig. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > arch/riscv/configs/defconfig | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > index ab86ec3b9eab..83fa02611284 100644 > --- a/arch/riscv/configs/defconfig > +++ b/arch/riscv/configs/defconfig > @@ -27,15 +27,12 @@ CONFIG_EXPERT=y > CONFIG_PROFILING=y > CONFIG_SOC_MICROCHIP_POLARFIRE=y > CONFIG_ARCH_RENESAS=y > -CONFIG_ARCH_THEAD=y > CONFIG_SOC_SIFIVE=y > CONFIG_SOC_STARFIVE=y > CONFIG_ARCH_SUNXI=y > +CONFIG_ARCH_THEAD=y > CONFIG_SOC_VIRT=y > CONFIG_SMP=y > -CONFIG_HOTPLUG_CPU=y > -CONFIG_PM=y User-selectible options should not be removed from defconfig via savedefconfig. Please do not run blind savedefconfig, unless you are okay with actually loosing these options. We discussed this multiple times... https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/ and some other threads Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Sunday, October 29, 2023 4:50 PM > To: Chanho Park <chanho61.park@samsung.com>; Paul Walmsley > <paul.walmsley@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>; Albert Ou > <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > Subject: Re: [PATCH] riscv: defconfig: Regenerate defconfig > > On 27/10/2023 13:35, Chanho Park wrote: > > Run 'make defconfig savedefconfig' and copy the defconfig file to > > arch/riscv/configs/defconfig. > > > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > > --- > > arch/riscv/configs/defconfig | 10 +--------- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > > index ab86ec3b9eab..83fa02611284 100644 > > --- a/arch/riscv/configs/defconfig > > +++ b/arch/riscv/configs/defconfig > > @@ -27,15 +27,12 @@ CONFIG_EXPERT=y > > CONFIG_PROFILING=y > > CONFIG_SOC_MICROCHIP_POLARFIRE=y > > CONFIG_ARCH_RENESAS=y > > -CONFIG_ARCH_THEAD=y > > CONFIG_SOC_SIFIVE=y > > CONFIG_SOC_STARFIVE=y > > CONFIG_ARCH_SUNXI=y > > +CONFIG_ARCH_THEAD=y > > CONFIG_SOC_VIRT=y > > CONFIG_SMP=y > > -CONFIG_HOTPLUG_CPU=y > > -CONFIG_PM=y > > User-selectible options should not be removed from defconfig via > savedefconfig. Please do not run blind savedefconfig, unless you are > okay with actually loosing these options. We discussed this multiple > times... > > https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/ > and some other threads > I see. When I run savedefconfig, I always checked .config changes between old and new to avoid such missing. I thought there were some things that needed to be fixed manually, which could lead to mistakes. Also, if you make a mess with a manual update, it makes the next update harder. Thanks for pointing that out and explaining the history :) Best Regards, Chanho Park
diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig index ab86ec3b9eab..83fa02611284 100644 --- a/arch/riscv/configs/defconfig +++ b/arch/riscv/configs/defconfig @@ -27,15 +27,12 @@ CONFIG_EXPERT=y CONFIG_PROFILING=y CONFIG_SOC_MICROCHIP_POLARFIRE=y CONFIG_ARCH_RENESAS=y -CONFIG_ARCH_THEAD=y CONFIG_SOC_SIFIVE=y CONFIG_SOC_STARFIVE=y CONFIG_ARCH_SUNXI=y +CONFIG_ARCH_THEAD=y CONFIG_SOC_VIRT=y CONFIG_SMP=y -CONFIG_HOTPLUG_CPU=y -CONFIG_PM=y -CONFIG_CPU_IDLE=y CONFIG_VIRTUALIZATION=y CONFIG_KVM=m CONFIG_ACPI=y @@ -43,12 +40,9 @@ CONFIG_JUMP_LABEL=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_SPARSEMEM_MANUAL=y -CONFIG_BLK_DEV_THROTTLING=y CONFIG_NET=y CONFIG_PACKET=y -CONFIG_UNIX=y CONFIG_XFRM_USER=m -CONFIG_INET=y CONFIG_IP_MULTICAST=y CONFIG_IP_ADVANCED_ROUTER=y CONFIG_IP_PNP=y @@ -151,7 +145,6 @@ CONFIG_DRM_NOUVEAU=m CONFIG_DRM_SUN4I=m CONFIG_DRM_VIRTIO_GPU=m CONFIG_FB=y -CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PLATFORM=y @@ -183,7 +176,6 @@ CONFIG_SUN50I_IOMMU=y CONFIG_RPMSG_CHAR=y CONFIG_RPMSG_CTRL=y CONFIG_RPMSG_VIRTIO=y -CONFIG_ARCH_R9A07G043=y CONFIG_PHY_SUN4I_USB=m CONFIG_LIBNVDIMM=y CONFIG_NVMEM_SUNXI_SID=y
Run 'make defconfig savedefconfig' and copy the defconfig file to arch/riscv/configs/defconfig. Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- arch/riscv/configs/defconfig | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)