| Message ID | 20240217144826.3944-1-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [RFC] riscv: dts: sophgo: add sdcard support for milkv duo | expand |
Adding Inochia. hi, Jisheng, For changes under arch/riscv/boot/dts/sophgo/, please looping Inochia and me. FYI: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@IA1PR20MB4953.namprd20.prod.outlook.com/ Thanks, Chen On 2024/2/17 22:48, Jisheng Zhang wrote: > Add sdhci dt node in SoC dtsi and enable it in milkv duo dts. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > Since cv1800b's clk support isn't in, this patch uses fixed dummy clk > and just RFC, I will send formal patch after clk support is ready. > > .../riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts | 8 ++++++++ > arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 17 +++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts > index 3af9e34b3bc7..94e64ddce8fa 100644 > --- a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts > +++ b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts > @@ -33,6 +33,14 @@ &osc { > clock-frequency = <25000000>; > }; > > +&sdhci0 { > + status = "okay"; > + bus-width = <4>; > + no-1-8-v; > + no-mmc; > + no-sdio; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > index 2d6f4a4b1e58..405f4ba18392 100644 > --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > @@ -4,6 +4,7 @@ > * Copyright (C) 2023 Inochi Amaoto <inochiama@outlook.com> > */ > > +#include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/irq.h> > > / { > @@ -45,6 +46,13 @@ osc: oscillator { > #clock-cells = <0>; > }; > > + sdhci_clk: sdhci-clock { > + compatible = "fixed-clock"; > + clock-frequency = <375000000>; > + clock-output-names = "sdhci_clk"; > + #clock-cells = <0>; > + }; > + > soc { > compatible = "simple-bus"; > interrupt-parent = <&plic>; > @@ -175,6 +183,15 @@ uart4: serial@41c0000 { > status = "disabled"; > }; > > + sdhci0: mmc@4310000 { > + compatible = "sophgo,cv1800b-dwcmshc"; > + reg = <0x4310000 0x1000>; > + interrupts = <36 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&sdhci_clk>; > + clock-names = "core"; > + status = "disabled"; > + }; > + > plic: interrupt-controller@70000000 { > reg = <0x70000000 0x4000000>; > interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;
On Sat, Feb 17, 2024 at 10:48:26PM +0800, Jisheng Zhang wrote: > Add sdhci dt node in SoC dtsi and enable it in milkv duo dts. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> LGTM. Reviewed-by: Inochi Amaoto <inochiama@outlook.com> > --- > Since cv1800b's clk support isn't in, this patch uses fixed dummy clk > and just RFC, I will send formal patch after clk support is ready. > > .../riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts | 8 ++++++++ > arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 17 +++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts > index 3af9e34b3bc7..94e64ddce8fa 100644 > --- a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts > +++ b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts > @@ -33,6 +33,14 @@ &osc { > clock-frequency = <25000000>; > }; > > +&sdhci0 { > + status = "okay"; > + bus-width = <4>; > + no-1-8-v; > + no-mmc; > + no-sdio; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > index 2d6f4a4b1e58..405f4ba18392 100644 > --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > @@ -4,6 +4,7 @@ > * Copyright (C) 2023 Inochi Amaoto <inochiama@outlook.com> > */ > > +#include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/irq.h> > > / { > @@ -45,6 +46,13 @@ osc: oscillator { > #clock-cells = <0>; > }; > > + sdhci_clk: sdhci-clock { > + compatible = "fixed-clock"; > + clock-frequency = <375000000>; > + clock-output-names = "sdhci_clk"; > + #clock-cells = <0>; > + }; > + > soc { > compatible = "simple-bus"; > interrupt-parent = <&plic>; > @@ -175,6 +183,15 @@ uart4: serial@41c0000 { > status = "disabled"; > }; > > + sdhci0: mmc@4310000 { > + compatible = "sophgo,cv1800b-dwcmshc"; > + reg = <0x4310000 0x1000>; > + interrupts = <36 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&sdhci_clk>; > + clock-names = "core"; > + status = "disabled"; > + }; > + > plic: interrupt-controller@70000000 { > reg = <0x70000000 0x4000000>; > interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>; > -- > 2.43.0 >
On Sat, 17 Feb 2024 22:48:26 +0800, Jisheng Zhang wrote: > Add sdhci dt node in SoC dtsi and enable it in milkv duo dts. > > Applied to sophgo/for-next, thanks! [1/1] riscv: dts: sophgo: add sdcard support for milkv duo https://github.com/sophgo/linux/commit/89a7056ed4f771e689729f7992ef5351e64e26c6 Thanks, Inochi
diff --git a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts index 3af9e34b3bc7..94e64ddce8fa 100644 --- a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts +++ b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts @@ -33,6 +33,14 @@ &osc { clock-frequency = <25000000>; }; +&sdhci0 { + status = "okay"; + bus-width = <4>; + no-1-8-v; + no-mmc; + no-sdio; +}; + &uart0 { status = "okay"; }; diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi index 2d6f4a4b1e58..405f4ba18392 100644 --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi @@ -4,6 +4,7 @@ * Copyright (C) 2023 Inochi Amaoto <inochiama@outlook.com> */ +#include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> / { @@ -45,6 +46,13 @@ osc: oscillator { #clock-cells = <0>; }; + sdhci_clk: sdhci-clock { + compatible = "fixed-clock"; + clock-frequency = <375000000>; + clock-output-names = "sdhci_clk"; + #clock-cells = <0>; + }; + soc { compatible = "simple-bus"; interrupt-parent = <&plic>; @@ -175,6 +183,15 @@ uart4: serial@41c0000 { status = "disabled"; }; + sdhci0: mmc@4310000 { + compatible = "sophgo,cv1800b-dwcmshc"; + reg = <0x4310000 0x1000>; + interrupts = <36 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sdhci_clk>; + clock-names = "core"; + status = "disabled"; + }; + plic: interrupt-controller@70000000 { reg = <0x70000000 0x4000000>; interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;
Add sdhci dt node in SoC dtsi and enable it in milkv duo dts. Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- Since cv1800b's clk support isn't in, this patch uses fixed dummy clk and just RFC, I will send formal patch after clk support is ready. .../riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts | 8 ++++++++ arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 17 +++++++++++++++++ 2 files changed, 25 insertions(+)