diff mbox series

riscv: Remove unused asm/signal.h file

Message ID 20240310112129.376134-1-shorne@gmail.com (mailing list archive)
State Superseded
Headers show
Series riscv: Remove unused asm/signal.h file | expand

Checks

Context Check Description
conchuod/vmtest-for-next-PR success PR summary
conchuod/patch-1-test-1 success .github/scripts/patches/tests/build_rv32_defconfig.sh
conchuod/patch-1-test-2 success .github/scripts/patches/tests/build_rv64_clang_allmodconfig.sh
conchuod/patch-1-test-3 success .github/scripts/patches/tests/build_rv64_gcc_allmodconfig.sh
conchuod/patch-1-test-4 success .github/scripts/patches/tests/build_rv64_nommu_k210_defconfig.sh
conchuod/patch-1-test-5 success .github/scripts/patches/tests/build_rv64_nommu_virt_defconfig.sh
conchuod/patch-1-test-6 warning .github/scripts/patches/tests/checkpatch.sh
conchuod/patch-1-test-7 success .github/scripts/patches/tests/dtb_warn_rv64.sh
conchuod/patch-1-test-8 success .github/scripts/patches/tests/header_inline.sh
conchuod/patch-1-test-9 success .github/scripts/patches/tests/kdoc.sh
conchuod/patch-1-test-10 success .github/scripts/patches/tests/module_param.sh
conchuod/patch-1-test-11 success .github/scripts/patches/tests/verify_fixes.sh
conchuod/patch-1-test-12 success .github/scripts/patches/tests/verify_signedoff.sh

Commit Message

Stafford Horne March 10, 2024, 11:21 a.m. UTC 
When riscv moved to common entry the definition and usage of
do_work_pending was removed.  This unused header file remains.

Remove the header file as it is not used.

I have tested compiling the kernel with this patch applied and saw no
issues.  Noticed when auditing how different ports handle signals
related to saving FPU state.

Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/riscv/include/asm/signal.h | 12 ------------
 1 file changed, 12 deletions(-)
 delete mode 100644 arch/riscv/include/asm/signal.h

Comments

Guo Ren March 11, 2024, 8:30 a.m. UTC | #1 
On Sun, Mar 10, 2024 at 7:21 PM Stafford Horne <shorne@gmail.com> wrote:
>
> When riscv moved to common entry the definition and usage of
> do_work_pending was removed.  This unused header file remains.
>
> Remove the header file as it is not used.
>
> I have tested compiling the kernel with this patch applied and saw no
> issues.  Noticed when auditing how different ports handle signals
> related to saving FPU state.
>
> Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>  arch/riscv/include/asm/signal.h | 12 ------------
>  1 file changed, 12 deletions(-)
>  delete mode 100644 arch/riscv/include/asm/signal.h
>
> diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
> deleted file mode 100644
> index 956ae0a01bad..000000000000
> --- a/arch/riscv/include/asm/signal.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -
> -#ifndef __ASM_SIGNAL_H
> -#define __ASM_SIGNAL_H
> -
> -#include <uapi/asm/signal.h>
> -#include <uapi/asm/ptrace.h>
> -
> -asmlinkage __visible
> -void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
No more calling in arch/riscv for do_work_pending.

> -
> -#endif
> --
> 2.41.0
>
LGTM, Thx.

Reviewed-by: Guo Ren <guoren@kernel.org>
diff mbox series

Patch

diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
deleted file mode 100644
index 956ae0a01bad..000000000000
--- a/arch/riscv/include/asm/signal.h
+++ /dev/null
@@ -1,12 +0,0 @@ 
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef __ASM_SIGNAL_H
-#define __ASM_SIGNAL_H
-
-#include <uapi/asm/signal.h>
-#include <uapi/asm/ptrace.h>
-
-asmlinkage __visible
-void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
-
-#endif