| Message ID | 20240328-jag-sysctl_remset_misc-v1-1-47c1463b3af2@samsung.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [1/7] memory: Remove the now superfluous sentinel element from ctl_table array | expand |
> On Mar 28, 2024, at 23:57, Joel Granados via B4 Relay <devnull+j.granados.samsung.com@kernel.org> wrote: > > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which will > reduce the overall build time size of the kernel and run time memory > bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove sentinel from all files under mm/ that register a sysctl table. > > Signed-off-by: Joel Granados <j.granados@samsung.com> Reviewed-by: Muchun Song <muchun.song@linux.dev> THanks.
On 2024/3/28 23:57, Joel Granados via B4 Relay wrote: > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which will > reduce the overall build time size of the kernel and run time memory > bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove sentinel from all files under mm/ that register a sysctl table. > > Signed-off-by: Joel Granados <j.granados@samsung.com> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Thanks. > --- > mm/compaction.c | 1 - > mm/hugetlb.c | 1 - > mm/hugetlb_vmemmap.c | 1 - > mm/memory-failure.c | 1 - > mm/oom_kill.c | 1 - > mm/page-writeback.c | 1 - > mm/page_alloc.c | 1 - > 7 files changed, 7 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 807b58e6eb68..e8a047afca22 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -3345,7 +3345,6 @@ static struct ctl_table vm_compaction[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > - { } > }; > > static int __init kcompactd_init(void) > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 23ef240ba48a..7ac5240a197d 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5045,7 +5045,6 @@ static struct ctl_table hugetlb_table[] = { > .mode = 0644, > .proc_handler = hugetlb_overcommit_handler, > }, > - { } > }; > > static void hugetlb_sysctl_init(void) > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index da177e49d956..b9a55322e52c 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -679,7 +679,6 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = { > .mode = 0644, > .proc_handler = proc_dobool, > }, > - { } > }; > > static int __init hugetlb_vmemmap_init(void) > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 9349948f1abf..6a112f9ecf91 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -141,7 +141,6 @@ static struct ctl_table memory_failure_table[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > - { } > }; > > /* > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 8d6a207c3c59..4d7a0004df2c 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -724,7 +724,6 @@ static struct ctl_table vm_oom_kill_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec, > }, > - {} > }; > #endif > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 3e19b87049db..fba324e1a010 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2291,7 +2291,6 @@ static struct ctl_table vm_page_writeback_sysctls[] = { > .mode = 0644, > .proc_handler = proc_dointvec_jiffies, > }, > - {} > }; > #endif > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 14d39f34d336..8b9820620fe3 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6211,7 +6211,6 @@ static struct ctl_table page_alloc_sysctl_table[] = { > .extra2 = SYSCTL_ONE_HUNDRED, > }, > #endif > - {} > }; > > void __init page_alloc_sysctl_init(void) >
diff --git a/mm/compaction.c b/mm/compaction.c index 807b58e6eb68..e8a047afca22 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -3345,7 +3345,6 @@ static struct ctl_table vm_compaction[] = { .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, }, - { } }; static int __init kcompactd_init(void) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 23ef240ba48a..7ac5240a197d 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5045,7 +5045,6 @@ static struct ctl_table hugetlb_table[] = { .mode = 0644, .proc_handler = hugetlb_overcommit_handler, }, - { } }; static void hugetlb_sysctl_init(void) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index da177e49d956..b9a55322e52c 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -679,7 +679,6 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = { .mode = 0644, .proc_handler = proc_dobool, }, - { } }; static int __init hugetlb_vmemmap_init(void) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 9349948f1abf..6a112f9ecf91 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -141,7 +141,6 @@ static struct ctl_table memory_failure_table[] = { .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, }, - { } }; /* diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 8d6a207c3c59..4d7a0004df2c 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -724,7 +724,6 @@ static struct ctl_table vm_oom_kill_table[] = { .mode = 0644, .proc_handler = proc_dointvec, }, - {} }; #endif diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 3e19b87049db..fba324e1a010 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2291,7 +2291,6 @@ static struct ctl_table vm_page_writeback_sysctls[] = { .mode = 0644, .proc_handler = proc_dointvec_jiffies, }, - {} }; #endif diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 14d39f34d336..8b9820620fe3 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6211,7 +6211,6 @@ static struct ctl_table page_alloc_sysctl_table[] = { .extra2 = SYSCTL_ONE_HUNDRED, }, #endif - {} }; void __init page_alloc_sysctl_init(void)