| Message ID | 20240725121609.13101-9-pierre-henry.moussay@microchip.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for Microchip PIC64GX Curiosity Kit | expand |
On Thu, Jul 25, 2024 at 01:16:00PM +0100, pierre-henry.moussay@microchip.com wrote: > From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com> > > PIC64GX has a clock controller compatible whith mpfs-clkcfg > > Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com> > --- > .../devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml b/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml > index e4e1c31267d2..ca889f5df87a 100644 > --- a/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml > +++ b/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml > @@ -19,7 +19,11 @@ description: | > > properties: > compatible: > - const: microchip,mpfs-clkcfg > + oneOf: > + - items: > + - const: microchip,pic64gx-clkcfg > + - const: microchip,mpfs-clkcfg > + - const: microchip,mpfs-clkcfg Ditto here, the mpfs binding is wrong and I don't want the pic64gx to ape that. Instead, we should take the opportunity to fix the binding. You're gonna need to do that so that the pinctrl driver can access the IOMUX registers correctly. As with the mailbox, either simplemfd or syscon are needed here. I mocked something up a few weeks ago while talking to someone about a hwmon driver, I'll dig it up when I am back to work. Cheers, Conor. > > reg: > items: > -- > 2.30.2 > >
diff --git a/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml b/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml index e4e1c31267d2..ca889f5df87a 100644 --- a/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml +++ b/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml @@ -19,7 +19,11 @@ description: | properties: compatible: - const: microchip,mpfs-clkcfg + oneOf: + - items: + - const: microchip,pic64gx-clkcfg + - const: microchip,mpfs-clkcfg + - const: microchip,mpfs-clkcfg reg: items: