| Message ID | 20240807-make_andes_static-v1-1-b64bf4c3d941@rivosinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 594ffcf4efe5094876f5b549a36262416104cd3d |
| Headers | show |
| Series | riscv: Make riscv_isa_vendor_ext_andes array static | expand |
Hi Charlie, On 08/08/2024 02:27, Charlie Jenkins wrote: > Since this array is only used in this file, it should be static. > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/ > --- > arch/riscv/kernel/vendor_extensions/andes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/vendor_extensions/andes.c b/arch/riscv/kernel/vendor_extensions/andes.c > index ec688c88456a..51f302b6d503 100644 > --- a/arch/riscv/kernel/vendor_extensions/andes.c > +++ b/arch/riscv/kernel/vendor_extensions/andes.c > @@ -8,7 +8,7 @@ > #include <linux/types.h> > > /* All Andes vendor extensions supported in Linux */ > -const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = { > +static const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = { > __RISCV_ISA_EXT_DATA(xandespmu, RISCV_ISA_VENDOR_EXT_XANDESPMU), > }; > > > --- > base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b > change-id: 20240807-make_andes_static-ec524bae21f2 Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Thanks, Alex
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Wed, 07 Aug 2024 17:27:42 -0700 you wrote: > Since this array is only used in this file, it should be static. > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/ > --- > arch/riscv/kernel/vendor_extensions/andes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the summary with links: - riscv: Make riscv_isa_vendor_ext_andes array static https://git.kernel.org/riscv/c/594ffcf4efe5 You are awesome, thank you!
diff --git a/arch/riscv/kernel/vendor_extensions/andes.c b/arch/riscv/kernel/vendor_extensions/andes.c index ec688c88456a..51f302b6d503 100644 --- a/arch/riscv/kernel/vendor_extensions/andes.c +++ b/arch/riscv/kernel/vendor_extensions/andes.c @@ -8,7 +8,7 @@ #include <linux/types.h> /* All Andes vendor extensions supported in Linux */ -const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = { +static const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = { __RISCV_ISA_EXT_DATA(xandespmu, RISCV_ISA_VENDOR_EXT_XANDESPMU), };
Since this array is only used in this file, it should be static. Signed-off-by: Charlie Jenkins <charlie@rivosinc.com> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/ --- arch/riscv/kernel/vendor_extensions/andes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240807-make_andes_static-ec524bae21f2