From patchwork Tue Sep 10 12:51:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 13798513 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB0BBECE564 for ; Tue, 10 Sep 2024 12:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fP56nhh6mZHFV0iuVDX5uv9S8ApR4dbKndUr2hRWZqI=; b=O5YGwyPgcA27+3 hqyYDuSKpWPKSGg/bad43nZIlBaBJS0ODChhCOzPJX+XRglrWduFtuQTfYZ0+NiVrf6QqupdbqTAV 3S10JUp+UeOJRgxtfzZr+IA31k83ZUENQ3d3SSz5lNOUjNKWwMZsL5aBFH/qecaYQ3OzhtBUa0TsI p7ZkebPAsqto9JRngrShStTujZbdpvZ2NlL/hwR6YvCACGQJEmj6jYw+SFrk/7p3op72E1ChHb3RL GmDP67qyjxpBhe5VgBqOVz6vCcuMXFuW8gi4mk2355Ybzx1EB4z82ZOCnssgbtfqm9ILfr0NaeUfK AG4PMqHJseLkp4lE/p4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so0Q9-00000005dVf-3vhj; Tue, 10 Sep 2024 12:56:37 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so0LD-00000005cJX-1O1S; Tue, 10 Sep 2024 12:51:32 +0000 Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-2d87f34a650so3775963a91.1; Tue, 10 Sep 2024 05:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725972691; x=1726577491; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UwvRv3wJIDozdKt4626HoR6j934EORaOhOiizGhVlEQ=; b=MHkl4QVcyN6CIuI5acC+LmDECWT+V1CiFBKtTyLlehmzB699zCHISw5f90khTjvo+9 GDiLaQP9/AaUWsG6DU5I2MP2mAl2ycifxAi4476Rs7yZVZf63OnREiiHpyteaZH3XGUu S81mHt93YUAxPar5FzwjTL+ouygxWgmT9csxWxUokFVnSXfNhafxqQev8rLY13UWTTzb 5PVvIS1M9QMn6wP1iuWFpDYs6Y4UmdFL+7YP3AX9ur3EKEu4A5C5/lfN48lA0i73I1xz rL4K/Qw5fwMnclisTe7Wa2cBCeUMPH+5xaRA7GrWG7/Xr7slle3HgQcDybQQNysK0Jc3 Y9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725972691; x=1726577491; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UwvRv3wJIDozdKt4626HoR6j934EORaOhOiizGhVlEQ=; b=FvXFc5TPDoFVuCNZixpmScdVPJ0AwWUBfPby/93er+84Lv0smiLjIy6p3AkFRILD/w q+MNKcwA872cdK3vR0h3SwNBqshnrYn3dB/UPk4wdiEctJfTdgpaZkJ0ad6Mc0vPWuK5 gF1Qth4hB3DdbfjguqLWOWKf0iH7hZsth0xqBg7iFwrG10A7VPLot0KE1UOam7yKNUgD CMikFHFyXPczh4Q1Oh09Afpcii0KMesjvx5td1bVphKz+YiaMVG30ncsKeUE2ccsBrHf 8NCA1S4qW0GwUObfH5QbE88xCI3oMVQpIDY8yk0wIBCOkQpK0CdwILt76BcB2cEJ8w4Q inXA== X-Forwarded-Encrypted: i=1; AJvYcCV2RJC+guuQPZToPa2tMxZfTOOY/XuX2Zp41Wkww5cVRkkHnUh4fpGZzFZU84/clJKo5g7fZWPIQ4kFYNL2f2OW@lists.infradead.org, AJvYcCVNYOQQwfrB/hw+o24M+QHrvSMXtpUeVMp5a3947M7qbHv1jlgS9XDk6/yAMwOWbg3b5L8JRrPXZui9Nd61Cns1vw==@lists.infradead.org, AJvYcCWBOkmzQJY7rzQYErfUOTUPaBukRMyesdfKCtCvBWMTrJr5ikjvIcaPX/GMPOE5hrsT3LhOhqf6LJbxbzc=@lists.infradead.org X-Gm-Message-State: AOJu0YzEohAmxkhtnpqxRj+ad2uAvqk2b6sOm9BnB1K2EjfHk8kAooYm Z1PHh9R+Fzp2hpe3Hii05bg2J5xLNcv/4/eUEakaLR/xbmKlFloo X-Google-Smtp-Source: AGHT+IGroNxXPo2q0iinhOTGCE7e5d5prqrWOJ0qJja22FenNOZ6SsoWGZUouzQvScBqrLr4XaHpcw== X-Received: by 2002:a17:90a:9e4:b0:2c9:7343:71f1 with SMTP id 98e67ed59e1d1-2db671d9d58mr4299989a91.14.1725972690657; Tue, 10 Sep 2024 05:51:30 -0700 (PDT) Received: from localhost ([212.107.28.55]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2db044f37dasm6265325a91.34.2024.09.10.05.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 05:51:30 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu Date: Tue, 10 Sep 2024 20:51:10 +0800 Subject: [PATCH v3 4/4] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2835/tegra/omap2plus MIME-Version: 1.0 Message-Id: <20240910-fix-riscv-rt_group_sched-v3-4-486e75e5ae6d@gmail.com> References: <20240910-fix-riscv-rt_group_sched-v3-0-486e75e5ae6d@gmail.com> In-Reply-To: <20240910-fix-riscv-rt_group_sched-v3-0-486e75e5ae6d@gmail.com> To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Anup Patel , Heinrich Schuchardt , Huacai Chen , WANG Xuerui , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Tony Lindgren , Thierry Reding , Jonathan Hunter Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, Stefan Wahren , Kevin Hilman , Celeste Liu X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2991; i=CoelacanthusHex@gmail.com; h=from:subject:message-id; bh=KOEEs/y0FGCkb+klP+KV9yU4iwr2GAi37Ho3J9O83lo=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaQ8cjir6+kzR+lXemlktLKMwjd0/+nsN053LZ/95b tR0LFP2z+0oZWEQ42KQFVNkEdv59PWy0kcflvGazICZw8oEMoSBi1MAJrKZg5HhTsqW+5GH5+f+ PfjZ/6VgcMRh1595TKq7D4cys8gH9mkpMTKsn7GpjoXF8dtcKaszT4L+POBuC/yTIPtRKmja47U cUz7zAQA0aEnq X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_055131_407881_CDF7251D X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Commit 673ce00c5d6c ("ARM: omap2plus_defconfig: Add support for distros with systemd") said it's because of recommendation from systemd. But systemd changed their recommendation later.[1] For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[2] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it. [1]: https://github.com/systemd/systemd/commit/f4e74be1856b3ac058acbf1be321c31d5299f69f [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 Tested-by: Stefan Wahren Acked-by: Kevin Hilman Signed-off-by: Celeste Liu Acked-by: Thierry Reding --- arch/arm/configs/bcm2835_defconfig | 1 - arch/arm/configs/omap2plus_defconfig | 1 - arch/arm/configs/tegra_defconfig | 1 - 3 files changed, 3 deletions(-) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig index b5f0bd8dd536990a0726e73a6855d25c1286a768..27dc3bf6b124c2012b7a1a768f2f900f49903cd1 100644 --- a/arch/arm/configs/bcm2835_defconfig +++ b/arch/arm/configs/bcm2835_defconfig @@ -7,7 +7,6 @@ CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y CONFIG_LOG_BUF_SHIFT=18 CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CPUSETS=y CONFIG_CGROUP_DEVICE=y diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index 3a166c2f02bd80634fee3bd8c4579fdbad84ccfa..9cb265c8d4144ea9a41f02640dbc8a06b710323b 100644 --- a/arch/arm/configs/omap2plus_defconfig +++ b/arch/arm/configs/omap2plus_defconfig @@ -13,7 +13,6 @@ CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CGROUP_SCHED=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CPUSETS=y CONFIG_CGROUP_DEVICE=y diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig index d2a094ad360cefefbc3bd35226c5d23eadce42c1..3a9bda2bf422b14085c60b39a2c3df86fe0994bb 100644 --- a/arch/arm/configs/tegra_defconfig +++ b/arch/arm/configs/tegra_defconfig @@ -6,7 +6,6 @@ CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_CGROUPS=y CONFIG_CGROUP_SCHED=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_DEBUG=y