| Message ID | 20250213-tidy-dollop-cbfc8fc7dc91@spud (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] riscv: dts: starfive: remove non-existent dac from jh7110 | expand |
| Context | Check | Description |
|---|---|---|
| bjorn/pre-ci_am | success | Success |
| bjorn/build-rv32-defconfig | success | build-rv32-defconfig |
| bjorn/build-rv64-clang-allmodconfig | success | build-rv64-clang-allmodconfig |
| bjorn/build-rv64-gcc-allmodconfig | success | build-rv64-gcc-allmodconfig |
| bjorn/build-rv64-nommu-k210-defconfig | success | build-rv64-nommu-k210-defconfig |
| bjorn/build-rv64-nommu-k210-virt | success | build-rv64-nommu-k210-virt |
| bjorn/checkpatch | success | checkpatch |
| bjorn/dtb-warn-rv64 | success | dtb-warn-rv64 |
| bjorn/header-inline | success | header-inline |
| bjorn/kdoc | success | kdoc |
| bjorn/module-param | success | module-param |
| bjorn/verify-fixes | success | verify-fixes |
| bjorn/verify-signedoff | success | verify-signedoff |
Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The jh7110 boards do not have a Rohm DAC on them as far as I > can tell, and they certainly do not have a dh2228fv, as this device does > not actually exist! Remove the dac nodes from the devicetrees as it is > not acceptable to pretend to have a device on a board in order to bind > the spidev driver in Linux. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Hmm.. I thought we already did this, but it must have been another board. In any case Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> Thanks! /Emil > --- > CC: Emil Renner Berthing <kernel@esmil.dk> > CC: Conor Dooley <conor@kernel.org> > CC: Rob Herring <robh@kernel.org> > CC: Krzysztof Kozlowski <krzk+dt@kernel.org> > CC: linux-riscv@lists.infradead.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi > index dd2eefc295e5..c2f70f5e2918 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi > @@ -350,12 +350,6 @@ &pwm { > &spi0 { > pinctrl-names = "default"; > pinctrl-0 = <&spi0_pins>; > - > - spi_dev0: spi@0 { > - compatible = "rohm,dh2228fv"; > - reg = <0>; > - spi-max-frequency = <10000000>; > - }; > }; > > &syscrg { > -- > 2.45.2 >
From: Conor Dooley <conor.dooley@microchip.com> On Thu, 13 Feb 2025 20:03:52 +0000, Conor Dooley wrote: > The jh7110 boards do not have a Rohm DAC on them as far as I > can tell, and they certainly do not have a dh2228fv, as this device does > not actually exist! Remove the dac nodes from the devicetrees as it is > not acceptable to pretend to have a device on a board in order to bind > the spidev driver in Linux. > > > [...] Applied to riscv-dt-for-next, thanks! [1/1] riscv: dts: starfive: remove non-existent dac from jh7110 https://git.kernel.org/conor/c/4bdea6e33946 Thanks, Conor.
diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi index dd2eefc295e5..c2f70f5e2918 100644 --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi @@ -350,12 +350,6 @@ &pwm { &spi0 { pinctrl-names = "default"; pinctrl-0 = <&spi0_pins>; - - spi_dev0: spi@0 { - compatible = "rohm,dh2228fv"; - reg = <0>; - spi-max-frequency = <10000000>; - }; }; &syscrg {