| Message ID | 5ab111e71e88d545d7f03233f10b6d84ef3d6c21.1637362542.git.plr.vincent@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/6] riscv: dts: sifive unmatched: Name gpio lines | expand |
On 19/11/2021 23:55, Vincent Pelletier wrote: > Provides monitoring of core voltage and current: > tps544b20-i2c-0-1e > Adapter: i2c-ocores > vout1: 906.00 mV > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C) > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A) > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> > > --- > Note: checkpatch.pl complains about undocumented devicetree binding, > which is fixed by: > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u > > Changes since v2: > - Fix end-of-commit-message separator so change lists do not end up in them. > Changes since v1: > - Added missing "ti," prefix in compatible string. > - Remove trailing "." on subject line. > - Rename tree node. > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote: > Provides monitoring of core voltage and current: > tps544b20-i2c-0-1e > Adapter: i2c-ocores > vout1: 906.00 mV > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C) > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A) > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> > > --- > Note: checkpatch.pl complains about undocumented devicetree binding, > which is fixed by: > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u > > Changes since v2: > - Fix end-of-commit-message separator so change lists do not end up in them. > Changes since v1: > - Added missing "ti," prefix in compatible string. > - Remove trailing "." on subject line. > - Rename tree node. I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add TI DC-DC converters"), so I'm going to hold off on this one until the bindings land. I've put the others on fixes. Thanks! > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index 270360b258b7..6e7775fdae32 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -51,6 +51,11 @@ &uart1 { > &i2c0 { > status = "okay"; > > + regulator@1e { > + compatible = "ti,tps544b20"; > + reg = <0x1e>; > + }; > + > temperature-sensor@4c { > compatible = "ti,tmp451"; > reg = <0x4c>;
Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt: > On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote: > > Provides monitoring of core voltage and current: > > tps544b20-i2c-0-1e > > Adapter: i2c-ocores > > vout1: 906.00 mV > > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C) > > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A) > > > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> > > > > --- > > Note: checkpatch.pl complains about undocumented devicetree binding, > > which is fixed by: > > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u > > > > Changes since v2: > > - Fix end-of-commit-message separator so change lists do not end up in them. > > Changes since v1: > > - Added missing "ti," prefix in compatible string. > > - Remove trailing "." on subject line. > > - Rename tree node. > > I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add > TI DC-DC converters"), so I'm going to hold off on this one until the > bindings land. Can't this patch then simply go into your for-next branch then? The split is most times binding goes through the driver-tree (or Rob's dt tree) and the dts patch through an arch or soc tree. But in general once a maintainer accepts the binding it is ok to also apply the dts patch for the same cycle (aka merge window) the binding will be in. Heiko > > I've put the others on fixes. > > Thanks! > > > --- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index 270360b258b7..6e7775fdae32 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -51,6 +51,11 @@ &uart1 { > > &i2c0 { > > status = "okay"; > > > > + regulator@1e { > > + compatible = "ti,tps544b20"; > > + reg = <0x1e>; > > + }; > > + > > temperature-sensor@4c { > > compatible = "ti,tmp451"; > > reg = <0x4c>; > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv >
On Sun, Dec 19, 2021 at 3:57 PM Heiko Stübner <heiko@sntech.de> wrote: > > Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt: > > On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote: > > > Provides monitoring of core voltage and current: > > > tps544b20-i2c-0-1e > > > Adapter: i2c-ocores > > > vout1: 906.00 mV > > > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C) > > > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A) > > > > > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> > > > > > > --- > > > Note: checkpatch.pl complains about undocumented devicetree binding, > > > which is fixed by: > > > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u > > > > > > Changes since v2: > > > - Fix end-of-commit-message separator so change lists do not end up in them. > > > Changes since v1: > > > - Added missing "ti," prefix in compatible string. > > > - Remove trailing "." on subject line. > > > - Rename tree node. > > > > I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add > > TI DC-DC converters"), so I'm going to hold off on this one until the > > bindings land. > > Can't this patch then simply go into your for-next branch then? Yes. > The split is most times binding goes through the driver-tree > (or Rob's dt tree) and the dts patch through an arch or soc tree. > > But in general once a maintainer accepts the binding it is ok > to also apply the dts patch for the same cycle (aka merge window) > the binding will be in. Until there's issues with schema warnings showing up in specific branches, going thru different trees isn't an issue. There's a lot of warnings to fix first. Rob
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 270360b258b7..6e7775fdae32 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -51,6 +51,11 @@ &uart1 { &i2c0 { status = "okay"; + regulator@1e { + compatible = "ti,tps544b20"; + reg = <0x1e>; + }; + temperature-sensor@4c { compatible = "ti,tmp451"; reg = <0x4c>;
Provides monitoring of core voltage and current: tps544b20-i2c-0-1e Adapter: i2c-ocores vout1: 906.00 mV temp1: -40.0°C (high = +125.0°C, crit = +150.0°C) iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A) Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> --- Note: checkpatch.pl complains about undocumented devicetree binding, which is fixed by: https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u Changes since v2: - Fix end-of-commit-message separator so change lists do not end up in them. Changes since v1: - Added missing "ti," prefix in compatible string. - Remove trailing "." on subject line. - Rename tree node. --- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++ 1 file changed, 5 insertions(+)