| Message ID | 20190808103432.12062-1-ezequiel@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: hantro: Add support for H264 decoding | expand |
Hi Ezequiel, On Thu, 2019-08-08 at 07:34 -0300, Ezequiel Garcia wrote: > This series is consolidating the two recent H264 series submitted > by Boris [1] [2]. Given some patches from [2] have been merged (namely, > helpers for the Hantro driver), the series contains the remanining > bits required to support H264 on Hantro G1 VPU. > > * Patch 1 adds support for the sort_r() variant and has > been posted separately by Rasmus. It would be good to merge this patch > via the media tree, ideally as soon as possible, to avoid the > synchronisation burden that might appear if we decide to delay it. > > * Patch 2 to 4 extends the H264 uAPI, introducing frame-based vs slice-based > decoding granularity, and also support for different NALU start codes. > Currently, Annex B and no start codes are the supported options. > > With the introduction of the start code control, the H264 parsed > slices pixel format should be renamed, dropping the _RAW suffix, > which is now meaningless. > > * Patch 5 removes the P0/B0/B1 ref lists from the decode_params control. > These lists are no longer needed since we build them on the > kernel side based on the DPB. > > * Patch 6 and 7 exposes the proper decoding mode and start code > on the cedrus driver. The driver functionality is not changed, > and only the Cedrus support is now being properly exposed to > userspace. > > * Patch 8 is needed to properly propagate the OUTPUT buffer timestamp to > the CAPTURE buffer one, which is required for intra-frame references. > > * Patches 9 to 11 adds H264 support for Hantro G1 and then enable > H264 decoding on RK3288. > > This series has been tested using MPV/Ffmpeg, on Rockchip RK3288 > for Hantro and Allwinner H3 boards for Cedrus. Tested-by: Philipp Zabel <p.zabel@pengutronix.de> on i.MX8MQ EVK using [1], so I effectively patches 1-5 and 8-10, with your FFmpeg modifications [2]. [1] git://git.pengutronix.de/git/pza/linux.git hantro/imx8m-wip [2] https://gitlab.collabora.com/ezequiel/ffmpeg stateless-mpeg2-vp8- h264-v4 regards Philipp
On Mon, 2019-08-12 at 12:41 +0200, Philipp Zabel wrote: > Hi Ezequiel, > > On Thu, 2019-08-08 at 07:34 -0300, Ezequiel Garcia wrote: > > This series is consolidating the two recent H264 series submitted > > by Boris [1] [2]. Given some patches from [2] have been merged (namely, > > helpers for the Hantro driver), the series contains the remanining > > bits required to support H264 on Hantro G1 VPU. > > > > * Patch 1 adds support for the sort_r() variant and has > > been posted separately by Rasmus. It would be good to merge this patch > > via the media tree, ideally as soon as possible, to avoid the > > synchronisation burden that might appear if we decide to delay it. > > > > * Patch 2 to 4 extends the H264 uAPI, introducing frame-based vs slice-based > > decoding granularity, and also support for different NALU start codes. > > Currently, Annex B and no start codes are the supported options. > > > > With the introduction of the start code control, the H264 parsed > > slices pixel format should be renamed, dropping the _RAW suffix, > > which is now meaningless. > > > > * Patch 5 removes the P0/B0/B1 ref lists from the decode_params control. > > These lists are no longer needed since we build them on the > > kernel side based on the DPB. > > > > * Patch 6 and 7 exposes the proper decoding mode and start code > > on the cedrus driver. The driver functionality is not changed, > > and only the Cedrus support is now being properly exposed to > > userspace. > > > > * Patch 8 is needed to properly propagate the OUTPUT buffer timestamp to > > the CAPTURE buffer one, which is required for intra-frame references. > > > > * Patches 9 to 11 adds H264 support for Hantro G1 and then enable > > H264 decoding on RK3288. > > > > This series has been tested using MPV/Ffmpeg, on Rockchip RK3288 > > for Hantro and Allwinner H3 boards for Cedrus. > > Tested-by: Philipp Zabel <p.zabel@pengutronix.de> > > on i.MX8MQ EVK using [1], so I effectively patches 1-5 and 8-10, with > your FFmpeg modifications [2]. > > [1] git://git.pengutronix.de/git/pza/linux.git hantro/imx8m-wip > [2] https://gitlab.collabora.com/ezequiel/ffmpeg stateless-mpeg2-vp8- > h264-v4 > Glad to hear things work properly. I'm adding your tested-by to all patches except those that apply to cedrus and rk3288. Thank you very much for the test, Ezequiel