[v4l-utils,v5,0/4] v4l2-ctl: add support to the CSC API

Message

Dafna Hirschfeld July 3, 2020, 6:02 p.m. UTC

This patchset is the userspace support for the CSC API RFC v5:
https://patchwork.kernel.org/project/linux-media/list/?series=312673

Patches Summary:
================

patch 1 - allows userspace to set the colorspace, quantization,
{ycbcr/hsv}_enc and xfer_func fields in the command
'v4l2-ctl --set-fmt-video ..' it also adds the new enumeration
flags to the compliance tests.

patch 2 - adds the new enumeration flags V4L2_FMT_FLAG_CSC* to
the function that prints the string description of the flags.
The array fmtdesc_def is replaced by a macro FMTDESC_DEF(enc_type)
since the flags V4L2_FMT_FLAG_CSC_YCBCR_ENC,V4L2_FMT_FLAG_CSC_HSV_ENC,
have identical value and the string should change according to whether
the pixelformat is HSV or not.

patches 4, 3 - are similar to patches 1, 2 but for subdevices.
So patch 3 adds support for the CSC API for subdevices
and patch 4 adds the new enumeration flags V4L2_SUBDEV_MBUS_CODE_CSC*
to the framework that prints the related string description

Testing:
=======

I added a python script to run all possible combinations of CSC
settings on vivid:
https://gitlab.collabora.com/dafna/v4l-utils/-/blob/rfc-v5-jul-3-abend/contrib/test/vivid_test_csc.py

NOTE that the scripts might run for long time (1-2) hours since it iterates all possible combinations
of csc conversions in vivid.

The commands to run the script:

git clone --single-branch --branch rfc-v5-jul-3-abend  https://gitlab.collabora.com/dafna/v4l-utils.git
# <compile v4l-utils>
cd v4l-utils/contrib/test/
modprobe vivid
python3 vivid_test_csc.py

Also added test for rkisp1:
https://gitlab.collabora.com/dafna/v4l-utils/-/blob/rfc-v5-jul-3-abend/contrib/test/rkisp1-unit-tests.sh

To run the test:

git clone --single-branch --branch rfc-v5-jul-3-abend  https://gitlab.collabora.com/dafna/v4l-utils.git
# <compile v4l-utils>
cd v4l-utils/contrib/test/
./rkisp1-unit-tests.sh

changes since v4:
- adding support to CSC of the colorspace and xfer_func fields
in video devices and subdevices.

Dafna Hirschfeld (4):
  v4l2-ctl: vidcap: Add support for the CSC API
  v4l2: common: add the flags V4L2_FMT_FLAG_CSC* to the list that maps
    flags to str
  v4l2-ctl: subdev: Add support for the CSC API in the subdevices
  v4l2-ctl: subdev: Add the flags to the list of supported mbus formats

 utils/common/v4l2-info.cpp                  | 47 +++++++++++++++++----
 utils/common/v4l2-info.h                    |  6 ++-
 utils/v4l2-compliance/v4l2-test-formats.cpp |  4 +-
 utils/v4l2-ctl/v4l2-ctl-subdev.cpp          | 26 +++++++++---
 utils/v4l2-ctl/v4l2-ctl-vidcap.cpp          | 39 +++++++++++++++--
 utils/v4l2-ctl/v4l2-ctl.cpp                 | 16 +++++--
 6 files changed, 114 insertions(+), 24 deletions(-)