| Message ID | 20220926080435.259617-1-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/rockchip: dw_hdmi: Add 4k@30 support | expand |
Hi Sascha, On 9/26/22 10:04, Sascha Hauer wrote: > This series adds support for 4k@30 to the rockchip HDMI controller. This > has been tested on a rk3568 rock3a board. It should be possible to add > 4k@60 support the same way, but it doesn't work for me, so let's add > 4k@30 as a first step. > Sascha > > Changes since v1: > - Allow non standard clock rates only on Synopsys phy as suggested by > Robin Murphy > > Sascha Hauer (2): > drm/rockchip: dw_hdmi: relax mode_valid hook > drm/rockchip: dw_hdmi: Add support for 4k@30 resolution > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- > 1 file changed, 27 insertions(+), 7 deletions(-) Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor Tested-by: Michael Riesch <michael.riesch@wolfvision.net> Best regards, Michael
Den 26.09.2022 kl. 12.30 skrev Michael Riesch: > Hi Sascha, > > On 9/26/22 10:04, Sascha Hauer wrote: >> This series adds support for 4k@30 to the rockchip HDMI controller. This >> has been tested on a rk3568 rock3a board. It should be possible to add >> 4k@60 support the same way, but it doesn't work for me, so let's add >> 4k@30 as a first step. >> Sascha >> >> Changes since v1: >> - Allow non standard clock rates only on Synopsys phy as suggested by >> Robin Murphy >> >> Sascha Hauer (2): >> drm/rockchip: dw_hdmi: relax mode_valid hook >> drm/rockchip: dw_hdmi: Add support for 4k@30 resolution >> >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- >> 1 file changed, 27 insertions(+), 7 deletions(-) > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net> Sadly this still doesn't give my display out on my 2k monitor. Not even just 1080p picture like the old current implementation does. > > Best regards, > Michael > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch: > > Hi Sascha, > > > > On 9/26/22 10:04, Sascha Hauer wrote: > > > This series adds support for 4k@30 to the rockchip HDMI controller. This > > > has been tested on a rk3568 rock3a board. It should be possible to add > > > 4k@60 support the same way, but it doesn't work for me, so let's add > > > 4k@30 as a first step. > > > Sascha > > > > > > Changes since v1: > > > - Allow non standard clock rates only on Synopsys phy as suggested by > > > Robin Murphy > > > > > > Sascha Hauer (2): > > > drm/rockchip: dw_hdmi: relax mode_valid hook > > > drm/rockchip: dw_hdmi: Add support for 4k@30 resolution > > > > > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- > > > 1 file changed, 27 insertions(+), 7 deletions(-) > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor > > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net> > > Sadly this still doesn't give my display out on my 2k monitor. Not even just > 1080p picture like the old current implementation does. By "like the old current implementation" you mean that this patchset introduces a regression for you? Sascha
Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: >> Den 26.09.2022 kl. 12.30 skrev Michael Riesch: >>> Hi Sascha, >>> >>> On 9/26/22 10:04, Sascha Hauer wrote: >>>> This series adds support for 4k@30 to the rockchip HDMI controller. This >>>> has been tested on a rk3568 rock3a board. It should be possible to add >>>> 4k@60 support the same way, but it doesn't work for me, so let's add >>>> 4k@30 as a first step. >>>> Sascha >>>> >>>> Changes since v1: >>>> - Allow non standard clock rates only on Synopsys phy as suggested by >>>> Robin Murphy >>>> >>>> Sascha Hauer (2): >>>> drm/rockchip: dw_hdmi: relax mode_valid hook >>>> drm/rockchip: dw_hdmi: Add support for 4k@30 resolution >>>> >>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- >>>> 1 file changed, 27 insertions(+), 7 deletions(-) >>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor >>> >>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> >> Sadly this still doesn't give my display out on my 2k monitor. Not even just >> 1080p picture like the old current implementation does. > By "like the old current implementation" you mean that this patchset > introduces a regression for you? Yes. What currently in the kernel at least shows as 1080p on my 2K monitor, while this patchset turns off the screen. > > Sascha >
On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: > > Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: > > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: > > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch: > > > > Hi Sascha, > > > > > > > > On 9/26/22 10:04, Sascha Hauer wrote: > > > > > This series adds support for 4k@30 to the rockchip HDMI controller. This > > > > > has been tested on a rk3568 rock3a board. It should be possible to add > > > > > 4k@60 support the same way, but it doesn't work for me, so let's add > > > > > 4k@30 as a first step. > > > > > Sascha > > > > > > > > > > Changes since v1: > > > > > - Allow non standard clock rates only on Synopsys phy as suggested by > > > > > Robin Murphy > > > > > > > > > > Sascha Hauer (2): > > > > > drm/rockchip: dw_hdmi: relax mode_valid hook > > > > > drm/rockchip: dw_hdmi: Add support for 4k@30 resolution > > > > > > > > > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- > > > > > 1 file changed, 27 insertions(+), 7 deletions(-) > > > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor > > > > > > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net> > > > Sadly this still doesn't give my display out on my 2k monitor. Not even just > > > 1080p picture like the old current implementation does. > > By "like the old current implementation" you mean that this patchset > > introduces a regression for you? > Yes. What currently in the kernel at least shows as 1080p on my 2K monitor, > while this patchset turns off the screen. Which SoC are you testing this on? I assume RK3568, right? Which patch introduces that regression, the first or the second one? Sascha
Den 05.10.2022 kl. 12.06 skrev Sascha Hauer: > On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: >> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: >>> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: >>>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch: >>>>> Hi Sascha, >>>>> >>>>> On 9/26/22 10:04, Sascha Hauer wrote: >>>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This >>>>>> has been tested on a rk3568 rock3a board. It should be possible to add >>>>>> 4k@60 support the same way, but it doesn't work for me, so let's add >>>>>> 4k@30 as a first step. >>>>>> Sascha >>>>>> >>>>>> Changes since v1: >>>>>> - Allow non standard clock rates only on Synopsys phy as suggested by >>>>>> Robin Murphy >>>>>> >>>>>> Sascha Hauer (2): >>>>>> drm/rockchip: dw_hdmi: relax mode_valid hook >>>>>> drm/rockchip: dw_hdmi: Add support for 4k@30 resolution >>>>>> >>>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- >>>>>> 1 file changed, 27 insertions(+), 7 deletions(-) >>>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor >>>>> >>>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> >>>> Sadly this still doesn't give my display out on my 2k monitor. Not even just >>>> 1080p picture like the old current implementation does. >>> By "like the old current implementation" you mean that this patchset >>> introduces a regression for you? >> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor, >> while this patchset turns off the screen. > Which SoC are you testing this on? I assume RK3568, right? Which patch > introduces that regression, the first or the second one? I tested on the Odroid M, which is rk3568. I have only applied them both, as I was under the impression that both are needed for the 4k support. > > Sascha >
On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote: > > Den 05.10.2022 kl. 12.06 skrev Sascha Hauer: > > On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: > > > Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: > > > > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: > > > > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch: > > > > > > Hi Sascha, > > > > > > > > > > > > On 9/26/22 10:04, Sascha Hauer wrote: > > > > > > > This series adds support for 4k@30 to the rockchip HDMI controller. This > > > > > > > has been tested on a rk3568 rock3a board. It should be possible to add > > > > > > > 4k@60 support the same way, but it doesn't work for me, so let's add > > > > > > > 4k@30 as a first step. > > > > > > > Sascha > > > > > > > > > > > > > > Changes since v1: > > > > > > > - Allow non standard clock rates only on Synopsys phy as suggested by > > > > > > > Robin Murphy > > > > > > > > > > > > > > Sascha Hauer (2): > > > > > > > drm/rockchip: dw_hdmi: relax mode_valid hook > > > > > > > drm/rockchip: dw_hdmi: Add support for 4k@30 resolution > > > > > > > > > > > > > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- > > > > > > > 1 file changed, 27 insertions(+), 7 deletions(-) > > > > > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor > > > > > > > > > > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net> > > > > > Sadly this still doesn't give my display out on my 2k monitor. Not even just > > > > > 1080p picture like the old current implementation does. > > > > By "like the old current implementation" you mean that this patchset > > > > introduces a regression for you? > > > Yes. What currently in the kernel at least shows as 1080p on my 2K monitor, > > > while this patchset turns off the screen. > > Which SoC are you testing this on? I assume RK3568, right? Which patch > > introduces that regression, the first or the second one? > I tested on the Odroid M, which is rk3568. > I have only applied them both, as I was under the impression that both are > needed for the 4k support. Yes, both I needed, but I am interested which one introduces the regression as I can't reproduce it. Sascha
On 2022-10-05 12:10, Sascha Hauer wrote: > On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote: >> >> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer: >>> On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: >>>> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: >>>>> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: >>>>>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch: >>>>>>> Hi Sascha, >>>>>>> >>>>>>> On 9/26/22 10:04, Sascha Hauer wrote: >>>>>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This >>>>>>>> has been tested on a rk3568 rock3a board. It should be possible to add >>>>>>>> 4k@60 support the same way, but it doesn't work for me, so let's add >>>>>>>> 4k@30 as a first step. >>>>>>>> Sascha >>>>>>>> >>>>>>>> Changes since v1: >>>>>>>> - Allow non standard clock rates only on Synopsys phy as suggested by >>>>>>>> Robin Murphy >>>>>>>> >>>>>>>> Sascha Hauer (2): >>>>>>>> drm/rockchip: dw_hdmi: relax mode_valid hook >>>>>>>> drm/rockchip: dw_hdmi: Add support for 4k@30 resolution >>>>>>>> >>>>>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- >>>>>>>> 1 file changed, 27 insertions(+), 7 deletions(-) >>>>>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor >>>>>>> >>>>>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> >>>>>> Sadly this still doesn't give my display out on my 2k monitor. Not even just >>>>>> 1080p picture like the old current implementation does. >>>>> By "like the old current implementation" you mean that this patchset >>>>> introduces a regression for you? >>>> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor, >>>> while this patchset turns off the screen. >>> Which SoC are you testing this on? I assume RK3568, right? Which patch >>> introduces that regression, the first or the second one? >> I tested on the Odroid M, which is rk3568. >> I have only applied them both, as I was under the impression that both are >> needed for the 4k support. > > Yes, both I needed, but I am interested which one introduces the > regression as I can't reproduce it. One thing that might be worthwhile is to compare what "drm.debug=4" output says about the chosen mode and its clock rate vs. what /sys/kernel/debug/clk/clk_summary says about how things ended up in practice, to see whether it's a case of the clock not being able to get close enough to the correct rate at all. Robin.
Den 05.10.2022 kl. 13.10 skrev Sascha Hauer: > On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote: >> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer: >>> On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: >>>> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: >>>>> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote: >>>>>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch: >>>>>>> Hi Sascha, >>>>>>> >>>>>>> On 9/26/22 10:04, Sascha Hauer wrote: >>>>>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This >>>>>>>> has been tested on a rk3568 rock3a board. It should be possible to add >>>>>>>> 4k@60 support the same way, but it doesn't work for me, so let's add >>>>>>>> 4k@30 as a first step. >>>>>>>> Sascha >>>>>>>> >>>>>>>> Changes since v1: >>>>>>>> - Allow non standard clock rates only on Synopsys phy as suggested by >>>>>>>> Robin Murphy >>>>>>>> >>>>>>>> Sascha Hauer (2): >>>>>>>> drm/rockchip: dw_hdmi: relax mode_valid hook >>>>>>>> drm/rockchip: dw_hdmi: Add support for 4k@30 resolution >>>>>>>> >>>>>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++----- >>>>>>>> 1 file changed, 27 insertions(+), 7 deletions(-) >>>>>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor >>>>>>> >>>>>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> >>>>>> Sadly this still doesn't give my display out on my 2k monitor. Not even just >>>>>> 1080p picture like the old current implementation does. >>>>> By "like the old current implementation" you mean that this patchset >>>>> introduces a regression for you? >>>> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor, >>>> while this patchset turns off the screen. >>> Which SoC are you testing this on? I assume RK3568, right? Which patch >>> introduces that regression, the first or the second one? >> I tested on the Odroid M, which is rk3568. >> I have only applied them both, as I was under the impression that both are >> needed for the 4k support. > Yes, both I needed, but I am interested which one introduces the > regression as I can't reproduce it. Okay. Here's the result of some more tests of mine. Patch 1 by itself does not introduce any regressions on either 1080p or 2k monitors. Patch 2 by itself does not introduce any regressions on either 1080p or 2k monitors. Applying both Patch 1 and 2, _does_ introduce the regression on my 2k monitor, but _not_ on my 1080p monitor. The 2k monitor is a Dell P2418D with up to 2560x1440 resolution. The 1080p monitor is a Sony Bravia 46" TV with up to 1920x1080 resolution. > > Sascha >