[0/2] Fix HDMI CEC on Radxa ROCK 3 Model A

Message

Jonas Karlman Jan. 10, 2023, 10:55 p.m. UTC

The HDMI CEC is not working correctly on Radxa ROCK 3 Model A.

This series assigns a clock rate of 32768 to hdmi cec clock and a pinctrl
to use HDMITX_CEC_M1 function of GPIO0_C7.

Please note that this series also requires a fix in the pinctrl driver to
correctly select HDMITX IO mux M1 for a fully working HDMI CEC, see [1].

[1] https://lore.kernel.org/all/[e-mail]/

Jonas Karlman (2):
  arm64: dts: rockchip: assign rate to clk_rtc_32k on rk356x
  arm64: dts: rockchip: fix hdmi cec on rock-3a

 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 +
 arch/arm64/boot/dts/rockchip/rk356x.dtsi        | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Heiko Stübner Jan. 11, 2023, 10:48 a.m. UTC | #1

On Tue, 10 Jan 2023 22:55:50 +0000 (UTC), Jonas Karlman wrote:
> The HDMI CEC is not working correctly on Radxa ROCK 3 Model A.
> 
> This series assigns a clock rate of 32768 to hdmi cec clock and a pinctrl
> to use HDMITX_CEC_M1 function of GPIO0_C7.
> 
> Please note that this series also requires a fix in the pinctrl driver to
> correctly select HDMITX IO mux M1 for a fully working HDMI CEC, see [1].
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: assign rate to clk_rtc_32k on rk356x
      commit: 64b69474edf3b885c19a89bb165f978ba1b4be00
[2/2] arm64: dts: rockchip: fix hdmi cec on rock-3a
      commit: 906e822c0cac24f1b20d1377eb1203963f7af97e

On patch2 I've added a pinctrl-names = default entry as well.
To prevent future issues I think it's nicer to have them together
i.e. you want to set pinctrl-0 so prevent someone from introducing
a pinctrl-1 reference in the main node.


Best regards,