[0/4] arm64: dts: rockchip: aliases for core busses in main dtsi

Message

Heiko Stübner Dec. 1, 2023, 4:58 p.m. UTC

Placement of aliases is cause for a lot of discussion :-).
Most recently in [0]. And while devices such as mmc controllers do have
names not following any numbers, this is different for the core
busses/devices like serial, i2c, gpio, spi.

All of those start at number 0 and increment then. And all pieces of
documentation like soc manuals, device schematics as well as pin-header
descriptions for SBCs also use these numbers to identify the controller
instance.

All previous Rockchip socs also carry those core busses in the main dtsi
so that not every board needs to have the exact same aliases defined.


[0] https://lore.kernel.org/all/4762834.KRxA6XjA2N@diego/

Heiko Stuebner (4):
  arm64: dts: rockchip: move rk3588 serial aliases to soc dtsi
  arm64: dts: rockchip: add rk3588 i2c aliases to soc dtsi
  arm64: dts: rockchip: add rk3588 gpio aliases to soc dtsi
  arm64: dts: rockchip: add rk3588 spi aliases to soc dtsi

 .../dts/rockchip/rk3588-edgeble-neu6a-io.dts  |  4 ---
 .../dts/rockchip/rk3588-edgeble-neu6b-io.dts  |  4 ---
 .../boot/dts/rockchip/rk3588-evb1-v10.dts     |  1 -
 .../boot/dts/rockchip/rk3588-nanopc-t6.dts    |  1 -
 .../dts/rockchip/rk3588-orangepi-5-plus.dts   |  1 -
 .../boot/dts/rockchip/rk3588-quartzpro64.dts  |  1 -
 .../boot/dts/rockchip/rk3588-rock-5b.dts      |  1 -
 .../boot/dts/rockchip/rk3588-turing-rk1.dtsi  |  2 --
 .../dts/rockchip/rk3588s-indiedroid-nova.dts  |  1 -
 .../dts/rockchip/rk3588s-khadas-edge2.dts     |  1 -
 .../boot/dts/rockchip/rk3588s-orangepi-5.dts  |  1 -
 .../boot/dts/rockchip/rk3588s-rock-5a.dts     |  1 -
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 32 +++++++++++++++++++
 13 files changed, 32 insertions(+), 19 deletions(-)

Comments

Dragan Simic Dec. 1, 2023, 5:19 p.m. UTC | #1

On 2023-12-01 17:58, Heiko Stuebner wrote:
> Placement of aliases is cause for a lot of discussion :-).
> Most recently in [0]. And while devices such as mmc controllers do have
> names not following any numbers, this is different for the core
> busses/devices like serial, i2c, gpio, spi.
> 
> All of those start at number 0 and increment then. And all pieces of
> documentation like soc manuals, device schematics as well as pin-header
> descriptions for SBCs also use these numbers to identify the controller
> instance.
> 
> All previous Rockchip socs also carry those core busses in the main 
> dtsi
> so that not every board needs to have the exact same aliases defined.
> 
> [0] https://lore.kernel.org/all/4762834.KRxA6XjA2N@diego/
> 
> Heiko Stuebner (4):
>   arm64: dts: rockchip: move rk3588 serial aliases to soc dtsi
>   arm64: dts: rockchip: add rk3588 i2c aliases to soc dtsi
>   arm64: dts: rockchip: add rk3588 gpio aliases to soc dtsi
>   arm64: dts: rockchip: add rk3588 spi aliases to soc dtsi
> 
>  .../dts/rockchip/rk3588-edgeble-neu6a-io.dts  |  4 ---
>  .../dts/rockchip/rk3588-edgeble-neu6b-io.dts  |  4 ---
>  .../boot/dts/rockchip/rk3588-evb1-v10.dts     |  1 -
>  .../boot/dts/rockchip/rk3588-nanopc-t6.dts    |  1 -
>  .../dts/rockchip/rk3588-orangepi-5-plus.dts   |  1 -
>  .../boot/dts/rockchip/rk3588-quartzpro64.dts  |  1 -
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      |  1 -
>  .../boot/dts/rockchip/rk3588-turing-rk1.dtsi  |  2 --
>  .../dts/rockchip/rk3588s-indiedroid-nova.dts  |  1 -
>  .../dts/rockchip/rk3588s-khadas-edge2.dts     |  1 -
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dts  |  1 -
>  .../boot/dts/rockchip/rk3588s-rock-5a.dts     |  1 -
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 32 +++++++++++++++++++
>  13 files changed, 32 insertions(+), 19 deletions(-)

Thank you for cleaning this up.  Here's my Reviewed-by for the entire 
series:

Reviewed-by: Dragan Simic <[e-mail]>