mbox series

[0/2] Add the thermal zones of the rk3588 to its dts

Message ID 20240122203502.3311520-1-linkmauve@linkmauve.fr (mailing list archive)
Headers show
Series Add the thermal zones of the rk3588 to its dts | expand

Message

Link Mauve Jan. 22, 2024, 8:34 p.m. UTC
The driver got added back in 45d7b3867a5cabb97fc31f16122cda8540c3a30c,
but the dts never got updated, so here it is!

I’ve added it to the rk3588s because that’s where most of the
definitions are, but I’ve only tested on a rk3588 so maybe there are
subtle changes.

The rk3588 TRM also documents slightly different values (in part 1
section 14.5.3) than the driver, but I’ve left the values alone since I
have no way to determine which one is (more) correct.

Only the CPU is properly mapped, as neither the GPU nor the NPU have
been added to the dts for now, I’ve left some TODOs there.

All of the thermal zones report almost the same value on my rock-5b
board, I’m not sure if this is due to a programming error or if this is
to be expected.  For instance, after running for a while, all of the
zones report 44384 m℃, despite having used neither the GPU nor the NPU.

Additionally, the alert and crit temperatures have been arbitrarily
chosen based on other dts files, not based on any knowledge of the
thermal behaviours of this specific SoC.

Emmanuel Gil Peyrot (2):
  arm64: dts: rockchip: Add the rk3588 thermal zones
  arm64: dts: rockchip: Enable the tsadc on Rock-5B

 .../boot/dts/rockchip/rk3588-rock-5b.dts      |   4 +
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 181 ++++++++++++++++++
 2 files changed, 185 insertions(+)